Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
41d81132
Commit
41d81132
authored
Mar 01, 2017
by
Jakob Andersen
Committed by
GitHub
Mar 01, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't print stacktraces from ToolExit errors during flutter run. (#8453)
Instead, actually exit the tool. Fixes #8363.
parent
2a9fc2e7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
0 deletions
+8
-0
run_cold.dart
packages/flutter_tools/lib/src/run_cold.dart
+4
-0
run_hot.dart
packages/flutter_tools/lib/src/run_hot.dart
+4
-0
No files found.
packages/flutter_tools/lib/src/run_cold.dart
View file @
41d81132
...
@@ -8,6 +8,7 @@ import 'package:meta/meta.dart';
...
@@ -8,6 +8,7 @@ import 'package:meta/meta.dart';
import
'package:stack_trace/stack_trace.dart'
;
import
'package:stack_trace/stack_trace.dart'
;
import
'application_package.dart'
;
import
'application_package.dart'
;
import
'base/common.dart'
;
import
'base/file_system.dart'
;
import
'base/file_system.dart'
;
import
'base/utils.dart'
;
import
'base/utils.dart'
;
import
'build_info.dart'
;
import
'build_info.dart'
;
...
@@ -54,6 +55,9 @@ class ColdRunner extends ResidentRunner {
...
@@ -54,6 +55,9 @@ class ColdRunner extends ResidentRunner {
shouldBuild:
shouldBuild
shouldBuild:
shouldBuild
);
);
},
onError:
(
dynamic
error
,
StackTrace
stackTrace
)
{
},
onError:
(
dynamic
error
,
StackTrace
stackTrace
)
{
// Actually exit on ToolExit.
if
(
error
is
ToolExit
)
throw
error
;
printError
(
'Exception from flutter run:
$error
'
,
stackTrace
);
printError
(
'Exception from flutter run:
$error
'
,
stackTrace
);
});
});
}
}
...
...
packages/flutter_tools/lib/src/run_hot.dart
View file @
41d81132
...
@@ -8,6 +8,7 @@ import 'package:meta/meta.dart';
...
@@ -8,6 +8,7 @@ import 'package:meta/meta.dart';
import
'package:stack_trace/stack_trace.dart'
;
import
'package:stack_trace/stack_trace.dart'
;
import
'application_package.dart'
;
import
'application_package.dart'
;
import
'base/common.dart'
;
import
'base/context.dart'
;
import
'base/context.dart'
;
import
'base/file_system.dart'
;
import
'base/file_system.dart'
;
import
'base/logger.dart'
;
import
'base/logger.dart'
;
...
@@ -81,6 +82,9 @@ class HotRunner extends ResidentRunner {
...
@@ -81,6 +82,9 @@ class HotRunner extends ResidentRunner {
shouldBuild:
shouldBuild
shouldBuild:
shouldBuild
);
);
},
onError:
(
dynamic
error
,
StackTrace
stackTrace
)
{
},
onError:
(
dynamic
error
,
StackTrace
stackTrace
)
{
// Actually exit on ToolExit.
if
(
error
is
ToolExit
)
throw
error
;
printError
(
'Exception from flutter run:
$error
'
,
stackTrace
);
printError
(
'Exception from flutter run:
$error
'
,
stackTrace
);
});
});
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment