Commit 40e305dc authored by Adam Barth's avatar Adam Barth Committed by GitHub

Fix analyzer warnings (#7523)

I see these errors in Atom on my Mac. I'm not sure why they're not being
picked up by the bots.
parent 0ce9917f
...@@ -936,7 +936,7 @@ class _IntrinsicDimensionsCacheEntry { ...@@ -936,7 +936,7 @@ class _IntrinsicDimensionsCacheEntry {
/// these classes, however, you must implement the algorithm yourself. /// these classes, however, you must implement the algorithm yourself.
abstract class RenderBox extends RenderObject { abstract class RenderBox extends RenderObject {
@override @override
void setupParentData(RenderObject child) { void setupParentData(@checked RenderObject child) {
if (child.parentData is! BoxParentData) if (child.parentData is! BoxParentData)
child.parentData = new BoxParentData(); child.parentData = new BoxParentData();
} }
...@@ -1823,7 +1823,7 @@ abstract class RenderBox extends RenderObject { ...@@ -1823,7 +1823,7 @@ abstract class RenderBox extends RenderObject {
/// ``` /// ```
// TODO(ianh): Fix the type of the argument here once https://github.com/dart-lang/sdk/issues/25232 is fixed // TODO(ianh): Fix the type of the argument here once https://github.com/dart-lang/sdk/issues/25232 is fixed
@override @override
void handleEvent(PointerEvent event, HitTestEntry entry) { void handleEvent(PointerEvent event, @checked HitTestEntry entry) {
super.handleEvent(event, entry); super.handleEvent(event, entry);
} }
......
...@@ -2073,7 +2073,7 @@ class Flex extends MultiChildRenderObjectWidget { ...@@ -2073,7 +2073,7 @@ class Flex extends MultiChildRenderObjectWidget {
} }
@override @override
void updateRenderObject(BuildContext context, RenderFlex renderObject) { void updateRenderObject(BuildContext context, @checked RenderFlex renderObject) {
renderObject renderObject
..direction = direction ..direction = direction
..mainAxisAlignment = mainAxisAlignment ..mainAxisAlignment = mainAxisAlignment
......
...@@ -3456,7 +3456,7 @@ abstract class RenderObjectElement extends BuildableElement { ...@@ -3456,7 +3456,7 @@ abstract class RenderObjectElement extends BuildableElement {
} }
@override @override
void update(RenderObjectWidget newWidget) { void update(@checked RenderObjectWidget newWidget) {
super.update(newWidget); super.update(newWidget);
assert(widget == newWidget); assert(widget == newWidget);
assert(() { _debugUpdateRenderObjectOwner(); return true; }); assert(() { _debugUpdateRenderObjectOwner(); return true; });
......
...@@ -285,7 +285,7 @@ class FlutterDriver { ...@@ -285,7 +285,7 @@ class FlutterDriver {
if (_printCommunication) if (_printCommunication)
_log.info(message); _log.info(message);
if (_logCommunicationToFile) { if (_logCommunicationToFile) {
f.File file = fs.file(p.join(testOutputsDirectory, 'flutter_driver_commands_${_driverId}.log')); f.File file = fs.file(p.join(testOutputsDirectory, 'flutter_driver_commands_$_driverId.log'));
file.createSync(recursive: true); // no-op if file exists file.createSync(recursive: true); // no-op if file exists
file.writeAsStringSync('${new DateTime.now()} $message\n', mode: f.FileMode.APPEND, flush: true); file.writeAsStringSync('${new DateTime.now()} $message\n', mode: f.FileMode.APPEND, flush: true);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment