Unverified Commit 3ff51c74 authored by Greg Spencer's avatar Greg Spencer Committed by GitHub

Update android semantics test to match existing engine behavior. (#42368)

This updated the broken android_semantics_test to correspond to existing engine behavior.
parent 89d6c8d9
...@@ -369,9 +369,10 @@ void main() { ...@@ -369,9 +369,10 @@ void main() {
isEnabled: true, isEnabled: true,
isFocusable: true, isFocusable: true,
actions: <AndroidSemanticsAction>[ actions: <AndroidSemanticsAction>[
if (item == popupItems.first) AndroidSemanticsAction.clearAccessibilityFocus, // TODO(gspencergoog): This should really be clearAccessibilityFocus,
if (item != popupItems.first) AndroidSemanticsAction.accessibilityFocus, // but TalkBack doesn't find it for some reason.
AndroidSemanticsAction.click, // https://github.com/flutter/flutter/issues/40101
AndroidSemanticsAction.accessibilityFocus,
], ],
), ),
reason: "Popup $item doesn't have the right semantics"); reason: "Popup $item doesn't have the right semantics");
...@@ -393,10 +394,10 @@ void main() { ...@@ -393,10 +394,10 @@ void main() {
isEnabled: true, isEnabled: true,
isFocusable: true, isFocusable: true,
actions: <AndroidSemanticsAction>[ actions: <AndroidSemanticsAction>[
// TODO(gspencergoog): This should really be identical to the first time, // TODO(gspencergoog): This should really be clearAccessibilityFocus,
// but TalkBack doesn't find it the second time for some reason. // but TalkBack doesn't find it for some reason.
// https://github.com/flutter/flutter/issues/40101
AndroidSemanticsAction.accessibilityFocus, AndroidSemanticsAction.accessibilityFocus,
AndroidSemanticsAction.click,
], ],
), ),
reason: "Popup $item doesn't have the right semantics the second time"); reason: "Popup $item doesn't have the right semantics the second time");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment