Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3f926405
Unverified
Commit
3f926405
authored
May 16, 2019
by
chunhtai
Committed by
GitHub
May 16, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Visual selection is not adjusted when changing text selection with TalkBack (#32832)
parent
900875fd
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
5 deletions
+6
-5
semantics.dart
packages/flutter/lib/src/semantics/semantics.dart
+2
-1
text_field_test.dart
packages/flutter/test/material/text_field_test.dart
+3
-3
semantics_test.dart
packages/flutter/test/widgets/semantics_test.dart
+1
-1
No files found.
packages/flutter/lib/src/semantics/semantics.dart
View file @
3f926405
...
...
@@ -3032,7 +3032,8 @@ class SemanticsConfiguration {
set
onSetSelection
(
SetSelectionHandler
value
)
{
assert
(
value
!=
null
);
_addAction
(
SemanticsAction
.
setSelection
,
(
dynamic
args
)
{
final
Map
<
String
,
int
>
selection
=
args
;
assert
(
args
!=
null
&&
args
is
Map
);
final
Map
<
String
,
int
>
selection
=
args
.
cast
<
String
,
int
>();
assert
(
selection
!=
null
&&
selection
[
'base'
]
!=
null
&&
selection
[
'extent'
]
!=
null
);
value
(
TextSelection
(
baseOffset:
selection
[
'base'
],
...
...
packages/flutter/test/material/text_field_test.dart
View file @
3f926405
...
...
@@ -3939,7 +3939,7 @@ void main() {
),
ignoreTransform:
true
,
ignoreRect:
true
));
// move cursor back once
semanticsOwner
.
performAction
(
inputFieldId
,
SemanticsAction
.
setSelection
,
<
String
,
int
>{
semanticsOwner
.
performAction
(
inputFieldId
,
SemanticsAction
.
setSelection
,
<
dynamic
,
dynamic
>{
'base'
:
4
,
'extent'
:
4
,
});
...
...
@@ -3947,7 +3947,7 @@ void main() {
expect
(
controller
.
selection
,
const
TextSelection
.
collapsed
(
offset:
4
));
// move cursor to front
semanticsOwner
.
performAction
(
inputFieldId
,
SemanticsAction
.
setSelection
,
<
String
,
int
>{
semanticsOwner
.
performAction
(
inputFieldId
,
SemanticsAction
.
setSelection
,
<
dynamic
,
dynamic
>{
'base'
:
0
,
'extent'
:
0
,
});
...
...
@@ -3955,7 +3955,7 @@ void main() {
expect
(
controller
.
selection
,
const
TextSelection
.
collapsed
(
offset:
0
));
// select all
semanticsOwner
.
performAction
(
inputFieldId
,
SemanticsAction
.
setSelection
,
<
String
,
int
>{
semanticsOwner
.
performAction
(
inputFieldId
,
SemanticsAction
.
setSelection
,
<
dynamic
,
dynamic
>{
'base'
:
0
,
'extent'
:
5
,
});
...
...
packages/flutter/test/widgets/semantics_test.dart
View file @
3f926405
...
...
@@ -443,7 +443,7 @@ void main() {
semanticsOwner
.
performAction
(
expectedId
,
action
,
true
);
break
;
case
SemanticsAction
.
setSelection
:
semanticsOwner
.
performAction
(
expectedId
,
action
,
<
String
,
int
>{
semanticsOwner
.
performAction
(
expectedId
,
action
,
<
dynamic
,
dynamic
>{
'base'
:
4
,
'extent'
:
5
,
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment