Revert "Lazily initialise Xcode installation status (#10945)" (#10951)

This reverts commit bb8e2a7c.

Triggers a doctor failure on the Mac chromebots.

packages/flutter_tools/lib/src/ios/mac.dart

@@ -80,58 +80,54 @@ class IMobileDevice {
 }
 
 class Xcode {
-  bool get isInstalledAndMeetsVersionCheck => isInstalled && xcodeVersionSatisfactory;
+  Xcode() {
+    _eulaSigned = false;
 
-  String _xcodeSelectPath;
-  String get xcodeSelectPath {
-    if (_xcodeSelectPath == null) {
     try {
-        _xcodeSelectPath = runSync(<String>['/usr/bin/xcode-select', '--print-path'])?.trim();
-      } on ProcessException {
-        // Ignore: return null below.
-      }
-    }
-    return _xcodeSelectPath;
+      _xcodeSelectPath = runSync(<String>['xcode-select', '--print-path'])?.trim();
+      if (_xcodeSelectPath == null || _xcodeSelectPath.isEmpty) {
+        _isInstalled = false;
+        return;
       }
+      _isInstalled = true;
 
-  bool get isInstalled {
-    if (xcodeSelectPath == null || xcodeSelectPath.isEmpty)
-      return false;
-    if (!xcodeVersionRegex.hasMatch(xcodeVersionText))
-      return false;
-    return true;
-  }
+      _xcodeVersionText = runSync(<String>['xcodebuild', '-version']).replaceAll('\n', ', ');
 
-  bool _eulaSigned;
-  /// Has the EULA been signed?
-  bool get eulaSigned {
-    if (_eulaSigned == null) {
+      if (!xcodeVersionRegex.hasMatch(_xcodeVersionText)) {
+        _isInstalled = false;
+      } else {
         try {
           final ProcessResult result = processManager.runSync(<String>['/usr/bin/xcrun', 'clang']);
+
           if (result.stdout != null && result.stdout.contains('license'))
             _eulaSigned = false;
           else if (result.stderr != null && result.stderr.contains('license'))
             _eulaSigned = false;
           else
             _eulaSigned = true;
-      } on ProcessException {
+        } catch (error) {
           _eulaSigned = false;
         }
       }
-    return _eulaSigned;
+    } catch (error) {
+      _isInstalled = false;
+    }
   }
 
+  bool get isInstalledAndMeetsVersionCheck => isInstalled && xcodeVersionSatisfactory;
+
+  String _xcodeSelectPath;
+  String get xcodeSelectPath => _xcodeSelectPath;
+
+  bool _isInstalled;
+  bool get isInstalled => _isInstalled;
+
+  bool _eulaSigned;
+  /// Has the EULA been signed?
+  bool get eulaSigned => _eulaSigned;
+
   String _xcodeVersionText;
-  String get xcodeVersionText {
-    if (_xcodeVersionText != null) {
-      try {
-        _xcodeVersionText = runSync(<String>['/usr/bin/xcodebuild', '-version']).replaceAll('\n', ', ');
-      } on ProcessException {
-        // Ignore: return null below.
-      }
-    }
-    return _xcodeVersionText;
-  }
+  String get xcodeVersionText => _xcodeVersionText;
 
   int _xcodeMajorVersion;
   int get xcodeMajorVersion => _xcodeMajorVersion;