Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3cb539fd
Commit
3cb539fd
authored
May 03, 2018
by
Danny Tuppeny
Committed by
Danny Tuppeny
May 09, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Switch streams to Future<Lists>
parent
e456330a
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
19 deletions
+17
-19
emulators.dart
packages/flutter_tools/lib/src/commands/emulators.dart
+3
-3
emulator.dart
packages/flutter_tools/lib/src/emulator.dart
+10
-12
emulator_test.dart
packages/flutter_tools/test/emulator_test.dart
+4
-4
No files found.
packages/flutter_tools/lib/src/commands/emulators.dart
View file @
3cb539fd
...
...
@@ -47,7 +47,7 @@ class EmulatorsCommand extends FlutterCommand {
Future
<
Null
>
_launchEmulator
(
String
id
)
async
{
final
List
<
Emulator
>
emulators
=
await
emulatorManager
.
getEmulatorsMatching
(
id
)
.
toList
()
;
await
emulatorManager
.
getEmulatorsMatching
(
id
);
if
(
emulators
.
isEmpty
)
{
printStatus
(
"No emulator found that matches '
$id
'."
);
...
...
@@ -62,8 +62,8 @@ class EmulatorsCommand extends FlutterCommand {
Future
<
Null
>
_listEmulators
(
String
searchText
)
async
{
final
List
<
Emulator
>
emulators
=
searchText
==
null
?
await
emulatorManager
.
getAllAvailableEmulators
()
.
toList
()
:
await
emulatorManager
.
getEmulatorsMatching
(
searchText
)
.
toList
()
;
?
await
emulatorManager
.
getAllAvailableEmulators
()
:
await
emulatorManager
.
getEmulatorsMatching
(
searchText
);
if
(
emulators
.
isEmpty
)
{
printStatus
(
'No emulators available.
\n\n
'
...
...
packages/flutter_tools/lib/src/emulator.dart
View file @
3cb539fd
...
...
@@ -24,8 +24,8 @@ class EmulatorManager {
final
List
<
EmulatorDiscovery
>
_emulatorDiscoverers
=
<
EmulatorDiscovery
>[];
Stream
<
Emulator
>
getEmulatorsMatching
(
String
searchText
)
async
*
{
final
List
<
Emulator
>
emulators
=
await
getAllAvailableEmulators
()
.
toList
()
;
Future
<
List
<
Emulator
>>
getEmulatorsMatching
(
String
searchText
)
async
{
final
List
<
Emulator
>
emulators
=
await
getAllAvailableEmulators
();
searchText
=
searchText
.
toLowerCase
();
bool
exactlyMatchesEmulatorId
(
Emulator
emulator
)
=>
emulator
.
id
?.
toLowerCase
()
==
searchText
||
...
...
@@ -37,13 +37,11 @@ class EmulatorManager {
final
Emulator
exactMatch
=
emulators
.
firstWhere
(
exactlyMatchesEmulatorId
,
orElse:
()
=>
null
);
if
(
exactMatch
!=
null
)
{
yield
exactMatch
;
return
;
return
<
Emulator
>[
exactMatch
];
}
// Match on a id or name starting with [emulatorId].
for
(
Emulator
emulator
in
emulators
.
where
(
startsWithEmulatorId
))
yield
emulator
;
return
emulators
.
where
(
startsWithEmulatorId
).
toList
();
}
Iterable
<
EmulatorDiscovery
>
get
_platformDiscoverers
{
...
...
@@ -51,12 +49,12 @@ class EmulatorManager {
}
/// Return the list of all available emulators.
Stream
<
Emulator
>
getAllAvailableEmulators
()
async
*
{
f
or
(
EmulatorDiscovery
discoverer
in
_platformDiscoverers
)
{
for
(
Emulator
emulator
in
await
discoverer
.
emulators
)
{
yield
emulator
;
}
}
Future
<
List
<
Emulator
>>
getAllAvailableEmulators
()
async
{
f
inal
List
<
Emulator
>
emulators
=
<
Emulator
>[];
Future
.
forEach
(
_platformDiscoverers
,
(
EmulatorDiscovery
discoverer
)
async
{
emulators
.
addAll
(
await
discoverer
.
emulators
)
;
});
return
emulators
;
}
/// Whether we're capable of listing any emulators given the current environment configuration.
...
...
packages/flutter_tools/test/emulator_test.dart
View file @
3cb539fd
...
...
@@ -14,7 +14,7 @@ void main() {
testUsingContext
(
'getEmulators'
,
()
async
{
// Test that EmulatorManager.getEmulators() doesn't throw.
final
EmulatorManager
emulatorManager
=
new
EmulatorManager
();
final
List
<
Emulator
>
emulators
=
await
emulatorManager
.
getAllAvailableEmulators
()
.
toList
()
;
final
List
<
Emulator
>
emulators
=
await
emulatorManager
.
getAllAvailableEmulators
();
expect
(
emulators
,
isList
);
});
...
...
@@ -26,7 +26,7 @@ void main() {
final
EmulatorManager
emulatorManager
=
new
TestEmulatorManager
(
emulators
);
Future
<
Null
>
expectEmulator
(
String
id
,
List
<
Emulator
>
expected
)
async
{
expect
(
await
emulatorManager
.
getEmulatorsMatching
(
id
)
.
toList
()
,
expected
);
expect
(
await
emulatorManager
.
getEmulatorsMatching
(
id
),
expected
);
}
expectEmulator
(
'Nexus_5'
,
<
Emulator
>[
emulator1
]);
expectEmulator
(
'Nexus_5X'
,
<
Emulator
>[
emulator2
]);
...
...
@@ -44,8 +44,8 @@ class TestEmulatorManager extends EmulatorManager {
TestEmulatorManager
(
this
.
allEmulators
);
@override
Stream
<
Emulator
>
getAllAvailableEmulators
()
{
return
new
Stream
<
Emulator
>.
fromIterabl
e
(
allEmulators
);
Future
<
List
<
Emulator
>
>
getAllAvailableEmulators
()
{
return
new
Future
<
List
<
Emulator
>>.
valu
e
(
allEmulators
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment