Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3c8c630f
Unverified
Commit
3c8c630f
authored
Apr 18, 2019
by
Jonah Williams
Committed by
GitHub
Apr 18, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow disabling all fingerprint caches via environment variable (#31171)
parent
20d8ea78
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
57 additions
and
0 deletions
+57
-0
fingerprint.dart
packages/flutter_tools/lib/src/base/fingerprint.dart
+11
-0
fingerprint_test.dart
packages/flutter_tools/test/base/fingerprint_test.dart
+46
-0
No files found.
packages/flutter_tools/lib/src/base/fingerprint.dart
View file @
3c8c630f
...
...
@@ -12,9 +12,17 @@ import '../convert.dart' show json;
import
'../globals.dart'
;
import
'../version.dart'
;
import
'file_system.dart'
;
import
'platform.dart'
;
typedef
FingerprintPathFilter
=
bool
Function
(
String
path
);
/// Whether to completely disable build caching.
///
/// This is done by always returning false from fingerprinter invocations. This
/// is safe to do generally, because fingerprinting is only a performance
/// improvement.
bool
get
_disableBuildCache
=>
platform
.
environment
[
'DISABLE_FLUTTER_BUILD_CACHE'
]?.
toLowerCase
()
==
'true'
;
/// A tool that can be used to compute, compare, and write [Fingerprint]s for a
/// set of input files and associated build settings.
///
...
...
@@ -50,6 +58,9 @@ class Fingerprinter {
}
Future
<
bool
>
doesFingerprintMatch
()
async
{
if
(
_disableBuildCache
)
{
return
false
;
}
try
{
final
File
fingerprintFile
=
fs
.
file
(
fingerprintPath
);
if
(!
fingerprintFile
.
existsSync
())
...
...
packages/flutter_tools/test/base/fingerprint_test.dart
View file @
3c8c630f
...
...
@@ -5,6 +5,7 @@
import
'dart:convert'
show
json
;
import
'package:file/memory.dart'
;
import
'package:flutter_tools/src/base/platform.dart'
;
import
'package:flutter_tools/src/build_info.dart'
;
import
'package:flutter_tools/src/base/file_system.dart'
;
import
'package:flutter_tools/src/base/fingerprint.dart'
;
...
...
@@ -192,6 +193,46 @@ void main() {
expect
(
await
fingerprinter
.
doesFingerprintMatch
(),
isTrue
);
},
overrides:
contextOverrides
);
final
Platform
mockPlatformDisabledCache
=
MockPlatform
();
mockPlatformDisabledCache
.
environment
[
'DISABLE_FLUTTER_BUILD_CACHE'
]
=
'true'
;
testUsingContext
(
'can be disabled with an environment variable'
,
()
async
{
await
fs
.
file
(
'a.dart'
).
create
();
await
fs
.
file
(
'b.dart'
).
create
();
final
Fingerprinter
fingerprinter
=
Fingerprinter
(
fingerprintPath:
'out.fingerprint'
,
paths:
<
String
>[
'a.dart'
,
'b.dart'
],
properties:
<
String
,
String
>{
'bar'
:
'baz'
,
'wobble'
:
'womble'
,
},
);
await
fingerprinter
.
writeFingerprint
();
expect
(
await
fingerprinter
.
doesFingerprintMatch
(),
isFalse
);
},
overrides:
<
Type
,
Generator
>{
Platform:
()
=>
mockPlatformDisabledCache
,
}..
addAll
(
contextOverrides
));
final
Platform
mockPlatformEnabledCache
=
MockPlatform
();
mockPlatformEnabledCache
.
environment
[
'DISABLE_FLUTTER_BUILD_CACHE'
]
=
'false'
;
testUsingContext
(
'can be not-disabled with an environment variable'
,
()
async
{
await
fs
.
file
(
'a.dart'
).
create
();
await
fs
.
file
(
'b.dart'
).
create
();
final
Fingerprinter
fingerprinter
=
Fingerprinter
(
fingerprintPath:
'out.fingerprint'
,
paths:
<
String
>[
'a.dart'
,
'b.dart'
],
properties:
<
String
,
String
>{
'bar'
:
'baz'
,
'wobble'
:
'womble'
,
},
);
await
fingerprinter
.
writeFingerprint
();
expect
(
await
fingerprinter
.
doesFingerprintMatch
(),
isTrue
);
},
overrides:
<
Type
,
Generator
>{
Platform:
()
=>
mockPlatformEnabledCache
,
}..
addAll
(
contextOverrides
));
testUsingContext
(
'fails to write fingerprint if inputs are missing'
,
()
async
{
final
Fingerprinter
fingerprinter
=
Fingerprinter
(
fingerprintPath:
'out.fingerprint'
,
...
...
@@ -471,3 +512,8 @@ void main() {
},
overrides:
contextOverrides
);
});
}
class
MockPlatform
extends
Mock
implements
Platform
{
@override
Map
<
String
,
String
>
environment
=
<
String
,
String
>{};
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment