Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3b68ae84
Unverified
Commit
3b68ae84
authored
Oct 11, 2018
by
Janice Collins
Committed by
GitHub
Oct 11, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove extraneous flags from dartdoc invocation (#22972)
parent
0e76cb4c
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
24 deletions
+5
-24
dartdoc.dart
dev/tools/dartdoc.dart
+5
-24
No files found.
dev/tools/dartdoc.dart
View file @
3b68ae84
...
@@ -134,17 +134,9 @@ Future<void> main(List<String> arguments) async {
...
@@ -134,17 +134,9 @@ Future<void> main(List<String> arguments) async {
'package:Flutter/temp_doc.dart,package:http/browser_client.dart,package:intl/intl_browser.dart,package:matcher/mirror_matchers.dart,package:quiver/mirrors.dart,package:quiver/io.dart,package:vm_service_client/vm_service_client.dart,package:web_socket_channel/html.dart'
,
'package:Flutter/temp_doc.dart,package:http/browser_client.dart,package:intl/intl_browser.dart,package:matcher/mirror_matchers.dart,package:quiver/mirrors.dart,package:quiver/io.dart,package:vm_service_client/vm_service_client.dart,package:web_socket_channel/html.dart'
,
'--favicon=favicon.ico'
,
'--favicon=favicon.ico'
,
'--package-order'
,
'flutter,Dart,flutter_test,flutter_driver'
,
'--package-order'
,
'flutter,Dart,flutter_test,flutter_driver'
,
'--show-warnings'
,
'--auto-include-dependencies'
,
'--auto-include-dependencies'
,
]);
]);
// Explicitly list all the packages in //flutter/packages/* that are
// not listed 'nodoc' in their pubspec.yaml.
for
(
String
libraryRef
in
libraryRefs
(
diskPath:
true
))
{
dartdocArgs
.
add
(
'--include-external'
);
dartdocArgs
.
add
(
libraryRef
);
}
String
quote
(
String
arg
)
=>
arg
.
contains
(
' '
)
?
"'
$arg
'"
:
arg
;
String
quote
(
String
arg
)
=>
arg
.
contains
(
' '
)
?
"'
$arg
'"
:
arg
;
print
(
'Executing: (cd dev/docs ;
$pubExecutable
${dartdocArgs.map<String>(quote).join(' ')}
)'
);
print
(
'Executing: (cd dev/docs ;
$pubExecutable
${dartdocArgs.map<String>(quote).join(' ')}
)'
);
...
@@ -162,7 +154,6 @@ Future<void> main(List<String> arguments) async {
...
@@ -162,7 +154,6 @@ Future<void> main(List<String> arguments) async {
);
);
printStream
(
process
.
stderr
,
prefix:
args
[
'json'
]
?
''
:
'dartdoc:stderr: '
,
printStream
(
process
.
stderr
,
prefix:
args
[
'json'
]
?
''
:
'dartdoc:stderr: '
,
filter:
args
[
'verbose'
]
?
const
<
Pattern
>[]
:
<
Pattern
>[
filter:
args
[
'verbose'
]
?
const
<
Pattern
>[]
:
<
Pattern
>[
RegExp
(
r'^[ ]+warning: generic type handled as HTML:'
),
// https://github.com/dart-lang/dartdoc/issues/1475
RegExp
(
r'^ warning: .+: \(.+/\.pub-cache/hosted/pub.dartlang.org/.+\)'
),
// packages outside our control
RegExp
(
r'^ warning: .+: \(.+/\.pub-cache/hosted/pub.dartlang.org/.+\)'
),
// packages outside our control
],
],
);
);
...
@@ -321,29 +312,19 @@ List<FileSystemEntity> findPackages() {
...
@@ -321,29 +312,19 @@ List<FileSystemEntity> findPackages() {
}
}
/// Returns import or on-disk paths for all libraries in the Flutter SDK.
/// Returns import or on-disk paths for all libraries in the Flutter SDK.
///
Iterable
<
String
>
libraryRefs
()
sync
*
{
/// diskPath toggles between import paths vs. disk paths.
Iterable
<
String
>
libraryRefs
({
bool
diskPath
=
false
})
sync
*
{
for
(
Directory
dir
in
findPackages
())
{
for
(
Directory
dir
in
findPackages
())
{
final
String
dirName
=
path
.
basename
(
dir
.
path
);
final
String
dirName
=
path
.
basename
(
dir
.
path
);
for
(
FileSystemEntity
file
in
Directory
(
'
${dir.path}
/lib'
).
listSync
())
{
for
(
FileSystemEntity
file
in
Directory
(
'
${dir.path}
/lib'
).
listSync
())
{
if
(
file
is
File
&&
file
.
path
.
endsWith
(
'.dart'
))
{
if
(
file
is
File
&&
file
.
path
.
endsWith
(
'.dart'
))
{
if
(
diskPath
)
yield
'
$dirName
/lib/
${path.basename(file.path)}
'
;
else
yield
'
$dirName
/
${path.basename(file.path)}
'
;
yield
'
$dirName
/
${path.basename(file.path)}
'
;
}
}
}
}
}
}
// Add a fake package for platform integration APIs.
// Add a fake package for platform integration APIs.
if
(
diskPath
)
{
yield
'platform_integration/lib/android.dart'
;
yield
'platform_integration/lib/ios.dart'
;
}
else
{
yield
'platform_integration/android.dart'
;
yield
'platform_integration/android.dart'
;
yield
'platform_integration/ios.dart'
;
yield
'platform_integration/ios.dart'
;
}
}
}
void
printStream
(
Stream
<
List
<
int
>>
stream
,
{
String
prefix
=
''
,
List
<
Pattern
>
filter
=
const
<
Pattern
>[]
})
{
void
printStream
(
Stream
<
List
<
int
>>
stream
,
{
String
prefix
=
''
,
List
<
Pattern
>
filter
=
const
<
Pattern
>[]
})
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment