Unverified Commit 3b42341a authored by Zachary Anderson's avatar Zachary Anderson Committed by GitHub

[flutter_tool,fuchsia] Prefetch tiles when starting an app (#34276)

parent f31fc1bd
...@@ -252,6 +252,18 @@ class FuchsiaDevice extends Device { ...@@ -252,6 +252,18 @@ class FuchsiaDevice extends Device {
FuchsiaPackageServer fuchsiaPackageServer; FuchsiaPackageServer fuchsiaPackageServer;
bool serverRegistered = false; bool serverRegistered = false;
try { try {
// Ask amber to pre-fetch some things we'll need before setting up our own
// package server. This is to avoid relying on amber correctly using
// multiple package servers, support for which is in flux.
if (!await fuchsiaDeviceTools.amberCtl.getUp(this, 'tiles')) {
printError('Failed to get amber to prefetch tiles');
return LaunchResult.failed();
}
if (!await fuchsiaDeviceTools.amberCtl.getUp(this, 'tiles_ctl')) {
printError('Failed to get amber to prefetch tiles_ctl');
return LaunchResult.failed();
}
// Start up a package server. // Start up a package server.
fuchsiaPackageServer = FuchsiaPackageServer(packageRepo.path, host, port); fuchsiaPackageServer = FuchsiaPackageServer(packageRepo.path, host, port);
if (!await fuchsiaPackageServer.start()) { if (!await fuchsiaPackageServer.start()) {
...@@ -297,7 +309,7 @@ class FuchsiaDevice extends Device { ...@@ -297,7 +309,7 @@ class FuchsiaDevice extends Device {
await fuchsiaDeviceTools.amberCtl.rmSrc(this, fuchsiaPackageServer); await fuchsiaDeviceTools.amberCtl.rmSrc(this, fuchsiaPackageServer);
} }
// Shutdown the package server and delete the package repo; // Shutdown the package server and delete the package repo;
fuchsiaPackageServer.stop(); fuchsiaPackageServer?.stop();
packageRepo.deleteSync(recursive: true); packageRepo.deleteSync(recursive: true);
status.cancel(); status.cancel();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment