Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3a9e7e3b
Unverified
Commit
3a9e7e3b
authored
Aug 18, 2021
by
Kate Lovett
Committed by
GitHub
Aug 18, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
New PR (#88365)
parent
831d82c8
Changes
5
Expand all
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
589 additions
and
0 deletions
+589
-0
fix_data.yaml
packages/flutter/lib/fix_data.yaml
+462
-0
app_bar.dart
packages/flutter/lib/src/material/app_bar.dart
+8
-0
app_bar_theme.dart
packages/flutter/lib/src/material/app_bar_theme.dart
+12
-0
material.dart
packages/flutter/test_fixes/material.dart
+53
-0
material.dart.expect
packages/flutter/test_fixes/material.dart.expect
+54
-0
No files found.
packages/flutter/lib/fix_data.yaml
View file @
3a9e7e3b
This diff is collapsed.
Click to expand it.
packages/flutter/lib/src/material/app_bar.dart
View file @
3a9e7e3b
...
...
@@ -1572,6 +1572,10 @@ class SliverAppBar extends StatefulWidget {
this
.
shape
,
this
.
toolbarHeight
=
kToolbarHeight
,
this
.
leadingWidth
,
@Deprecated
(
'This property is obsolete and is false by default. '
'This feature was deprecated after v2.4.0-0.0.pre.'
,
)
this
.
backwardsCompatibility
,
this
.
toolbarTextStyle
,
this
.
titleTextStyle
,
...
...
@@ -1832,6 +1836,10 @@ class SliverAppBar extends StatefulWidget {
/// {@macro flutter.material.appbar.backwardsCompatibility}
///
/// This property is used to configure an [AppBar].
@Deprecated
(
'This property is obsolete and is false by default. '
'This feature was deprecated after v2.4.0-0.0.pre.'
,
)
final
bool
?
backwardsCompatibility
;
/// {@macro flutter.material.appbar.toolbarTextStyle}
...
...
packages/flutter/lib/src/material/app_bar_theme.dart
View file @
3a9e7e3b
...
...
@@ -228,6 +228,10 @@ class AppBarTheme with Diagnosticable {
/// new values.
AppBarTheme
copyWith
({
IconThemeData
?
actionsIconTheme
,
@Deprecated
(
'This property is no longer used, please use systemOverlayStyle instead. '
'This feature was deprecated after v2.4.0-0.0.pre.'
,
)
Brightness
?
brightness
,
Color
?
color
,
Color
?
backgroundColor
,
...
...
@@ -236,6 +240,10 @@ class AppBarTheme with Diagnosticable {
Color
?
shadowColor
,
ShapeBorder
?
shape
,
IconThemeData
?
iconTheme
,
@Deprecated
(
'This property is no longer used, please use toolbarTextStyle and titleTextStyle instead. '
'This feature was deprecated after v2.4.0-0.0.pre.'
,
)
TextTheme
?
textTheme
,
bool
?
centerTitle
,
double
?
titleSpacing
,
...
...
@@ -243,6 +251,10 @@ class AppBarTheme with Diagnosticable {
TextStyle
?
toolbarTextStyle
,
TextStyle
?
titleTextStyle
,
SystemUiOverlayStyle
?
systemOverlayStyle
,
@Deprecated
(
'This property is obsolete and is false by default. '
'This feature was deprecated after v2.4.0-0.0.pre.'
,
)
bool
?
backwardsCompatibility
,
})
{
assert
(
...
...
packages/flutter/test_fixes/material.dart
View file @
3a9e7e3b
...
...
@@ -398,4 +398,57 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/87839
final
OverscrollIndicatorNotification
notification
=
OverscrollIndicatorNotification
(
leading:
true
);
notification
.
disallowGlow
();
// Changes made in https://github.com/flutter/flutter/pull/86198
AppBar
appBar
=
AppBar
();
appBar
=
AppBar
(
brightness:
Brightness
.
light
);
appBar
=
AppBar
(
brightness:
Brightness
.
dark
);
appBar
.
brightness
;
SliverAppBar
sliverAppBar
=
SliverAppBar
();
sliverAppBar
=
SliverAppBar
(
brightness:
Brightness
.
light
);
sliverAppBar
=
SliverAppBar
(
brightness:
Brightness
.
dark
);
sliverAppBar
.
brightness
;
AppBarTheme
appBarTheme
=
AppBarTheme
();
appBarTheme
=
AppBarTheme
(
brightness:
Brightness
.
light
);
appBarTheme
=
AppBarTheme
(
brightness:
Brightness
.
dark
);
appBarTheme
=
appBarTheme
.
copyWith
(
brightness:
Brightness
.
light
);
appBarTheme
=
appBarTheme
.
copyWith
(
brightness:
Brightness
.
dark
);
appBarTheme
.
brightness
;
TextTheme
myTextTheme
=
TextTheme
();
AppBar
appBar
=
AppBar
();
appBar
=
AppBar
(
textTheme:
myTextTheme
);
appBar
=
AppBar
(
textTheme:
myTextTheme
);
SliverAppBar
sliverAppBar
=
SliverAppBar
();
sliverAppBar
=
SliverAppBar
(
textTheme:
myTextTheme
);
sliverAppBar
=
SliverAppBar
(
textTheme:
myTextTheme
);
AppBarTheme
appBarTheme
=
AppBarTheme
();
appBarTheme
=
AppBarTheme
(
textTheme:
myTextTheme
);
appBarTheme
=
AppBarTheme
(
textTheme:
myTextTheme
);
appBarTheme
=
appBarTheme
.
copyWith
(
textTheme:
myTextTheme
);
appBarTheme
=
appBarTheme
.
copyWith
(
textTheme:
myTextTheme
);
AppBar
appBar
=
AppBar
();
appBar
=
AppBar
(
backwardsCompatibility:
true
);
appBar
=
AppBar
(
backwardsCompatibility:
false
));
appBar
.
backwardsCompatibility
;
// Removing field reference not supported.
SliverAppBar
sliverAppBar
=
SliverAppBar
();
sliverAppBar
=
SliverAppBar
(
backwardsCompatibility:
true
);
sliverAppBar
=
SliverAppBar
(
backwardsCompatibility:
false
);
sliverAppBar
.
backwardsCompatibility
;
// Removing field reference not supported.
AppBarTheme
appBarTheme
=
AppBarTheme
();
appBarTheme
=
AppBarTheme
(
backwardsCompatibility:
true
);
appBarTheme
=
AppBarTheme
(
backwardsCompatibility:
false
);
appBarTheme
=
appBarTheme
.
copyWith
(
backwardsCompatibility:
true
);
appBarTheme
=
appBarTheme
.
copyWith
(
backwardsCompatibility:
false
);
appBarTheme
.
backwardsCompatibility
;
// Removing field reference not supported.
AppBarTheme
appBarTheme
=
AppBarTheme
();
appBarTheme
.
color
;
}
packages/flutter/test_fixes/material.dart.expect
View file @
3a9e7e3b
...
...
@@ -3,6 +3,7 @@
// found in the LICENSE file.
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
void main() {
// Generic reference variables.
...
...
@@ -370,4 +371,57 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/87839
final OverscrollIndicatorNotification notification = OverscrollIndicatorNotification(leading: true);
notification.disallowIndicator();
// Changes made in https://github.com/flutter/flutter/pull/86198
AppBar appBar = AppBar();
appBar = AppBar(systemOverlayStyle: SystemUiOverlayStyle.dark);
appBar = AppBar(systemOverlayStyle: SystemUiOverlayStyle.light);
appBar.systemOverlayStyle;
SliverAppBar sliverAppBar = SliverAppBar();
sliverAppBar = SliverAppBar(systemOverlayStyle: SystemUiOverlayStyle.dark);
sliverAppBar = SliverAppBar(systemOverlayStyle: SystemUiOverlayStyle.light);
sliverAppBar.systemOverlayStyle;
AppBarTheme appBarTheme = AppBarTheme();
appBarTheme = AppBarTheme(systemOverlayStyle: SystemUiOverlayStyle.dark);
appBarTheme = AppBarTheme(systemOverlayStyle: SystemUiOverlayStyle.light);
appBarTheme = appBarTheme.copyWith(systemOverlayStyle: SystemUiOverlayStyle.dark);
appBarTheme = appBarTheme.copyWith(systemOverlayStyle: SystemUiOverlayStyle.light);
appBarTheme.systemOverlayStyle;
TextTheme myTextTheme = TextTheme();
AppBar appBar = AppBar();
appBar = AppBar(toolbarTextStyle: myTextTheme.bodyText2, titleTextStyle: myTextTheme.headline6);
appBar = AppBar(toolbarTextStyle: myTextTheme.bodyText2, titleTextStyle: myTextTheme.headline6);
SliverAppBar sliverAppBar = SliverAppBar();
sliverAppBar = SliverAppBar(toolbarTextStyle: myTextTheme.bodyText2, titleTextStyle: myTextTheme.headline6);
sliverAppBar = SliverAppBar(toolbarTextStyle: myTextTheme.bodyText2, titleTextStyle: myTextTheme.headline6);
AppBarTheme appBarTheme = AppBarTheme();
appBarTheme = AppBarTheme(toolbarTextStyle: myTextTheme.bodyText2, titleTextStyle: myTextTheme.headline6);
appBarTheme = AppBarTheme(toolbarTextStyle: myTextTheme.bodyText2, titleTextStyle: myTextTheme.headline6);
appBarTheme = appBarTheme.copyWith(toolbarTextStyle: myTextTheme.bodyText2, titleTextStyle: myTextTheme.headline6);
appBarTheme = appBarTheme.copyWith(toolbarTextStyle: myTextTheme.bodyText2, titleTextStyle: myTextTheme.headline6);
AppBar appBar = AppBar();
appBar = AppBar();
appBar = AppBar());
appBar.backwardsCompatibility; // Removing field reference not supported.
SliverAppBar sliverAppBar = SliverAppBar();
sliverAppBar = SliverAppBar();
sliverAppBar = SliverAppBar();
sliverAppBar.backwardsCompatibility; // Removing field reference not supported.
AppBarTheme appBarTheme = AppBarTheme();
appBarTheme = AppBarTheme();
appBarTheme = AppBarTheme();
appBarTheme = appBarTheme.copyWith();
appBarTheme = appBarTheme.copyWith();
appBarTheme.backwardsCompatibility; // Removing field reference not supported.
AppBarTheme appBarTheme = AppBarTheme();
appBarTheme.backgroundColor;
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment