Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
38840b41
Unverified
Commit
38840b41
authored
May 11, 2021
by
Abhishek Ghaskata
Committed by
GitHub
May 11, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ExpansionPanelList elevation as double (#81813)
parent
212e3f4e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
10 deletions
+4
-10
expansion_panel.dart
packages/flutter/lib/src/material/expansion_panel.dart
+2
-8
expansion_panel_test.dart
packages/flutter/test/material/expansion_panel_test.dart
+2
-2
No files found.
packages/flutter/lib/src/material/expansion_panel.dart
View file @
38840b41
...
@@ -380,14 +380,8 @@ class ExpansionPanelList extends StatefulWidget {
...
@@ -380,14 +380,8 @@ class ExpansionPanelList extends StatefulWidget {
/// Defines elevation for the [ExpansionPanel] while it's expanded.
/// Defines elevation for the [ExpansionPanel] while it's expanded.
///
///
/// This uses [kElevationToShadow] to simulate shadows, it does not use
/// [Material]'s arbitrary elevation feature.
///
/// The following values can be used to define the elevation: 0, 1, 2, 3, 4, 6,
/// 8, 9, 12, 16, 24.
///
/// By default, the value of elevation is 2.
/// By default, the value of elevation is 2.
final
int
elevation
;
final
double
elevation
;
@override
@override
State
<
StatefulWidget
>
createState
()
=>
_ExpansionPanelListState
();
State
<
StatefulWidget
>
createState
()
=>
_ExpansionPanelListState
();
...
@@ -560,7 +554,7 @@ class _ExpansionPanelListState extends State<ExpansionPanelList> {
...
@@ -560,7 +554,7 @@ class _ExpansionPanelListState extends State<ExpansionPanelList> {
return
MergeableMaterial
(
return
MergeableMaterial
(
hasDividers:
true
,
hasDividers:
true
,
dividerColor:
widget
.
dividerColor
,
dividerColor:
widget
.
dividerColor
,
elevation:
widget
.
elevation
.
toDouble
()
,
elevation:
widget
.
elevation
,
children:
items
,
children:
items
,
);
);
}
}
...
...
packages/flutter/test/material/expansion_panel_test.dart
View file @
38840b41
...
@@ -20,7 +20,7 @@ class SimpleExpansionPanelListTestWidget extends StatefulWidget {
...
@@ -20,7 +20,7 @@ class SimpleExpansionPanelListTestWidget extends StatefulWidget {
final
Key
?
secondPanelKey
;
final
Key
?
secondPanelKey
;
final
bool
canTapOnHeader
;
final
bool
canTapOnHeader
;
final
Color
?
dividerColor
;
final
Color
?
dividerColor
;
final
int
elevation
;
final
double
elevation
;
/// If null, the default [ExpansionPanelList]'s expanded header padding value is applied via [defaultExpandedHeaderPadding]
/// If null, the default [ExpansionPanelList]'s expanded header padding value is applied via [defaultExpandedHeaderPadding]
final
EdgeInsets
?
expandedHeaderPadding
;
final
EdgeInsets
?
expandedHeaderPadding
;
...
@@ -1397,7 +1397,7 @@ void main() {
...
@@ -1397,7 +1397,7 @@ void main() {
});
});
testWidgets
(
'elevation is propagated properly to MergeableMaterial'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'elevation is propagated properly to MergeableMaterial'
,
(
WidgetTester
tester
)
async
{
const
int
_elevation
=
8
;
const
double
_elevation
=
8
;
// Test for ExpansionPanelList.
// Test for ExpansionPanelList.
await
tester
.
pumpWidget
(
const
MaterialApp
(
await
tester
.
pumpWidget
(
const
MaterialApp
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment