Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
35000147
Unverified
Commit
35000147
authored
Jan 25, 2021
by
Jenn Magder
Committed by
GitHub
Jan 25, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Re-add tool test general per-test timeout (#74531)
parent
92427f26
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
2 deletions
+5
-2
test.dart
dev/bots/test.dart
+2
-0
resident_runner_test.dart
...lutter_tools/test/general.shard/resident_runner_test.dart
+1
-1
context.dart
packages/flutter_tools/test/src/context.dart
+2
-1
No files found.
dev/bots/test.dart
View file @
35000147
...
@@ -301,6 +301,8 @@ Future<void> _runToolTests() async {
...
@@ -301,6 +301,8 @@ Future<void> _runToolTests() async {
forceSingleCore:
subshard
!=
'general'
,
forceSingleCore:
subshard
!=
'general'
,
testPaths:
<
String
>[
path
.
join
(
kTest
,
'
$subshard$kDotShard
'
,
suffix
)],
testPaths:
<
String
>[
path
.
join
(
kTest
,
'
$subshard$kDotShard
'
,
suffix
)],
enableFlutterToolAsserts:
subshard
!=
'general'
,
enableFlutterToolAsserts:
subshard
!=
'general'
,
// Detect unit test time regressions (poor time delay handling, etc).
perTestTimeout:
(
subshard
==
'general'
)
?
const
Duration
(
seconds:
2
)
:
null
,
);
);
},
},
);
);
...
...
packages/flutter_tools/test/general.shard/resident_runner_test.dart
View file @
35000147
...
@@ -587,7 +587,7 @@ void main() {
...
@@ -587,7 +587,7 @@ void main() {
expect
(
result
.
code
,
1
);
expect
(
result
.
code
,
1
);
expect
(
result
.
message
,
contains
(
'Device initialization has not completed.'
));
expect
(
result
.
message
,
contains
(
'Device initialization has not completed.'
));
expect
(
fakeVmServiceHost
.
hasRemainingExpectations
,
false
);
expect
(
fakeVmServiceHost
.
hasRemainingExpectations
,
false
);
})
);
})
,
timeout:
const
Timeout
(
Duration
(
seconds:
15
)));
// https://github.com/flutter/flutter/issues/74539
testUsingContext
(
'ResidentRunner can handle an reload-barred exception from hot reload'
,
()
=>
testbed
.
run
(()
async
{
testUsingContext
(
'ResidentRunner can handle an reload-barred exception from hot reload'
,
()
=>
testbed
.
run
(()
async
{
fakeVmServiceHost
=
FakeVmServiceHost
(
requests:
<
VmServiceExpectation
>[
fakeVmServiceHost
=
FakeVmServiceHost
(
requests:
<
VmServiceExpectation
>[
...
...
packages/flutter_tools/test/src/context.dart
View file @
35000147
...
@@ -58,6 +58,7 @@ void testUsingContext(
...
@@ -58,6 +58,7 @@ void testUsingContext(
Map
<
Type
,
Generator
>
overrides
=
const
<
Type
,
Generator
>{},
Map
<
Type
,
Generator
>
overrides
=
const
<
Type
,
Generator
>{},
bool
initializeFlutterRoot
=
true
,
bool
initializeFlutterRoot
=
true
,
String
testOn
,
String
testOn
,
Timeout
timeout
,
bool
skip
,
// should default to `false`, but https://github.com/dart-lang/test/issues/545 doesn't allow this
bool
skip
,
// should default to `false`, but https://github.com/dart-lang/test/issues/545 doesn't allow this
})
{
})
{
if
(
overrides
[
FileSystem
]
!=
null
&&
overrides
[
ProcessManager
]
==
null
)
{
if
(
overrides
[
FileSystem
]
!=
null
&&
overrides
[
ProcessManager
]
==
null
)
{
...
@@ -174,7 +175,7 @@ void testUsingContext(
...
@@ -174,7 +175,7 @@ void testUsingContext(
// BotDetector implementation in the overrides.
// BotDetector implementation in the overrides.
BotDetector:
overrides
[
BotDetector
]
??
()
=>
const
AlwaysTrueBotDetector
(),
BotDetector:
overrides
[
BotDetector
]
??
()
=>
const
AlwaysTrueBotDetector
(),
});
});
},
testOn:
testOn
,
skip:
skip
);
},
testOn:
testOn
,
skip:
skip
,
timeout:
timeout
);
}
}
void
_printBufferedErrors
(
AppContext
testContext
)
{
void
_printBufferedErrors
(
AppContext
testContext
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment