Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
349d694f
Unverified
Commit
349d694f
authored
Oct 30, 2019
by
Jonah Williams
Committed by
GitHub
Oct 30, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Added a null check for ranges in the sourceReport map. (#43667)" (#43827)
This reverts commit
0dc5ea4a
.
parent
8f704840
Changes
2
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
440 deletions
+10
-440
coverage_collector.dart
packages/flutter_tools/lib/src/test/coverage_collector.dart
+5
-22
coverage_collector_test.dart
...ter_tools/test/general.shard/coverage_collector_test.dart
+5
-418
No files found.
packages/flutter_tools/lib/src/test/coverage_collector.dart
View file @
349d694f
...
@@ -245,37 +245,20 @@ void _buildCoverageMap(
...
@@ -245,37 +245,20 @@ void _buildCoverageMap(
final
Map
<
String
,
Map
<
int
,
int
>>
hitMaps
=
<
String
,
Map
<
int
,
int
>>{};
final
Map
<
String
,
Map
<
int
,
int
>>
hitMaps
=
<
String
,
Map
<
int
,
int
>>{};
for
(
String
scriptId
in
scripts
.
keys
)
{
for
(
String
scriptId
in
scripts
.
keys
)
{
final
Map
<
String
,
dynamic
>
sourceReport
=
sourceReports
[
scriptId
];
final
Map
<
String
,
dynamic
>
sourceReport
=
sourceReports
[
scriptId
];
final
Map
<
String
,
dynamic
>
scripts
=
sourceReport
[
'scripts'
];
for
(
Map
<
String
,
dynamic
>
range
in
sourceReport
[
'ranges'
])
{
final
List
<
Map
<
String
,
Object
>>
ranges
=
sourceReport
[
'ranges'
];
// Ranges may sometimes be null for a report.
if
(
ranges
==
null
||
scripts
==
null
)
{
continue
;
}
for
(
Map
<
String
,
dynamic
>
range
in
ranges
)
{
final
Map
<
String
,
dynamic
>
coverage
=
range
[
'coverage'
];
final
Map
<
String
,
dynamic
>
coverage
=
range
[
'coverage'
];
final
String
scriptIndex
=
range
[
'scriptIndex'
];
// Coverage reports may sometimes be null for a Script.
// Coverage reports may sometimes be null for a Script.
if
(
coverage
==
null
||
scriptIndex
==
null
)
{
if
(
coverage
==
null
)
{
continue
;
}
final
Map
<
String
,
dynamic
>
scriptRef
=
scripts
[
scriptIndex
];
if
(
scriptRef
==
null
)
{
continue
;
continue
;
}
}
final
Map
<
String
,
dynamic
>
scriptRef
=
sourceReport
[
'scripts'
][
range
[
'scriptIndex'
]];
final
String
uri
=
scriptRef
[
'uri'
];
final
String
uri
=
scriptRef
[
'uri'
];
final
String
id
=
scriptRef
[
'id'
];
if
(
uri
==
null
||
id
==
null
)
{
continue
;
}
final
Map
<
String
,
Object
>
scriptById
=
scripts
[
id
];
if
(
scriptById
==
null
)
{
continue
;
}
hitMaps
[
uri
]
??=
<
int
,
int
>{};
hitMaps
[
uri
]
??=
<
int
,
int
>{};
final
Map
<
int
,
int
>
hitMap
=
hitMaps
[
uri
];
final
Map
<
int
,
int
>
hitMap
=
hitMaps
[
uri
];
final
List
<
dynamic
>
hits
=
coverage
[
'hits'
];
final
List
<
dynamic
>
hits
=
coverage
[
'hits'
];
final
List
<
dynamic
>
misses
=
coverage
[
'misses'
];
final
List
<
dynamic
>
misses
=
coverage
[
'misses'
];
final
List
<
dynamic
>
tokenPositions
=
script
ById
[
'tokenPosTable'
];
final
List
<
dynamic
>
tokenPositions
=
script
s
[
scriptRef
[
'id'
]]
[
'tokenPosTable'
];
// The token positions can be null if the script has no coverable lines.
// The token positions can be null if the script has no coverable lines.
if
(
tokenPositions
==
null
)
{
if
(
tokenPositions
==
null
)
{
continue
;
continue
;
...
...
packages/flutter_tools/test/general.shard/coverage_collector_test.dart
View file @
349d694f
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment