Commit 341bd476 authored by Eric Seidel's avatar Eric Seidel

Move flutter drive to use 8183 to not conflict with diagnostic server

When @jason-simons added the diagnostic server on Android this
happened to conflict with flutter drive's usage of 8182.

We really should fix both of these port users to be dynamic
but this fixes https://github.com/flutter/flutter/issues/3291
for now.

@yjbanov
parent dd81a21c
...@@ -41,8 +41,8 @@ class FlutterDriver { ...@@ -41,8 +41,8 @@ class FlutterDriver {
/// Resumes the application if it is currently paused (e.g. at a breakpoint). /// Resumes the application if it is currently paused (e.g. at a breakpoint).
/// ///
/// [dartVmServiceUrl] is the URL to Dart observatory (a.k.a. VM service). By /// [dartVmServiceUrl] is the URL to Dart observatory (a.k.a. VM service). By
/// default it connects to `http://localhost:8182`. /// default it connects to `http://localhost:8183`.
static Future<FlutterDriver> connect({String dartVmServiceUrl: 'http://localhost:8182'}) async { static Future<FlutterDriver> connect({String dartVmServiceUrl: 'http://localhost:8183'}) async {
// Connect to Dart VM servcies // Connect to Dart VM servcies
_log.info('Connecting to Flutter application at $dartVmServiceUrl'); _log.info('Connecting to Flutter application at $dartVmServiceUrl');
VMServiceClientConnection connection = await vmServiceConnectFunction(dartVmServiceUrl); VMServiceClientConnection connection = await vmServiceConnectFunction(dartVmServiceUrl);
......
...@@ -60,7 +60,7 @@ class DriveCommand extends RunCommandBase { ...@@ -60,7 +60,7 @@ class DriveCommand extends RunCommandBase {
); );
argParser.addOption('debug-port', argParser.addOption('debug-port',
defaultsTo: '8182', defaultsTo: '8183',
help: 'Listen to the given port for a debug connection.'); help: 'Listen to the given port for a debug connection.');
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment