Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
32e6de84
Unverified
Commit
32e6de84
authored
Jun 28, 2021
by
Justin McCandless
Committed by
GitHub
Jun 28, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove out dated todos from integration tests with no issue links (#85461)
parent
af42e7d7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
5 deletions
+1
-5
transformations_demo_gesture_transformable.dart
...ormations/transformations_demo_gesture_transformable.dart
+1
-3
transformations_demo_inertial_motion.dart
...transformations/transformations_demo_inertial_motion.dart
+0
-2
No files found.
dev/integration_tests/flutter_gallery/lib/demo/transformations/transformations_demo_gesture_transformable.dart
View file @
32e6de84
...
@@ -175,8 +175,8 @@ class _GestureTransformableState extends State<GestureTransformable> with Ticker
...
@@ -175,8 +175,8 @@ class _GestureTransformableState extends State<GestureTransformable> with Ticker
}
}
// Get the offset of the current widget from the global screen coordinates.
// Get the offset of the current widget from the global screen coordinates.
// TODO(justinmc): Protect against calling this during first build.
static
Offset
getOffset
(
BuildContext
context
)
{
static
Offset
getOffset
(
BuildContext
context
)
{
assert
(
context
.
findRenderObject
()
!=
null
,
'The given context must have a renderObject, such as after the first build has completed.'
);
final
RenderBox
renderObject
=
context
.
findRenderObject
()!
as
RenderBox
;
final
RenderBox
renderObject
=
context
.
findRenderObject
()!
as
RenderBox
;
return
renderObject
.
localToGlobal
(
Offset
.
zero
);
return
renderObject
.
localToGlobal
(
Offset
.
zero
);
}
}
...
@@ -334,8 +334,6 @@ class _GestureTransformableState extends State<GestureTransformable> with Ticker
...
@@ -334,8 +334,6 @@ class _GestureTransformableState extends State<GestureTransformable> with Ticker
Offset
(
nextTranslation
.
dx
,
nextTranslation
.
dy
),
Offset
(
nextTranslation
.
dx
,
nextTranslation
.
dy
),
);
);
if
(!
inBoundaries
)
{
if
(!
inBoundaries
)
{
// TODO(justinmc): Instead of canceling translation when it goes out of
// bounds, stop translation at boundary.
return
matrix
;
return
matrix
;
}
}
...
...
dev/integration_tests/flutter_gallery/lib/demo/transformations/transformations_demo_inertial_motion.dart
View file @
32e6de84
...
@@ -9,7 +9,6 @@ import 'package:vector_math/vector_math.dart' show Vector2;
...
@@ -9,7 +9,6 @@ import 'package:vector_math/vector_math.dart' show Vector2;
// Provides calculations for an object moving with inertia and friction using
// Provides calculations for an object moving with inertia and friction using
// the equation of motion from physics.
// the equation of motion from physics.
// https://en.wikipedia.org/wiki/Equations_of_motion#Constant_translational_acceleration_in_a_straight_line
// https://en.wikipedia.org/wiki/Equations_of_motion#Constant_translational_acceleration_in_a_straight_line
// TODO(justinmc): Can this be replaced with friction_simulation.dart?
@immutable
@immutable
class
InertialMotion
{
class
InertialMotion
{
const
InertialMotion
(
this
.
_initialVelocity
,
this
.
_initialPosition
);
const
InertialMotion
(
this
.
_initialVelocity
,
this
.
_initialPosition
);
...
@@ -30,7 +29,6 @@ class InertialMotion {
...
@@ -30,7 +29,6 @@ class InertialMotion {
// The acceleration opposing the initial velocity in x and y components.
// The acceleration opposing the initial velocity in x and y components.
Vector2
get
_acceleration
{
Vector2
get
_acceleration
{
// TODO(justinmc): Find actual velocity instead of summing?
final
double
velocityTotal
=
_initialVelocity
.
pixelsPerSecond
.
dx
.
abs
()
final
double
velocityTotal
=
_initialVelocity
.
pixelsPerSecond
.
dx
.
abs
()
+
_initialVelocity
.
pixelsPerSecond
.
dy
.
abs
();
+
_initialVelocity
.
pixelsPerSecond
.
dy
.
abs
();
final
double
vRatioX
=
_initialVelocity
.
pixelsPerSecond
.
dx
/
velocityTotal
;
final
double
vRatioX
=
_initialVelocity
.
pixelsPerSecond
.
dx
/
velocityTotal
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment