Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
32e1e00e
Unverified
Commit
32e1e00e
authored
Jan 15, 2021
by
Jonah Williams
Committed by
GitHub
Jan 15, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] handle NPE in language analytics (#74075)
parent
17edb9aa
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
22 additions
and
1 deletion
+22
-1
events.dart
packages/flutter_tools/lib/src/reporting/events.dart
+2
-1
events_test.dart
...utter_tools/test/general.shard/reporting/events_test.dart
+20
-0
No files found.
packages/flutter_tools/lib/src/reporting/events.dart
View file @
32e1e00e
...
...
@@ -283,7 +283,8 @@ class NullSafetyAnalysisEvent implements UsageEvent {
if
(
package
.
name
==
currentPackage
)
{
languageVersion
=
package
.
languageVersion
;
}
if
(
package
.
languageVersion
.
major
>=
nullSafeVersion
.
major
&&
if
(
package
.
languageVersion
!=
null
&&
package
.
languageVersion
.
major
>=
nullSafeVersion
.
major
&&
package
.
languageVersion
.
minor
>=
nullSafeVersion
.
minor
)
{
migrated
+=
1
;
}
...
...
packages/flutter_tools/test/general.shard/reporting/events_test.dart
View file @
32e1e00e
...
...
@@ -96,6 +96,26 @@ void main() {
})).
called
(
1
);
verifyNever
(
usage
.
sendEvent
(
NullSafetyAnalysisEvent
.
kNullSafetyCategory
,
'language-version'
,
label:
anyNamed
(
'label'
)));
});
testWithoutContext
(
'a null language version is treated as unmigrated'
,
()
{
final
Usage
usage
=
MockUsage
();
final
PackageConfig
packageConfig
=
PackageConfig
(<
Package
>[
Package
(
'foo'
,
Uri
.
parse
(
'file:///foo/lib/'
),
languageVersion:
null
),
]);
NullSafetyAnalysisEvent
(
packageConfig
,
NullSafetyMode
.
sound
,
'something-unrelated'
,
usage
,
).
send
();
verify
(
usage
.
sendEvent
(
NullSafetyAnalysisEvent
.
kNullSafetyCategory
,
'runtime-mode'
,
label:
'NullSafetyMode.sound'
)).
called
(
1
);
verify
(
usage
.
sendEvent
(
NullSafetyAnalysisEvent
.
kNullSafetyCategory
,
'stats'
,
parameters:
<
String
,
String
>{
'cd49'
:
'0'
,
'cd50'
:
'1'
,
})).
called
(
1
);
verifyNever
(
usage
.
sendEvent
(
NullSafetyAnalysisEvent
.
kNullSafetyCategory
,
'language-version'
,
label:
anyNamed
(
'label'
)));
});
}
class
FakeGroupedValidator
extends
GroupedValidator
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment