Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3233252c
Unverified
Commit
3233252c
authored
Jan 28, 2020
by
Jonah Williams
Committed by
GitHub
Jan 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] only apply --strip to iOS gen_snapshot in release mode (#49596)
parent
afa24b1a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
2 deletions
+1
-2
build.dart
packages/flutter_tools/lib/src/base/build.dart
+1
-1
build_test.dart
...ges/flutter_tools/test/general.shard/base/build_test.dart
+0
-1
No files found.
packages/flutter_tools/lib/src/base/build.dart
View file @
3233252c
...
...
@@ -139,7 +139,7 @@ class AOTSnapshotter {
genSnapshotArgs
.
add
(
'--assembly=
$assembly
'
);
// TODO(jonahwilliams): determine the correct time to use strip
// since this is required for the future dwarf strack traces option.
if
(
bitcode
)
{
if
(
bitcode
&&
buildMode
==
BuildMode
.
release
)
{
genSnapshotArgs
.
add
(
'--strip'
);
}
}
else
{
...
...
packages/flutter_tools/test/general.shard/base/build_test.dart
View file @
3233252c
...
...
@@ -326,7 +326,6 @@ void main() {
'--deterministic'
,
'--snapshot_kind=app-aot-assembly'
,
'--assembly=
$assembly
'
,
'--strip'
,
'--no-sim-use-hardfp'
,
'--no-use-integer-division'
,
'--no-causal-async-stacks'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment