Unverified Commit 320d2cff authored by Jenn Magder's avatar Jenn Magder Committed by GitHub

Increase recommended CocoaPods version to 1.11 (#98621)

parent 8d5903f7
...@@ -69,7 +69,7 @@ enum CocoaPodsStatus { ...@@ -69,7 +69,7 @@ enum CocoaPodsStatus {
} }
const Version cocoaPodsMinimumVersion = Version.withText(1, 9, 0, '1.9.0'); const Version cocoaPodsMinimumVersion = Version.withText(1, 9, 0, '1.9.0');
const Version cocoaPodsRecommendedVersion = Version.withText(1, 10, 0, '1.10.0'); const Version cocoaPodsRecommendedVersion = Version.withText(1, 11, 0, '1.11.0');
/// Cocoapods is a dependency management solution for iOS and macOS applications. /// Cocoapods is a dependency management solution for iOS and macOS applications.
/// ///
......
...@@ -165,13 +165,13 @@ void main() { ...@@ -165,13 +165,13 @@ void main() {
testWithoutContext('detects at recommended version', () async { testWithoutContext('detects at recommended version', () async {
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('1.11.0');
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended); expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended);
}); });
testWithoutContext('detects above recommended version', () async { testWithoutContext('detects above recommended version', () async {
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.1'); pretendPodVersionIs('1.11.1');
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended); expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended);
}); });
}); });
...@@ -410,7 +410,7 @@ void main() { ...@@ -410,7 +410,7 @@ void main() {
testUsingContext('prints warning if macOS Podfile parses .flutter-plugins', () async { testUsingContext('prints warning if macOS Podfile parses .flutter-plugins', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
fakeProcessManager.addCommands(const <FakeCommand>[ fakeProcessManager.addCommands(const <FakeCommand>[
FakeCommand( FakeCommand(
command: <String>['pod', 'install', '--verbose'], command: <String>['pod', 'install', '--verbose'],
...@@ -449,7 +449,7 @@ void main() { ...@@ -449,7 +449,7 @@ void main() {
testUsingContext('throws, if specs repo is outdated.', () async { testUsingContext('throws, if specs repo is outdated.', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
fileSystem.file(fileSystem.path.join('project', 'ios', 'Podfile')) fileSystem.file(fileSystem.path.join('project', 'ios', 'Podfile'))
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -499,7 +499,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -499,7 +499,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('ffi $errorName failure on ARM macOS prompts gem install', () async { testUsingContext('ffi $errorName failure on ARM macOS prompts gem install', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
fileSystem.file(fileSystem.path.join('project', 'ios', 'Podfile')) fileSystem.file(fileSystem.path.join('project', 'ios', 'Podfile'))
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -542,7 +542,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -542,7 +542,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('ffi failure on x86 macOS does not prompt gem install', () async { testUsingContext('ffi failure on x86 macOS does not prompt gem install', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
fileSystem.file(fileSystem.path.join('project', 'ios', 'Podfile')) fileSystem.file(fileSystem.path.join('project', 'ios', 'Podfile'))
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -586,7 +586,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -586,7 +586,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('run pod install, if Podfile.lock is missing', () async { testUsingContext('run pod install, if Podfile.lock is missing', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
projectUnderTest.ios.podfile projectUnderTest.ios.podfile
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -613,7 +613,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -613,7 +613,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('runs iOS pod install, if Manifest.lock is missing', () async { testUsingContext('runs iOS pod install, if Manifest.lock is missing', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
projectUnderTest.ios.podfile projectUnderTest.ios.podfile
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -642,7 +642,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -642,7 +642,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('runs macOS pod install, if Manifest.lock is missing', () async { testUsingContext('runs macOS pod install, if Manifest.lock is missing', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
projectUnderTest.macos.podfile projectUnderTest.macos.podfile
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -671,7 +671,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -671,7 +671,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('runs pod install, if Manifest.lock different from Podspec.lock', () async { testUsingContext('runs pod install, if Manifest.lock different from Podspec.lock', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
projectUnderTest.ios.podfile projectUnderTest.ios.podfile
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -703,7 +703,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -703,7 +703,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('runs pod install, if flutter framework changed', () async { testUsingContext('runs pod install, if flutter framework changed', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
projectUnderTest.ios.podfile projectUnderTest.ios.podfile
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -735,7 +735,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -735,7 +735,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('runs pod install, if Podfile.lock is older than Podfile', () async { testUsingContext('runs pod install, if Podfile.lock is older than Podfile', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
projectUnderTest.ios.podfile projectUnderTest.ios.podfile
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
...@@ -789,7 +789,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by ...@@ -789,7 +789,7 @@ Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by
testUsingContext('a failed pod install deletes Pods/Manifest.lock', () async { testUsingContext('a failed pod install deletes Pods/Manifest.lock', () async {
final FlutterProject projectUnderTest = setupProjectUnderTest(); final FlutterProject projectUnderTest = setupProjectUnderTest();
pretendPodIsInstalled(); pretendPodIsInstalled();
pretendPodVersionIs('1.10.0'); pretendPodVersionIs('100.0.0');
projectUnderTest.ios.podfile projectUnderTest.ios.podfile
..createSync() ..createSync()
..writeAsStringSync('Existing Podfile'); ..writeAsStringSync('Existing Podfile');
......
...@@ -40,7 +40,7 @@ void main() { ...@@ -40,7 +40,7 @@ void main() {
final ValidationMessage message = result.messages.first; final ValidationMessage message = result.messages.first;
expect(message.type, ValidationMessageType.hint); expect(message.type, ValidationMessageType.hint);
expect(message.message, contains('CocoaPods $currentVersion out of date')); expect(message.message, contains('CocoaPods $currentVersion out of date'));
expect(message.message, contains('(1.10.0 is recommended)')); expect(message.message, contains('(1.11.0 is recommended)'));
}); });
}); });
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment