Unverified Commit 3023fe20 authored by Todd Volkert's avatar Todd Volkert Committed by GitHub

Add map-specific catch block in run_hot (#14689)

Fixes #14688
parent 556a33a3
...@@ -562,7 +562,7 @@ class HotRunner extends ResidentRunner { ...@@ -562,7 +562,7 @@ class HotRunner extends ResidentRunner {
printTrace('reloaded $loadedLibraryCount of $finalLibraryCount libraries'); printTrace('reloaded $loadedLibraryCount of $finalLibraryCount libraries');
reloadMessage = 'Reloaded $loadedLibraryCount of $finalLibraryCount libraries'; reloadMessage = 'Reloaded $loadedLibraryCount of $finalLibraryCount libraries';
} }
} catch (error, st) { } on Map<String, dynamic> catch (error, st) {
printError('Hot reload failed: $error\n$st'); printError('Hot reload failed: $error\n$st');
final int errorCode = error['code']; final int errorCode = error['code'];
final String errorMessage = error['message']; final String errorMessage = error['message'];
...@@ -576,6 +576,9 @@ class HotRunner extends ResidentRunner { ...@@ -576,6 +576,9 @@ class HotRunner extends ResidentRunner {
printError('Hot reload failed:\ncode = $errorCode\nmessage = $errorMessage\n$st'); printError('Hot reload failed:\ncode = $errorCode\nmessage = $errorMessage\n$st');
return new OperationResult(errorCode, errorMessage); return new OperationResult(errorCode, errorMessage);
} catch (error, st) {
printError('Hot reload failed: $error\n$st');
return new OperationResult(1, '$error');
} }
// Record time it took for the VM to reload the sources. // Record time it took for the VM to reload the sources.
_addBenchmarkData('hotReloadVMReloadMilliseconds', _addBenchmarkData('hotReloadVMReloadMilliseconds',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment