Unverified Commit 2f6fdf26 authored by Matan Lurey's avatar Matan Lurey Committed by GitHub

Start renaming by adding a new `bringup: true` as an Android emulator. (#142257)

Part 2 of https://github.com/flutter/flutter/issues/142178.

Supersedes https://github.com/flutter/flutter/pull/142078.

Feedback welcome to avoid reverts!
parent 15fa68ab
......@@ -2167,6 +2167,9 @@ targets:
["devicelab", "android", "linux", "pixel", "7pro"]
task_name: embedded_android_views_integration_test
# TODO(https://github.com/flutter/flutter/issues/142178): Remove this.
# In the process of (a) renaming this "external_textures" and (b) making it
# an emulator test instead of a physical device.
- name: Linux_pixel_7pro external_ui_integration_test
recipe: devicelab/devicelab_drone
presubmit: false
......@@ -2174,7 +2177,24 @@ targets:
properties:
tags: >
["devicelab", "android", "linux", "pixel", "7pro"]
task_name: external_ui_integration_test
task_name: external_textures_integration_test
- name: Linux_android_emu external_ui_integration_test
recipe: devicelab/devicelab_drone
# TODO(https://github.com/flutter/flutter/issues/142178): Enable this.
bringup: true
timeout: 60
# Functionally the same as "presubmit: false", except that we will run on
# presubmit during engine rolls. This test is the *only* automated e2e
# test for external textures for the engine, it should never break.
runIf:
- bin/internal/engine.version
- .ci.yaml
properties:
tags: >
["devicelab", "linux"]
# TODO(https://github.com/flutter/flutter/issues/142178): Rename this.
task_name: external_textures_integration_test
# linux motog4 benchmark
- name: Linux_android fading_child_animation_perf__timeline_summary
......@@ -4274,6 +4294,13 @@ targets:
["devicelab", "ios", "mac"]
task_name: imagefiltered_transform_animation_perf_ios__timeline_summary
# TODO(https://github.com/flutter/flutter/issues/106806): Find a way to
# re-enable this without "ignore_flakiness: "true"", likely by loostening the
# test assertions, or potentially not running the frame rate tests at all on
# iOS (for example, doing pixel-tests instead).
#
# Also, rename this to "external_textures_integration_test" to be consistent
# with the Android test, but that can wait until we've figured out the flake.
- name: Mac_ios external_ui_integration_test_ios
recipe: devicelab/devicelab_drone
presubmit: false
......@@ -4281,7 +4308,7 @@ targets:
properties:
tags: >
["devicelab", "ios", "mac"]
task_name: external_ui_integration_test_ios
task_name: external_textures_integration_test_ios
ignore_flakiness: "true"
- name: Mac_ios route_test_ios
......
......@@ -129,7 +129,7 @@
/dev/devicelab/bin/tasks/cull_opacity_perf__timeline_summary.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/drive_perf_debug_warning.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/embedded_android_views_integration_test.dart @stuartmorgan @flutter/plugin
/dev/devicelab/bin/tasks/external_ui_integration_test.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/external_textures_integration_test.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/fading_child_animation_perf__timeline_summary.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/flavors_test.dart @zanderso @flutter/tool
......@@ -174,7 +174,7 @@
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_bad_ios__timeline_summary.dart @jonahwilliams @flutter/engine
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_ios__timeline_summary.dart @vashworth @flutter/engine
/dev/devicelab/bin/tasks/cubic_bezier_perf_ios_sksl_warmup__timeline_summary.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/external_ui_integration_test_ios.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/external_textures_integration_test_ios.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/flavors_test_ios.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/flavors_test_ios_xcode_debug.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/flutter_gallery__transition_perf_e2e_ios.dart @zanderso @flutter/engine
......
......@@ -8,5 +8,5 @@ import 'package:flutter_devicelab/tasks/integration_tests.dart';
Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.android;
await task(createExternalUiFrameRateIntegrationTest());
await task(createExternalTexturesFrameRateIntegrationTest());
}
......@@ -8,5 +8,5 @@ import 'package:flutter_devicelab/tasks/integration_tests.dart';
Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.ios;
await task(createExternalUiFrameRateIntegrationTest());
await task(createExternalTexturesFrameRateIntegrationTest());
}
......@@ -40,7 +40,7 @@ TaskFunction createIntegrationTestFlavorsTest({Map<String, String>? environment}
).call;
}
TaskFunction createExternalUiFrameRateIntegrationTest() {
TaskFunction createExternalTexturesFrameRateIntegrationTest() {
return DriverTest(
'${flutterDirectory.path}/dev/integration_tests/external_textures',
'lib/frame_rate_main.dart',
......
......@@ -40,8 +40,8 @@ flutter drive lib/frame_rate_main.dart --driver test_driver/frame_rate_test.dart
>
> The actual tests are run by task runners:
>
> - [Android](../../devicelab/bin/tasks/external_ui_integration_test.dart)
> - [iOS](../../devicelab/bin/tasks/external_ui_integration_test_ios.dart)
> - [Android](../../devicelab/bin/tasks/external_textures_integration_test.dart)
> - [iOS](../../devicelab/bin/tasks/external_textures_integration_test_ios.dart)
[^1]: Only iOS and Android.
[^2]: Unfortunately documentation is quite limited. See [#142021](https://github.com/flutter/flutter/issues/142021).
......@@ -11,7 +11,7 @@
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>external_ui</string>
<string>external_textures</string>
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment