Unverified Commit 2efbc11b authored by Ian Hickson's avatar Ian Hickson Committed by GitHub

Revert "Keep Flutter.framework binaries writable so they can be code signed (#39539)" (#39859)

This reverts commit 72cacb40.
parent b9d9156f
...@@ -532,6 +532,7 @@ task: ...@@ -532,6 +532,7 @@ task:
- ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976 - ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976
- dart --enable-asserts dev/bots/test.dart - dart --enable-asserts dev/bots/test.dart
- name: add2app-macos - name: add2app-macos
skip: true # https://github.com/flutter/flutter/issues/39507
env: env:
SHARD: add2app_test SHARD: add2app_test
setup_xcpretty_script: setup_xcpretty_script:
......
...@@ -142,13 +142,11 @@ BuildApp() { ...@@ -142,13 +142,11 @@ BuildApp() {
mkdir "${derived_dir}/engine" mkdir "${derived_dir}/engine"
RunCommand cp -r -- "${flutter_podspec}" "${derived_dir}/engine" RunCommand cp -r -- "${flutter_podspec}" "${derived_dir}/engine"
RunCommand cp -r -- "${flutter_framework}" "${derived_dir}/engine" RunCommand cp -r -- "${flutter_framework}" "${derived_dir}/engine"
# Make non-binary files read-only to discourage editing headers, but allow binary code-signing. RunCommand find "${derived_dir}/engine/Flutter.framework" -type f -exec chmod a-w "{}" \;
RunCommand find "${derived_dir}/engine/Flutter.framework" -type f -exec grep -Il '.' {} \; | xargs chmod a-w
else else
RunCommand rm -rf -- "${derived_dir}/Flutter.framework" RunCommand rm -rf -- "${derived_dir}/Flutter.framework"
RunCommand cp -r -- "${flutter_framework}" "${derived_dir}" RunCommand cp -r -- "${flutter_framework}" "${derived_dir}"
# Make non-binary files read-only to discourage editing headers, but allow binary code-signing. RunCommand find "${derived_dir}/Flutter.framework" -type f -exec chmod a-w "{}" \;
RunCommand find "${derived_dir}/Flutter.framework" -type f -exec grep -Il '.' {} \; | xargs chmod a-w
fi fi
RunCommand pushd "${project_path}" > /dev/null RunCommand pushd "${project_path}" > /dev/null
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment