Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
2cf85025
Unverified
Commit
2cf85025
authored
Apr 11, 2023
by
Ian Hickson
Committed by
GitHub
Apr 11, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Implement "iterations" directive for customer tests (#124541)
Implement "iterations" directive for customer tests
parent
5da6c4da
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
3 deletions
+23
-3
customer_test.dart
dev/customer_testing/lib/customer_test.dart
+12
-1
runner.dart
dev/customer_testing/lib/runner.dart
+10
-1
run_tests.dart
dev/customer_testing/run_tests.dart
+1
-1
No files found.
dev/customer_testing/lib/customer_test.dart
View file @
2cf85025
...
...
@@ -14,6 +14,7 @@ class CustomerTest {
final
List
<
String
>
fetch
=
<
String
>[];
final
List
<
Directory
>
update
=
<
Directory
>[];
final
List
<
String
>
test
=
<
String
>[];
int
?
iterations
;
bool
hasTests
=
false
;
for
(
final
String
line
in
testFile
.
readAsLinesSync
().
map
((
String
line
)
=>
line
.
trim
()))
{
if
(
line
.
isEmpty
)
{
...
...
@@ -26,6 +27,14 @@ class CustomerTest {
fetch
.
add
(
line
.
substring
(
6
));
}
else
if
(
line
.
startsWith
(
'update='
))
{
update
.
add
(
Directory
(
line
.
substring
(
7
)));
}
else
if
(
line
.
startsWith
(
'iterations='
))
{
if
(
iterations
!=
null
)
{
throw
const
FormatException
(
'Cannot specify "iterations" directive multiple times.'
);
}
iterations
=
int
.
parse
(
line
.
substring
(
11
));
if
(
iterations
<
1
)
{
throw
const
FormatException
(
'The "iterations" directive must have a positive integer value.'
);
}
}
else
if
(
line
.
startsWith
(
'test='
))
{
hasTests
=
true
;
test
.
add
(
line
.
substring
(
5
));
...
...
@@ -84,10 +93,11 @@ class CustomerTest {
List
<
String
>.
unmodifiable
(
fetch
),
List
<
Directory
>.
unmodifiable
(
update
),
List
<
String
>.
unmodifiable
(
test
),
iterations
,
);
}
const
CustomerTest
.
_
(
this
.
contacts
,
this
.
fetch
,
this
.
update
,
this
.
tests
);
const
CustomerTest
.
_
(
this
.
contacts
,
this
.
fetch
,
this
.
update
,
this
.
tests
,
this
.
iterations
);
// (e-mail regexp from HTML standard)
static
final
RegExp
_email
=
RegExp
(
r"^[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$"
);
...
...
@@ -98,4 +108,5 @@ class CustomerTest {
final
List
<
String
>
fetch
;
final
List
<
Directory
>
update
;
final
List
<
String
>
tests
;
final
int
?
iterations
;
}
dev/customer_testing/lib/runner.dart
View file @
2cf85025
...
...
@@ -133,6 +133,14 @@ Future<bool> runTests({
if
(
verbose
)
{
print
(
'Running tests...'
);
}
if
(
instructions
.
iterations
!=
null
&&
instructions
.
iterations
!
<
repeat
)
{
if
(
verbose
)
{
final
String
s
=
instructions
.
iterations
==
1
?
''
:
's'
;
print
(
'Limiting to
${instructions.iterations}
round
$s
rather than
$repeat
rounds because of "iterations" directive.'
);
}
repeat
=
instructions
.
iterations
!;
}
final
Stopwatch
stopwatch
=
Stopwatch
()..
start
();
for
(
int
iteration
=
0
;
iteration
<
repeat
;
iteration
+=
1
)
{
if
(
verbose
&&
repeat
>
1
)
{
print
(
'Round
${iteration + 1}
of
$repeat
.'
);
...
...
@@ -146,8 +154,9 @@ Future<bool> runTests({
}
}
}
stopwatch
.
stop
();
if
(
verbose
&&
success
)
{
print
(
'Tests finished.'
);
print
(
'Tests finished
in
${(stopwatch.elapsed.inSeconds / repeat).toStringAsFixed(2)}
seconds per iteration
.'
);
}
}
}
...
...
dev/customer_testing/run_tests.dart
View file @
2cf85025
...
...
@@ -24,7 +24,7 @@ Future<bool> run(List<String> arguments) async {
..
addOption
(
'repeat'
,
defaultsTo:
'1'
,
help:
'How many times to run each test. Set to a high value to look for flakes.'
,
help:
'How many times to run each test. Set to a high value to look for flakes.
If a test specifies a number of iterations, the lower of the two values is used.
'
,
valueHelp:
'count'
,
)
..
addOption
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment