Flip enable-android-embedding-v2 flag (#44369)

2c80bc97 · Emmanuel Garcia · GitHub · cc9e9ce2 · 2c80bc97 · 2c80bc97
Unverified Commit 2c80bc97 authored Nov 07, 2019 by Emmanuel Garcia Committed by GitHub Nov 07, 2019
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

test.dart dev/bots/test.dart +1 -3

features.dart packages/flutter_tools/lib/src/features.dart +1 -1

No files found.
--- a/dev/bots/test.dart
+++ b/dev/bots/test.dart
@@ -754,10 +754,8 @@ Future<void> _runHostOnlyDeviceLabTests() async {
    () => _runDevicelabTest('gradle_plugin_light_apk_test', environment: gradleEnvironment),
    () => _runDevicelabTest('gradle_r8_test', environment: gradleEnvironment),
-    () => _runDevicelabTest('module_host_with_custom_build_test', environment: gradleEnvironment, testEmbeddingV2: false),
    () => _runDevicelabTest('module_host_with_custom_build_test', environment: gradleEnvironment, testEmbeddingV2: true),
-    if (!Platform.isMacOS) () => _runDevicelabTest('module_test', environment: gradleEnvironment, testEmbeddingV2: false),
+    () => _runDevicelabTest('module_test', environment: gradleEnvironment, testEmbeddingV2: true),
-    if (!Platform.isMacOS) () => _runDevicelabTest('module_test', environment: gradleEnvironment, testEmbeddingV2: true),
    // TODO(jmagman): Re-enable once flakiness is resolved, https://github.com/flutter/flutter/issues/37525
    // if (Platform.isMacOS) () => _runDevicelabTest('module_test_ios'),

--- a/packages/flutter_tools/lib/src/features.dart
+++ b/packages/flutter_tools/lib/src/features.dart
@@ -143,7 +143,7 @@ const Feature flutterAndroidEmbeddingV2Feature = Feature(
  configSetting: 'enable-android-embedding-v2',
  master: FeatureChannelSetting(
    available: true,
-    enabledByDefault: false,
+    enabledByDefault: true,
  ),
 );