Unverified Commit 2c56a25d authored by Kevin Moore's avatar Kevin Moore Committed by GitHub

[tool] Improve help info with build web --wasm flags (#125907)

Also fixed some comments
parent 0f9d66aa
...@@ -98,13 +98,16 @@ class BuildWebCommand extends BuildSubCommand { ...@@ -98,13 +98,16 @@ class BuildWebCommand extends BuildSubCommand {
); );
argParser.addFlag( argParser.addFlag(
'omit-type-checks', 'omit-type-checks',
help: 'Omit type checks in Wasm output.', help: 'Omit type checks in Wasm output.\n'
'Reduces code size and improves performance, but may affect runtime correctness. Use with care.',
negatable: false, negatable: false,
hide: !featureFlags.isFlutterWebWasmEnabled, hide: !featureFlags.isFlutterWebWasmEnabled,
); );
argParser.addFlag( argParser.addFlag(
'wasm-opt', 'wasm-opt',
help: 'Run wasm-opt on the output wasm module.', help:
'Optimize output wasm using the Binaryen (https://github.com/WebAssembly/binaryen) tool.\n'
'Increases the build time, but will yield a smaller, faster output.',
negatable: false, negatable: false,
hide: !featureFlags.isFlutterWebWasmEnabled, hide: !featureFlags.isFlutterWebWasmEnabled,
); );
......
...@@ -147,14 +147,16 @@ class WasmCompilerConfig extends WebCompilerConfig { ...@@ -147,14 +147,16 @@ class WasmCompilerConfig extends WebCompilerConfig {
runWasmOpt: defines[kRunWasmOpt] == 'true', runWasmOpt: defines[kRunWasmOpt] == 'true',
); );
/// Build environment for [omitTypeChecks]; /// Build environment for [omitTypeChecks].
static const String kOmitTypeChecks = 'WasmOmitTypeChecks'; static const String kOmitTypeChecks = 'WasmOmitTypeChecks';
/// Build environment for [runWasmOpt].
static const String kRunWasmOpt = 'RunWasmOpt'; static const String kRunWasmOpt = 'RunWasmOpt';
/// If `omit-type-checks` should be passed to `dart2wasm`. /// If `omit-type-checks` should be passed to `dart2wasm`.
final bool omitTypeChecks; final bool omitTypeChecks;
// Run wasm-opt on the resulting module. /// Run wasm-opt on the resulting module.
final bool runWasmOpt; final bool runWasmOpt;
@override @override
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment