Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
2b20345b
Unverified
Commit
2b20345b
authored
Jul 10, 2019
by
Jonah Williams
Committed by
GitHub
Jul 10, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
use pub run for create test and remove [INFO] logs (#35839)
parent
e3a08d23
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
19 additions
and
4 deletions
+19
-4
run_command.dart
dev/bots/run_command.dart
+8
-2
test.dart
dev/bots/test.dart
+6
-2
dart_test.yaml
packages/flutter_tools/dart_test.yaml
+5
-0
No files found.
dev/bots/run_command.dart
View file @
2b20345b
...
@@ -87,6 +87,7 @@ Future<void> runCommand(String executable, List<String> arguments, {
...
@@ -87,6 +87,7 @@ Future<void> runCommand(String executable, List<String> arguments, {
bool
skip
=
false
,
bool
skip
=
false
,
bool
expectFlaky
=
false
,
bool
expectFlaky
=
false
,
Duration
timeout
=
_kLongTimeout
,
Duration
timeout
=
_kLongTimeout
,
bool
Function
(
String
)
removeLine
,
})
async
{
})
async
{
final
String
commandDescription
=
'
${path.relative(executable, from: workingDirectory)}
${arguments.join(' ')}
'
;
final
String
commandDescription
=
'
${path.relative(executable, from: workingDirectory)}
${arguments.join(' ')}
'
;
final
String
relativeWorkingDir
=
path
.
relative
(
workingDirectory
);
final
String
relativeWorkingDir
=
path
.
relative
(
workingDirectory
);
...
@@ -103,13 +104,18 @@ Future<void> runCommand(String executable, List<String> arguments, {
...
@@ -103,13 +104,18 @@ Future<void> runCommand(String executable, List<String> arguments, {
);
);
Future
<
List
<
List
<
int
>>>
savedStdout
,
savedStderr
;
Future
<
List
<
List
<
int
>>>
savedStdout
,
savedStderr
;
final
Stream
<
List
<
int
>>
stdoutSource
=
process
.
stdout
.
transform
<
String
>(
const
Utf8Decoder
())
.
transform
(
const
LineSplitter
())
.
where
((
String
line
)
=>
removeLine
==
null
||
!
removeLine
(
line
))
.
transform
(
const
Utf8Encoder
());
if
(
printOutput
)
{
if
(
printOutput
)
{
await
Future
.
wait
<
void
>(<
Future
<
void
>>[
await
Future
.
wait
<
void
>(<
Future
<
void
>>[
stdout
.
addStream
(
process
.
stdout
),
stdout
.
addStream
(
stdoutSource
),
stderr
.
addStream
(
process
.
stderr
),
stderr
.
addStream
(
process
.
stderr
),
]);
]);
}
else
{
}
else
{
savedStdout
=
process
.
stdout
.
toList
();
savedStdout
=
stdoutSource
.
toList
();
savedStderr
=
process
.
stderr
.
toList
();
savedStderr
=
process
.
stderr
.
toList
();
}
}
...
...
dev/bots/test.dart
View file @
2b20345b
...
@@ -240,7 +240,8 @@ Future<void> _runToolTests() async {
...
@@ -240,7 +240,8 @@ Future<void> _runToolTests() async {
File
(
path
.
join
(
flutterRoot
,
'bin'
,
'cache'
,
'flutter_tools.snapshot'
)).
deleteSync
();
File
(
path
.
join
(
flutterRoot
,
'bin'
,
'cache'
,
'flutter_tools.snapshot'
)).
deleteSync
();
File
(
path
.
join
(
flutterRoot
,
'bin'
,
'cache'
,
'flutter_tools.stamp'
)).
deleteSync
();
File
(
path
.
join
(
flutterRoot
,
'bin'
,
'cache'
,
'flutter_tools.stamp'
)).
deleteSync
();
}
}
if
(
noUseBuildRunner
)
{
// reduce overhead of build_runner in the create case.
if
(
noUseBuildRunner
||
Platform
.
environment
[
'SUBSHARD'
]
==
'create'
)
{
await
_pubRunTest
(
await
_pubRunTest
(
path
.
join
(
flutterRoot
,
'packages'
,
'flutter_tools'
),
path
.
join
(
flutterRoot
,
'packages'
,
'flutter_tools'
),
tableData:
bigqueryApi
?.
tabledata
,
tableData:
bigqueryApi
?.
tabledata
,
...
@@ -591,6 +592,9 @@ Future<void> _pubRunTest(
...
@@ -591,6 +592,9 @@ Future<void> _pubRunTest(
case
'tool'
:
case
'tool'
:
args
.
addAll
(<
String
>[
'--exclude-tags'
,
'integration'
]);
args
.
addAll
(<
String
>[
'--exclude-tags'
,
'integration'
]);
break
;
break
;
case
'create'
:
args
.
addAll
(<
String
>[
path
.
join
(
'test'
,
'commands'
,
'create_test.dart'
)]);
break
;
}
}
if
(
useFlutterTestFormatter
)
{
if
(
useFlutterTestFormatter
)
{
...
@@ -606,7 +610,7 @@ Future<void> _pubRunTest(
...
@@ -606,7 +610,7 @@ Future<void> _pubRunTest(
await
runCommand
(
await
runCommand
(
pub
,
pub
,
args
,
args
,
workingDirectory:
workingDirectory
,
workingDirectory:
workingDirectory
,
);
);
}
}
}
}
...
...
packages/flutter_tools/dart_test.yaml
0 → 100644
View file @
2b20345b
tags
:
"
no_coverage"
:
"
create"
:
"
integration"
:
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment