Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
2a54bb02
Unverified
Commit
2a54bb02
authored
Feb 26, 2021
by
Jenn Magder
Committed by
GitHub
Feb 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Opt into CocoaPods parallel codesigning (#76833)
parent
2951363d
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
1 deletion
+9
-1
xcodeproj.dart
packages/flutter_tools/lib/src/ios/xcodeproj.dart
+4
-0
build_macos_test.dart
..._tools/test/commands.shard/hermetic/build_macos_test.dart
+2
-1
create_test.dart
...tter_tools/test/commands.shard/permeable/create_test.dart
+3
-0
No files found.
packages/flutter_tools/lib/src/ios/xcodeproj.dart
View file @
2a54bb02
...
...
@@ -172,6 +172,10 @@ List<String> _xcodeBuildSettingsLines({
// This holds because requiresProjectRoot is true for this command
xcodeBuildSettings
.
add
(
'FLUTTER_APPLICATION_PATH=
${globals.fs.path.normalize(project.directory.path)}
'
);
// Tell CocoaPods behavior to codesign in parallel with rest of scripts to speed it up.
// Value must be "true", not "YES". https://github.com/CocoaPods/CocoaPods/pull/6088
xcodeBuildSettings
.
add
(
'COCOAPODS_PARALLEL_CODE_SIGN=true'
);
// Relative to FLUTTER_APPLICATION_PATH, which is [Directory.current].
if
(
targetOverride
!=
null
)
{
xcodeBuildSettings
.
add
(
'FLUTTER_TARGET=
$targetOverride
'
);
...
...
packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart
View file @
2a54bb02
...
...
@@ -274,7 +274,8 @@ void main() {
'TRACK_WIDGET_CREATION=true'
,
'TREE_SHAKE_ICONS=true'
,
'BUNDLE_SKSL_PATH=foo/bar.sksl.json'
,
'PACKAGE_CONFIG=/.dart_tool/package_config.json'
'PACKAGE_CONFIG=/.dart_tool/package_config.json'
,
'COCOAPODS_PARALLEL_CODE_SIGN=true'
,
]));
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
fileSystem
,
...
...
packages/flutter_tools/test/commands.shard/permeable/create_test.dart
View file @
2a54bb02
...
...
@@ -1056,6 +1056,7 @@ void main() {
expect
(
xcodeConfig
,
contains
(
'FLUTTER_ROOT='
));
expect
(
xcodeConfig
,
contains
(
'FLUTTER_APPLICATION_PATH='
));
expect
(
xcodeConfig
,
contains
(
'FLUTTER_TARGET='
));
expect
(
xcodeConfig
,
contains
(
'COCOAPODS_PARALLEL_CODE_SIGN=true'
));
// Generated export environment variables script
final
String
buildPhaseScriptPath
=
globals
.
fs
.
path
.
join
(
'.ios'
,
'Flutter'
,
'flutter_export_environment.sh'
);
...
...
@@ -1065,6 +1066,7 @@ void main() {
expect
(
buildPhaseScript
,
contains
(
'FLUTTER_ROOT='
));
expect
(
buildPhaseScript
,
contains
(
'FLUTTER_APPLICATION_PATH='
));
expect
(
buildPhaseScript
,
contains
(
'FLUTTER_TARGET='
));
expect
(
buildPhaseScript
,
contains
(
'COCOAPODS_PARALLEL_CODE_SIGN=true'
));
// Generated podspec
final
String
podspecPath
=
globals
.
fs
.
path
.
join
(
'.ios'
,
'Flutter'
,
'flutter_project.podspec'
);
...
...
@@ -1157,6 +1159,7 @@ void main() {
final
String
xcodeConfig
=
xcodeConfigFile
.
readAsStringSync
();
expect
(
xcodeConfig
,
contains
(
'FLUTTER_ROOT='
));
expect
(
xcodeConfig
,
contains
(
'FLUTTER_APPLICATION_PATH='
));
expect
(
xcodeConfig
,
contains
(
'COCOAPODS_PARALLEL_CODE_SIGN=true'
));
// App identification
final
String
xcodeProjectPath
=
globals
.
fs
.
path
.
join
(
'ios'
,
'Runner.xcodeproj'
,
'project.pbxproj'
);
expectExists
(
xcodeProjectPath
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment