Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
2767d37c
Commit
2767d37c
authored
Jun 03, 2019
by
Ian Hickson
Committed by
Michael Goderbauer
Jun 03, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
RTL caret in text fields (#33461)
parent
f7bfd549
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
17 additions
and
14 deletions
+17
-14
flutter
bin/flutter
+1
-1
test.dart
dev/bots/test.dart
+11
-11
snippets_test.dart
dev/snippets/test/snippets_test.dart
+1
-1
editable_text.dart
packages/flutter/lib/src/widgets/editable_text.dart
+1
-1
scroll_metrics.dart
packages/flutter/lib/src/widgets/scroll_metrics.dart
+1
-0
scroll_position.dart
packages/flutter/lib/src/widgets/scroll_position.dart
+2
-0
No files found.
bin/flutter
View file @
2767d37c
...
@@ -173,7 +173,7 @@ if [[ ! -e "$FLUTTER_ROOT/.git" ]]; then
...
@@ -173,7 +173,7 @@ if [[ ! -e "$FLUTTER_ROOT/.git" ]]; then
fi
fi
# To debug the tool, you can uncomment the following lines to enable checked mode and set an observatory port:
# To debug the tool, you can uncomment the following lines to enable checked mode and set an observatory port:
# FLUTTER_TOOL_ARGS="--
checked
$FLUTTER_TOOL_ARGS"
# FLUTTER_TOOL_ARGS="--
enable-asserts
$FLUTTER_TOOL_ARGS"
# FLUTTER_TOOL_ARGS="$FLUTTER_TOOL_ARGS --observe=65432"
# FLUTTER_TOOL_ARGS="$FLUTTER_TOOL_ARGS --observe=65432"
(
upgrade_flutter
)
3<
"
$PROG_NAME
"
(
upgrade_flutter
)
3<
"
$PROG_NAME
"
...
...
dev/bots/test.dart
View file @
2767d37c
dev/snippets/test/snippets_test.dart
View file @
2767d37c
...
@@ -19,7 +19,7 @@ void main() {
...
@@ -19,7 +19,7 @@ void main() {
File
template
;
File
template
;
setUp
(()
{
setUp
(()
{
tmpDir
=
Directory
.
systemTemp
.
createTempSync
(
'
snippets_test
'
);
tmpDir
=
Directory
.
systemTemp
.
createTempSync
(
'
flutter_snippets_test.
'
);
configuration
=
Configuration
(
flutterRoot:
Directory
(
path
.
join
(
configuration
=
Configuration
(
flutterRoot:
Directory
(
path
.
join
(
tmpDir
.
absolute
.
path
,
'flutter'
)));
tmpDir
.
absolute
.
path
,
'flutter'
)));
configuration
.
createOutputDirectory
();
configuration
.
createOutputDirectory
();
...
...
packages/flutter/lib/src/widgets/editable_text.dart
View file @
2767d37c
packages/flutter/lib/src/widgets/scroll_metrics.dart
View file @
2767d37c
...
@@ -104,6 +104,7 @@ abstract class ScrollMetrics {
...
@@ -104,6 +104,7 @@ abstract class ScrollMetrics {
///
///
/// The value is always non-negative, and less than or equal to [viewportDimension].
/// The value is always non-negative, and less than or equal to [viewportDimension].
double
get
extentInside
{
double
get
extentInside
{
assert
(
minScrollExtent
<=
maxScrollExtent
);
return
viewportDimension
return
viewportDimension
// "above" overscroll value
// "above" overscroll value
-
(
minScrollExtent
-
pixels
).
clamp
(
0
,
viewportDimension
)
-
(
minScrollExtent
-
pixels
).
clamp
(
0
,
viewportDimension
)
...
...
packages/flutter/lib/src/widgets/scroll_position.dart
View file @
2767d37c
...
@@ -447,6 +447,8 @@ abstract class ScrollPosition extends ViewportOffset with ScrollMetrics {
...
@@ -447,6 +447,8 @@ abstract class ScrollPosition extends ViewportOffset with ScrollMetrics {
@override
@override
bool
applyContentDimensions
(
double
minScrollExtent
,
double
maxScrollExtent
)
{
bool
applyContentDimensions
(
double
minScrollExtent
,
double
maxScrollExtent
)
{
assert
(
minScrollExtent
!=
null
);
assert
(
maxScrollExtent
!=
null
);
if
(!
nearEqual
(
_minScrollExtent
,
minScrollExtent
,
Tolerance
.
defaultTolerance
.
distance
)
||
if
(!
nearEqual
(
_minScrollExtent
,
minScrollExtent
,
Tolerance
.
defaultTolerance
.
distance
)
||
!
nearEqual
(
_maxScrollExtent
,
maxScrollExtent
,
Tolerance
.
defaultTolerance
.
distance
)
||
!
nearEqual
(
_maxScrollExtent
,
maxScrollExtent
,
Tolerance
.
defaultTolerance
.
distance
)
||
_didChangeViewportDimensionOrReceiveCorrection
)
{
_didChangeViewportDimensionOrReceiveCorrection
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment