Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
224f91e3
Unverified
Commit
224f91e3
authored
Oct 01, 2018
by
Jonah Williams
Committed by
GitHub
Oct 01, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Eliminate snapshot, depfile opts from bundle cmd (#22495)" (#22519)
This reverts commit
b07d986f
.
parent
b07d986f
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
17 additions
and
9 deletions
+17
-9
build.dart
packages/flutter_tools/lib/src/base/build.dart
+1
-1
bundle.dart
packages/flutter_tools/lib/src/bundle.dart
+5
-1
build_bundle.dart
packages/flutter_tools/lib/src/commands/build_bundle.dart
+4
-0
compile.dart
packages/flutter_tools/lib/src/compile.dart
+6
-6
flutter_tester_test.dart
packages/flutter_tools/test/tester/flutter_tester_test.dart
+1
-1
No files found.
packages/flutter_tools/lib/src/base/build.dart
View file @
224f91e3
...
...
@@ -308,7 +308,7 @@ class AOTSnapshotter {
sdkRoot:
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
),
mainPath:
mainPath
,
outputFilePath:
fs
.
path
.
join
(
outputPath
,
'app.dill'
),
dep
f
ilePath:
depfilePath
,
dep
F
ilePath:
depfilePath
,
extraFrontEndOptions:
extraFrontEndOptions
,
linkPlatformKernelIn:
true
,
aot:
true
,
...
...
packages/flutter_tools/lib/src/bundle.dart
View file @
224f91e3
...
...
@@ -35,7 +35,9 @@ Future<void> build({
BuildMode
buildMode
,
String
mainPath
=
defaultMainPath
,
String
manifestPath
=
defaultManifestPath
,
String
snapshotPath
,
String
applicationKernelFilePath
,
String
depfilePath
,
String
privateKeyPath
=
defaultPrivateKeyPath
,
String
assetDirPath
,
String
packagesPath
,
...
...
@@ -49,6 +51,8 @@ Future<void> build({
List
<
String
>
fileSystemRoots
,
String
fileSystemScheme
,
})
async
{
snapshotPath
??=
defaultSnapshotPath
;
depfilePath
??=
defaultDepfilePath
;
assetDirPath
??=
getAssetBuildDirectory
();
packagesPath
??=
fs
.
path
.
absolute
(
PackageMap
.
globalPackagesPath
);
applicationKernelFilePath
??=
defaultApplicationKernelPath
;
...
...
@@ -64,7 +68,7 @@ Future<void> build({
fs
.
path
.
absolute
(
getIncrementalCompilerByteStoreDirectory
()),
mainPath:
fs
.
file
(
mainPath
).
absolute
.
path
,
outputFilePath:
applicationKernelFilePath
,
dep
filePath:
defaultD
epfilePath
,
dep
FilePath:
d
epfilePath
,
trackWidgetCreation:
trackWidgetCreation
,
extraFrontEndOptions:
extraFrontEndOptions
,
fileSystemRoots:
fileSystemRoots
,
...
...
packages/flutter_tools/lib/src/commands/build_bundle.dart
View file @
224f91e3
...
...
@@ -22,6 +22,8 @@ class BuildBundleCommand extends BuildSubCommand {
..
addOption
(
'asset-base'
,
help:
'Ignored. Will be removed.'
,
hide:
!
verboseHelp
)
..
addOption
(
'manifest'
,
defaultsTo:
defaultManifestPath
)
..
addOption
(
'private-key'
,
defaultsTo:
defaultPrivateKeyPath
)
..
addOption
(
'snapshot'
,
defaultsTo:
defaultSnapshotPath
)
..
addOption
(
'depfile'
,
defaultsTo:
defaultDepfilePath
)
..
addOption
(
'kernel-file'
,
defaultsTo:
defaultApplicationKernelPath
)
..
addOption
(
'target-platform'
,
defaultsTo:
'android-arm'
,
...
...
@@ -91,7 +93,9 @@ class BuildBundleCommand extends BuildSubCommand {
buildMode:
buildMode
,
mainPath:
targetFile
,
manifestPath:
argResults
[
'manifest'
],
snapshotPath:
argResults
[
'snapshot'
],
applicationKernelFilePath:
argResults
[
'kernel-file'
],
depfilePath:
argResults
[
'depfile'
],
privateKeyPath:
argResults
[
'private-key'
],
assetDirPath:
argResults
[
'asset-dir'
],
precompiledSnapshot:
argResults
[
'precompiled'
],
...
...
packages/flutter_tools/lib/src/compile.dart
View file @
224f91e3
...
...
@@ -81,7 +81,7 @@ class KernelCompiler {
String
sdkRoot
,
String
mainPath
,
String
outputFilePath
,
String
dep
f
ilePath
,
String
dep
F
ilePath
,
bool
linkPlatformKernelIn
=
false
,
bool
aot
=
false
,
bool
trackWidgetCreation
=
false
,
...
...
@@ -100,16 +100,16 @@ class KernelCompiler {
// Currently the compiler emits buildbot paths for the core libs in the
// depfile. None of these are available on the local host.
Fingerprinter
fingerprinter
;
if
(
dep
f
ilePath
!=
null
)
{
if
(
dep
F
ilePath
!=
null
)
{
fingerprinter
=
Fingerprinter
(
fingerprintPath:
'
$dep
f
ilePath
.fingerprint'
,
fingerprintPath:
'
$dep
F
ilePath
.fingerprint'
,
paths:
<
String
>[
mainPath
],
properties:
<
String
,
String
>{
'entryPoint'
:
mainPath
,
'trackWidgetCreation'
:
trackWidgetCreation
.
toString
(),
'linkPlatformKernelIn'
:
linkPlatformKernelIn
.
toString
(),
},
depfilePaths:
<
String
>[
dep
f
ilePath
],
depfilePaths:
<
String
>[
dep
F
ilePath
],
pathFilter:
(
String
path
)
=>
!
path
.
startsWith
(
'/b/build/slave/'
),
);
...
...
@@ -154,8 +154,8 @@ class KernelCompiler {
if
(
outputFilePath
!=
null
)
{
command
.
addAll
(<
String
>[
'--output-dill'
,
outputFilePath
]);
}
if
(
dep
f
ilePath
!=
null
&&
(
fileSystemRoots
==
null
||
fileSystemRoots
.
isEmpty
))
{
command
.
addAll
(<
String
>[
'--depfile'
,
dep
f
ilePath
]);
if
(
dep
F
ilePath
!=
null
&&
(
fileSystemRoots
==
null
||
fileSystemRoots
.
isEmpty
))
{
command
.
addAll
(<
String
>[
'--depfile'
,
dep
F
ilePath
]);
}
if
(
fileSystemRoots
!=
null
)
{
for
(
String
root
in
fileSystemRoots
)
{
...
...
packages/flutter_tools/test/tester/flutter_tester_test.dart
View file @
224f91e3
...
...
@@ -169,7 +169,7 @@ Hello!
incrementalCompilerByteStorePath:
anyNamed
(
'incrementalCompilerByteStorePath'
),
mainPath:
anyNamed
(
'mainPath'
),
outputFilePath:
anyNamed
(
'outputFilePath'
),
dep
filePath:
anyNamed
(
'depf
ilePath'
),
dep
FilePath:
anyNamed
(
'depF
ilePath'
),
trackWidgetCreation:
anyNamed
(
'trackWidgetCreation'
),
extraFrontEndOptions:
anyNamed
(
'extraFrontEndOptions'
),
fileSystemRoots:
anyNamed
(
'fileSystemRoots'
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment