Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
1df28e8b
Commit
1df28e8b
authored
Mar 01, 2019
by
ocavue
Committed by
Hans Muller
Mar 01, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix ink highlight effect of RawChip (#28653)
parent
604e9dc6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
1 deletion
+17
-1
chip.dart
packages/flutter/lib/src/material/chip.dart
+2
-1
chip_test.dart
packages/flutter/test/material/chip_test.dart
+15
-0
No files found.
packages/flutter/lib/src/material/chip.dart
View file @
1df28e8b
...
@@ -1625,10 +1625,11 @@ class _RawChipState extends State<RawChip> with TickerProviderStateMixin<RawChip
...
@@ -1625,10 +1625,11 @@ class _RawChipState extends State<RawChip> with TickerProviderStateMixin<RawChip
animationDuration:
pressedAnimationDuration
,
animationDuration:
pressedAnimationDuration
,
shape:
shape
,
shape:
shape
,
clipBehavior:
widget
.
clipBehavior
,
clipBehavior:
widget
.
clipBehavior
,
child:
Ink
Response
(
child:
Ink
Well
(
onTap:
canTap
?
_handleTap
:
null
,
onTap:
canTap
?
_handleTap
:
null
,
onTapDown:
canTap
?
_handleTapDown
:
null
,
onTapDown:
canTap
?
_handleTapDown
:
null
,
onTapCancel:
canTap
?
_handleTapCancel
:
null
,
onTapCancel:
canTap
?
_handleTapCancel
:
null
,
customBorder:
shape
,
child:
AnimatedBuilder
(
child:
AnimatedBuilder
(
animation:
Listenable
.
merge
(<
Listenable
>[
selectController
,
enableController
]),
animation:
Listenable
.
merge
(<
Listenable
>[
selectController
,
enableController
]),
builder:
(
BuildContext
context
,
Widget
child
)
{
builder:
(
BuildContext
context
,
Widget
child
)
{
...
...
packages/flutter/test/material/chip_test.dart
View file @
1df28e8b
...
@@ -1649,4 +1649,19 @@ void main() {
...
@@ -1649,4 +1649,19 @@ void main() {
const
Offset
(
4
,
4
),
const
Offset
(
4
,
4
),
]));
]));
});
});
testWidgets
(
'Chips should use InkWell instead of InkResponse.'
,
(
WidgetTester
tester
)
async
{
// Regression test for https://github.com/flutter/flutter/issues/28646
await
tester
.
pumpWidget
(
MaterialApp
(
home:
Material
(
child:
ActionChip
(
onPressed:
(){},
label:
const
Text
(
'action chip'
),
),
),
),
);
expect
(
find
.
byType
(
InkWell
),
findsOneWidget
);
});
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment