Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
18eac03d
Commit
18eac03d
authored
May 12, 2017
by
Ian Hickson
Committed by
GitHub
May 12, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
VerboseLogger should just wrap the parent Logger (#10020)
This way, you can test things even with a VerboseLogger.
parent
eaa93674
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
35 additions
and
9 deletions
+35
-9
logger.dart
packages/flutter_tools/lib/src/base/logger.dart
+10
-8
flutter_command_runner.dart
.../flutter_tools/lib/src/runner/flutter_command_runner.dart
+1
-1
logger_test.dart
packages/flutter_tools/test/src/base/logger_test.dart
+24
-0
No files found.
packages/flutter_tools/lib/src/base/logger.dart
View file @
18eac03d
...
@@ -180,12 +180,14 @@ class BufferLogger extends Logger {
...
@@ -180,12 +180,14 @@ class BufferLogger extends Logger {
}
}
class
VerboseLogger
extends
Logger
{
class
VerboseLogger
extends
Logger
{
Stopwatch
stopwatch
=
new
Stopwatch
();
VerboseLogger
(
this
.
parent
)
{
VerboseLogger
()
{
stopwatch
.
start
();
stopwatch
.
start
();
}
}
final
Logger
parent
;
Stopwatch
stopwatch
=
new
Stopwatch
();
@override
@override
bool
get
isVerbose
=>
true
;
bool
get
isVerbose
=>
true
;
...
@@ -221,7 +223,7 @@ class VerboseLogger extends Logger {
...
@@ -221,7 +223,7 @@ class VerboseLogger extends Logger {
stopwatch
.
reset
();
stopwatch
.
reset
();
String
prefix
;
String
prefix
;
const
int
prefixWidth
=
8
;
const
int
prefixWidth
=
12
;
if
(
millis
==
0
)
{
if
(
millis
==
0
)
{
prefix
=
''
.
padLeft
(
prefixWidth
);
prefix
=
''
.
padLeft
(
prefixWidth
);
}
else
{
}
else
{
...
@@ -235,13 +237,13 @@ class VerboseLogger extends Logger {
...
@@ -235,13 +237,13 @@ class VerboseLogger extends Logger {
final
String
indentMessage
=
message
.
replaceAll
(
'
\n
'
,
'
\n
$indent
'
);
final
String
indentMessage
=
message
.
replaceAll
(
'
\n
'
,
'
\n
$indent
'
);
if
(
type
==
_LogType
.
error
)
{
if
(
type
==
_LogType
.
error
)
{
stderr
.
writeln
(
prefix
+
terminal
.
bolden
(
indentMessage
));
parent
.
printError
(
prefix
+
terminal
.
bolden
(
indentMessage
));
if
(
stackTrace
!=
null
)
if
(
stackTrace
!=
null
)
stderr
.
writeln
(
indent
+
stackTrace
.
toString
().
replaceAll
(
'
\n
'
,
'
\n
$indent
'
));
parent
.
printError
(
indent
+
stackTrace
.
toString
().
replaceAll
(
'
\n
'
,
'
\n
$indent
'
));
}
else
if
(
type
==
_LogType
.
status
)
{
}
else
if
(
type
==
_LogType
.
status
)
{
p
rint
(
prefix
+
terminal
.
bolden
(
indentMessage
));
p
arent
.
printStatus
(
prefix
+
terminal
.
bolden
(
indentMessage
));
}
else
{
}
else
{
p
rint
(
prefix
+
indentMessage
);
p
arent
.
printStatus
(
prefix
+
indentMessage
);
}
}
}
}
}
}
...
...
packages/flutter_tools/lib/src/runner/flutter_command_runner.dart
View file @
18eac03d
...
@@ -161,7 +161,7 @@ class FlutterCommandRunner extends CommandRunner<Null> {
...
@@ -161,7 +161,7 @@ class FlutterCommandRunner extends CommandRunner<Null> {
// Check for verbose.
// Check for verbose.
if
(
globalResults
[
'verbose'
])
{
if
(
globalResults
[
'verbose'
])
{
// Override the logger.
// Override the logger.
context
.
setVariable
(
Logger
,
new
VerboseLogger
());
context
.
setVariable
(
Logger
,
new
VerboseLogger
(
context
[
Logger
]
));
}
}
String
recordTo
=
globalResults
[
'record-to'
];
String
recordTo
=
globalResults
[
'record-to'
];
...
...
packages/flutter_tools/test/src/base/logger_test.dart
0 → 100644
View file @
18eac03d
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'package:flutter_tools/src/base/logger.dart'
;
import
'package:test/test.dart'
;
void
main
(
)
{
group
(
'AppContext'
,
()
{
test
(
'error'
,
()
async
{
final
BufferLogger
mockLogger
=
new
BufferLogger
();
final
VerboseLogger
verboseLogger
=
new
VerboseLogger
(
mockLogger
);
verboseLogger
.
printStatus
(
'Hey Hey Hey Hey'
);
verboseLogger
.
printTrace
(
'Oooh, I do I do I do'
);
verboseLogger
.
printError
(
'Helpless!'
);
expect
(
mockLogger
.
statusText
,
matches
(
r'^\[ (?: {0,2}\+[0-9]{1,3} ms| )\] Hey Hey Hey Hey\n'
r'\[ (?: {0,2}\+[0-9]{1,3} ms| )\] Oooh, I do I do I do\n$'
));
expect
(
mockLogger
.
traceText
,
''
);
expect
(
mockLogger
.
errorText
,
matches
(
r'^\[ (?: {0,2}\+[0-9]{1,3} ms| )\] Helpless!\n$'
));
});
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment