Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
18a118b9
Unverified
Commit
18a118b9
authored
Apr 22, 2021
by
Jenn Magder
Committed by
GitHub
Apr 22, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Log full app bundle location after "flutter build ios" (#80838)
parent
f608d893
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
9 additions
and
2 deletions
+9
-2
build_ios.dart
packages/flutter_tools/lib/src/commands/build_ios.dart
+1
-1
mac.dart
packages/flutter_tools/lib/src/ios/mac.dart
+6
-1
build_ios_test.dart
...er_tools/test/commands.shard/hermetic/build_ios_test.dart
+1
-0
build_ipa_test.dart
...er_tools/test/commands.shard/hermetic/build_ipa_test.dart
+1
-0
No files found.
packages/flutter_tools/lib/src/commands/build_ios.dart
View file @
18a118b9
...
@@ -59,7 +59,7 @@ class BuildIOSCommand extends _BuildIOSSubCommand {
...
@@ -59,7 +59,7 @@ class BuildIOSCommand extends _BuildIOSSubCommand {
bool
get
shouldCodesign
=>
boolArg
(
'codesign'
);
bool
get
shouldCodesign
=>
boolArg
(
'codesign'
);
@override
@override
Directory
_outputAppDirectory
(
String
xcodeResultOutput
)
=>
globals
.
fs
.
directory
(
xcodeResultOutput
);
Directory
_outputAppDirectory
(
String
xcodeResultOutput
)
=>
globals
.
fs
.
directory
(
xcodeResultOutput
)
.
parent
;
}
}
/// Builds an .xcarchive and optionally .ipa for an iOS app to be generated for
/// Builds an .xcarchive and optionally .ipa for an iOS app to be generated for
...
...
packages/flutter_tools/lib/src/ios/mac.dart
View file @
18a118b9
...
@@ -425,9 +425,10 @@ Future<XcodeBuildResult> buildXcodeProject({
...
@@ -425,9 +425,10 @@ Future<XcodeBuildResult> buildXcodeProject({
globals
.
printTrace
(
'Replacing iphoneos with iphonesimulator in TARGET_BUILD_DIR.'
);
globals
.
printTrace
(
'Replacing iphoneos with iphonesimulator in TARGET_BUILD_DIR.'
);
targetBuildDir
=
targetBuildDir
.
replaceFirst
(
'iphoneos'
,
'iphonesimulator'
);
targetBuildDir
=
targetBuildDir
.
replaceFirst
(
'iphoneos'
,
'iphonesimulator'
);
}
}
final
String
appBundle
=
buildSettings
[
'WRAPPER_NAME'
];
final
String
expectedOutputDirectory
=
globals
.
fs
.
path
.
join
(
final
String
expectedOutputDirectory
=
globals
.
fs
.
path
.
join
(
targetBuildDir
,
targetBuildDir
,
buildSettings
[
'WRAPPER_NAME'
]
,
appBundle
,
);
);
if
(
globals
.
fs
.
directory
(
expectedOutputDirectory
).
existsSync
())
{
if
(
globals
.
fs
.
directory
(
expectedOutputDirectory
).
existsSync
())
{
// Copy app folder to a place where other tools can find it without knowing
// Copy app folder to a place where other tools can find it without knowing
...
@@ -448,6 +449,10 @@ Future<XcodeBuildResult> buildXcodeProject({
...
@@ -448,6 +449,10 @@ Future<XcodeBuildResult> buildXcodeProject({
],
],
throwOnError:
true
,
throwOnError:
true
,
);
);
outputDir
=
globals
.
fs
.
path
.
join
(
outputDir
,
appBundle
,
);
}
else
{
}
else
{
globals
.
printError
(
'Build succeeded but the expected app at
$expectedOutputDirectory
not found'
);
globals
.
printError
(
'Build succeeded but the expected app at
$expectedOutputDirectory
not found'
);
}
}
...
...
packages/flutter_tools/test/commands.shard/hermetic/build_ios_test.dart
View file @
18a118b9
...
@@ -171,6 +171,7 @@ void main() {
...
@@ -171,6 +171,7 @@ void main() {
await
createTestCommandRunner
(
command
).
run
(
await
createTestCommandRunner
(
command
).
run
(
const
<
String
>[
'build'
,
'ios'
,
'--no-pub'
]
const
<
String
>[
'build'
,
'ios'
,
'--no-pub'
]
);
);
expect
(
testLogger
.
statusText
,
contains
(
'build/ios/iphoneos/Runner.app'
));
},
overrides:
<
Type
,
Generator
>{
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
fileSystem
,
FileSystem:
()
=>
fileSystem
,
ProcessManager:
()
=>
FakeProcessManager
.
list
(<
FakeCommand
>[
ProcessManager:
()
=>
FakeProcessManager
.
list
(<
FakeCommand
>[
...
...
packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart
View file @
18a118b9
...
@@ -218,6 +218,7 @@ void main() {
...
@@ -218,6 +218,7 @@ void main() {
await
createTestCommandRunner
(
command
).
run
(
await
createTestCommandRunner
(
command
).
run
(
const
<
String
>[
'build'
,
'ipa'
,
'--no-pub'
]
const
<
String
>[
'build'
,
'ipa'
,
'--no-pub'
]
);
);
expect
(
testLogger
.
statusText
,
contains
(
'build/ios/archive/Runner.xcarchive'
));
},
overrides:
<
Type
,
Generator
>{
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
fileSystem
,
FileSystem:
()
=>
fileSystem
,
ProcessManager:
()
=>
FakeProcessManager
.
list
(<
FakeCommand
>[
ProcessManager:
()
=>
FakeProcessManager
.
list
(<
FakeCommand
>[
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment