Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
17d31797
Unverified
Commit
17d31797
authored
Aug 03, 2020
by
Hans Muller
Committed by
GitHub
Aug 03, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use OverflowBar instead of ButtonBar in TimePicker (#62601)
parent
e3c3d6eb
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
112 additions
and
63 deletions
+112
-63
time_picker.dart
packages/flutter/lib/src/material/time_picker.dart
+18
-15
time_picker_test.dart
packages/flutter/test/material/time_picker_test.dart
+94
-48
No files found.
packages/flutter/lib/src/material/time_picker.dart
View file @
17d31797
...
...
@@ -11,8 +11,6 @@ import 'package:flutter/rendering.dart';
import
'package:flutter/services.dart'
;
import
'package:flutter/widgets.dart'
;
import
'button_bar.dart'
;
import
'button_theme.dart'
;
import
'color_scheme.dart'
;
import
'colors.dart'
;
import
'constants.dart'
;
...
...
@@ -1827,9 +1825,13 @@ class _TimePickerDialogState extends State<_TimePickerDialog> {
:
MaterialLocalizations
.
of
(
context
).
dialModeButtonLabel
,
),
Expanded
(
// TODO(rami-a): Move away from ButtonBar to avoid https://github.com/flutter/flutter/issues/53378.
child:
ButtonBar
(
layoutBehavior:
ButtonBarLayoutBehavior
.
constrained
,
child:
Container
(
alignment:
AlignmentDirectional
.
centerEnd
,
constraints:
const
BoxConstraints
(
minHeight:
52.0
),
padding:
const
EdgeInsets
.
symmetric
(
horizontal:
8
),
child:
OverflowBar
(
spacing:
8
,
overflowAlignment:
OverflowBarAlignment
.
end
,
children:
<
Widget
>[
TextButton
(
onPressed:
_handleCancel
,
...
...
@@ -1842,6 +1844,7 @@ class _TimePickerDialogState extends State<_TimePickerDialog> {
],
),
),
),
],
);
...
...
packages/flutter/test/material/time_picker_test.dart
View file @
17d31797
...
...
@@ -643,9 +643,55 @@ void _tests() {
expect
(
find
.
text
(
helperText
),
findsOneWidget
);
});
// TODO(rami-a): Re-enable and fix test.
testWidgets
(
'text scale affects certain elements and not others'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'OK Cancel button layout'
,
(
WidgetTester
tester
)
async
{
Widget
buildFrame
(
TextDirection
textDirection
)
{
return
MaterialApp
(
home:
Material
(
child:
Center
(
child:
Builder
(
builder:
(
BuildContext
context
)
{
return
ElevatedButton
(
child:
const
Text
(
'X'
),
onPressed:
()
{
showTimePicker
(
context:
context
,
initialTime:
const
TimeOfDay
(
hour:
7
,
minute:
0
),
builder:
(
BuildContext
context
,
Widget
child
)
{
return
Directionality
(
textDirection:
textDirection
,
child:
child
,
);
},
);
},
);
},
),
),
),
);
}
await
tester
.
pumpWidget
(
buildFrame
(
TextDirection
.
ltr
));
await
tester
.
tap
(
find
.
text
(
'X'
));
await
tester
.
pumpAndSettle
();
expect
(
tester
.
getBottomRight
(
find
.
text
(
'OK'
)).
dx
,
638
);
expect
(
tester
.
getBottomLeft
(
find
.
text
(
'OK'
)).
dx
,
610
);
expect
(
tester
.
getBottomRight
(
find
.
text
(
'CANCEL'
)).
dx
,
576
);
await
tester
.
tap
(
find
.
text
(
'OK'
));
await
tester
.
pumpAndSettle
();
await
tester
.
pumpWidget
(
buildFrame
(
TextDirection
.
rtl
));
await
tester
.
tap
(
find
.
text
(
'X'
));
await
tester
.
pumpAndSettle
();
expect
(
tester
.
getBottomLeft
(
find
.
text
(
'OK'
)).
dx
,
162
);
expect
(
tester
.
getBottomRight
(
find
.
text
(
'OK'
)).
dx
,
190
);
expect
(
tester
.
getBottomLeft
(
find
.
text
(
'CANCEL'
)).
dx
,
224
);
await
tester
.
tap
(
find
.
text
(
'OK'
));
await
tester
.
pumpAndSettle
();
});
testWidgets
(
'text scale affects certain elements and not others'
,
(
WidgetTester
tester
)
async
{
await
mediaQueryBoilerplate
(
tester
,
false
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment