Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
16e484b1
Unverified
Commit
16e484b1
authored
Jul 25, 2019
by
Jonah Williams
Committed by
GitHub
Jul 25, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove Chain terse parsing (#36860)
parent
caa64e48
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
3 deletions
+5
-3
runner.dart
packages/flutter_tools/lib/runner.dart
+1
-0
crash_reporting.dart
...ages/flutter_tools/lib/src/reporting/crash_reporting.dart
+3
-3
crash_reporting_test.dart
...lutter_tools/test/general.shard/crash_reporting_test.dart
+1
-0
No files found.
packages/flutter_tools/lib/runner.dart
View file @
16e484b1
...
...
@@ -115,6 +115,7 @@ Future<int> _handleToolError(
error:
error
,
stackTrace:
stackTrace
,
getFlutterVersion:
getFlutterVersion
,
command:
args
.
join
(
' '
),
);
if
(
error
is
String
)
...
...
packages/flutter_tools/lib/src/reporting/crash_reporting.dart
View file @
16e484b1
...
...
@@ -6,7 +6,6 @@ import 'dart:async';
import
'package:http/http.dart'
as
http
;
import
'package:meta/meta.dart'
;
import
'package:stack_trace/stack_trace.dart'
;
import
'../base/io.dart'
;
import
'../base/os.dart'
;
...
...
@@ -85,6 +84,7 @@ class CrashReportSender {
@required
dynamic
error
,
@required
StackTrace
stackTrace
,
@required
String
getFlutterVersion
(),
@required
String
command
,
})
async
{
try
{
final
String
flutterVersion
=
getFlutterVersion
();
...
...
@@ -112,11 +112,11 @@ class CrashReportSender {
req
.
fields
[
'type'
]
=
_kDartTypeId
;
req
.
fields
[
'error_runtime_type'
]
=
'
${error.runtimeType}
'
;
req
.
fields
[
'error_message'
]
=
'
$error
'
;
req
.
fields
[
'comments'
]
=
command
;
final
String
stackTraceWithRelativePaths
=
Chain
.
parse
(
stackTrace
.
toString
()).
terse
.
toString
();
req
.
files
.
add
(
http
.
MultipartFile
.
fromString
(
_kStackTraceFileField
,
stackTrace
WithRelativePaths
,
stackTrace
.
toString
()
,
filename:
_kStackTraceFilename
,
));
...
...
packages/flutter_tools/test/general.shard/crash_reporting_test.dart
View file @
16e484b1
...
...
@@ -181,6 +181,7 @@ Future<void> verifyCrashReportSent(RequestInfo crashInfo) async {
expect
(
crashInfo
.
fields
[
'type'
],
'DartError'
);
expect
(
crashInfo
.
fields
[
'error_runtime_type'
],
'StateError'
);
expect
(
crashInfo
.
fields
[
'error_message'
],
'Bad state: Test bad state error'
);
expect
(
crashInfo
.
fields
[
'comments'
],
'crash'
);
final
BufferLogger
logger
=
context
.
get
<
Logger
>();
expect
(
logger
.
statusText
,
'Sending crash report to Google.
\n
'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment