Unverified Commit 14206399 authored by nturgut's avatar nturgut Committed by GitHub

make sure tests and becnhmarks use correct backend (#72628)

parent 612ef209
...@@ -121,10 +121,10 @@ Example: ...@@ -121,10 +121,10 @@ Example:
cd dev/benchmarks/macrobenchmarks cd dev/benchmarks/macrobenchmarks
# Runs in profile mode using the HTML renderer # Runs in profile mode using the HTML renderer
flutter run --profile -d web-server lib/web_benchmarks.dart flutter run --web-renderer=html --profile -d web-server lib/web_benchmarks.dart
# Runs in profile mode using the CanvasKit renderer # Runs in profile mode using the CanvasKit renderer
flutter run --dart-define=FLUTTER_WEB_USE_SKIA=true --profile -d web-server lib/web_benchmarks.dart flutter run --web-renderer=canvaskit --profile -d web-server lib/web_benchmarks.dart
``` ```
You can also run all benchmarks exactly as the devicelab runs them: You can also run all benchmarks exactly as the devicelab runs them:
......
...@@ -995,6 +995,8 @@ Future<void> _runGalleryE2eWebTest(String buildMode, { bool canvasKit = false }) ...@@ -995,6 +995,8 @@ Future<void> _runGalleryE2eWebTest(String buildMode, { bool canvasKit = false })
'drive', 'drive',
if (canvasKit) if (canvasKit)
'--dart-define=FLUTTER_WEB_USE_SKIA=true', '--dart-define=FLUTTER_WEB_USE_SKIA=true',
if (!canvasKit)
'--dart-define=FLUTTER_WEB_USE_SKIA=false',
'--driver=test_driver/transitions_perf_e2e_test.dart', '--driver=test_driver/transitions_perf_e2e_test.dart',
'--target=test_driver/transitions_perf_e2e.dart', '--target=test_driver/transitions_perf_e2e.dart',
'--browser-name=chrome', '--browser-name=chrome',
......
...@@ -29,6 +29,8 @@ Future<TaskResult> runWebBenchmark({ @required bool useCanvasKit }) async { ...@@ -29,6 +29,8 @@ Future<TaskResult> runWebBenchmark({ @required bool useCanvasKit }) async {
await evalFlutter('build', options: <String>[ await evalFlutter('build', options: <String>[
'web', 'web',
'--dart-define=FLUTTER_WEB_ENABLE_PROFILING=true', '--dart-define=FLUTTER_WEB_ENABLE_PROFILING=true',
if (!useCanvasKit)
'--dart-define=FLUTTER_WEB_USE_SKIA=false',
if (useCanvasKit) if (useCanvasKit)
'--dart-define=FLUTTER_WEB_USE_SKIA=true', '--dart-define=FLUTTER_WEB_USE_SKIA=true',
'--profile', '--profile',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment