Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
1223e87f
Unverified
Commit
1223e87f
authored
Mar 11, 2022
by
Zachary Anderson
Committed by
GitHub
Mar 11, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "[web] roll Chromium dep to 96.2 (#99725)" (#99949)
This reverts commit
0d4b73b2
.
parent
305496b3
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
73 additions
and
65 deletions
+73
-65
.ci.yaml
.ci.yaml
+54
-54
smoke_web_engine_test.dart
examples/hello_world/test_driver/smoke_web_engine_test.dart
+18
-4
dialog_test.dart
packages/flutter/test/cupertino/dialog_test.dart
+1
-7
No files found.
.ci.yaml
View file @
1223e87f
This diff is collapsed.
Click to expand it.
examples/hello_world/test_driver/smoke_web_engine_test.dart
View file @
1223e87f
...
...
@@ -38,11 +38,25 @@ void main() {
// TODO(ianh): this delay violates our style guide. We should instead wait for a triggering event.
await
Future
<
void
>.
delayed
(
const
Duration
(
seconds:
2
));
final
WebElement
?
fltSemantics
=
await
driver
.
webDriver
.
execute
(
'return document.querySelector("flt-glass-pane")?.shadowRoot.querySelector("flt-semantics")'
,
// A flutter web app may be rendered directly on the body of the page, or
// inside the shadow root of the flt-glass-pane (after Flutter 2.4). To
// make this test backwards compatible, we first need to locate the correct
// root for the app.
//
// It's either the shadowRoot within flt-glass-pane, or [driver.webDriver].
final
SearchContext
appRoot
=
await
driver
.
webDriver
.
execute
(
'return document.querySelector("flt-glass-pane")?.shadowRoot;'
,
<
dynamic
>[],
)
as
WebElement
?;
expect
(
fltSemantics
,
isNotNull
);
)
as
SearchContext
?
??
driver
.
webDriver
;
// Elements with tag "flt-semantics" would show up after enabling
// accessibility.
//
// The tag used here is based on
// https://github.com/flutter/engine/blob/master/lib/web_ui/lib/src/engine/semantics/semantics.dart#L534
final
WebElement
element
=
await
appRoot
.
findElement
(
const
By
.
cssSelector
(
'flt-semantics'
));
expect
(
element
,
isNotNull
);
});
});
}
packages/flutter/test/cupertino/dialog_test.dart
View file @
1223e87f
...
...
@@ -10,7 +10,6 @@ import 'dart:math';
import
'dart:ui'
;
import
'package:flutter/cupertino.dart'
;
import
'package:flutter/foundation.dart'
;
import
'package:flutter/material.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
...
...
@@ -325,12 +324,7 @@ void main() {
// Visually the "Cancel" button and "OK" button are the same height when using the
// regular font. However, when using the test font, "Cancel" becomes 2 lines which
// is why the height we're verifying for "Cancel" is larger than "OK".
// TODO(yjbanov): https://github.com/flutter/flutter/issues/99933
// A bug in the HTML renderer and/or Chrome 96+ causes a
// discrepancy in the paragraph height.
const
bool
hasIssue99933
=
kIsWeb
&&
!
bool
.
fromEnvironment
(
'FLUTTER_WEB_USE_SKIA'
);
expect
(
tester
.
getSize
(
find
.
text
(
'The Title'
)),
equals
(
const
Size
(
270.0
,
hasIssue99933
?
133
:
132.0
)));
expect
(
tester
.
getSize
(
find
.
text
(
'The Title'
)),
equals
(
const
Size
(
270.0
,
132.0
)));
expect
(
tester
.
getTopLeft
(
find
.
text
(
'The Title'
)),
equals
(
const
Offset
(
265.0
,
80.0
+
24.0
)));
expect
(
tester
.
getSize
(
find
.
widgetWithText
(
CupertinoDialogAction
,
'Cancel'
)),
equals
(
const
Size
(
310.0
,
148.0
)));
expect
(
tester
.
getSize
(
find
.
widgetWithText
(
CupertinoDialogAction
,
'OK'
)),
equals
(
const
Size
(
310.0
,
98.0
)));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment