Unverified Commit 0f365d3a authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

remove dart dir chrome profile (#39934)

parent 399bb04e
...@@ -79,11 +79,7 @@ class ChromeLauncher { ...@@ -79,11 +79,7 @@ class ChromeLauncher {
/// `skipCheck` does not attempt to make a devtools connection before returning. /// `skipCheck` does not attempt to make a devtools connection before returning.
Future<Chrome> launch(String url, { bool headless = false, bool skipCheck = false }) async { Future<Chrome> launch(String url, { bool headless = false, bool skipCheck = false }) async {
final String chromeExecutable = findChromeExecutable(); final String chromeExecutable = findChromeExecutable();
final Directory dataDir = fs.directory('.dart_tool') final Directory dataDir = fs.systemTempDirectory.createTempSync('flutter_tool_');
.childDirectory('chrome_profile');
if (!dataDir.existsSync()) {
dataDir.createSync(recursive: true);
}
final int port = await os.findFreePort(); final int port = await os.findFreePort();
final List<String> args = <String>[ final List<String> args = <String>[
chromeExecutable, chromeExecutable,
......
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
import 'dart:async'; import 'dart:async';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/os.dart'; import 'package:flutter_tools/src/base/os.dart';
import 'package:flutter_tools/src/base/platform.dart'; import 'package:flutter_tools/src/base/platform.dart';
import 'package:flutter_tools/src/base/process_manager.dart'; import 'package:flutter_tools/src/base/process_manager.dart';
...@@ -22,10 +23,12 @@ void main() { ...@@ -22,10 +23,12 @@ void main() {
setUp(() { setUp(() {
final MockPlatform platform = MockPlatform(); final MockPlatform platform = MockPlatform();
when(platform.isWindows).thenReturn(false); when(platform.isWindows).thenReturn(false);
final MockFileSystem mockFileSystem = MockFileSystem();
testbed = Testbed(overrides: <Type, Generator>{ testbed = Testbed(overrides: <Type, Generator>{
ProcessManager: () => MockProcessManager(), ProcessManager: () => MockProcessManager(),
Platform: () => platform, Platform: () => platform,
OperatingSystemUtils: () => MockOperatingSystemUtils(), OperatingSystemUtils: () => MockOperatingSystemUtils(),
FileSystem: () => mockFileSystem,
}); });
}); });
...@@ -36,9 +39,13 @@ void main() { ...@@ -36,9 +39,13 @@ void main() {
when(platform.environment).thenReturn(<String, String>{ when(platform.environment).thenReturn(<String, String>{
kChromeEnvironment: 'example_chrome' kChromeEnvironment: 'example_chrome'
}); });
final Directory mockDirectory = MockDirectory();
when(fs.systemTempDirectory).thenReturn(mockDirectory);
when(mockDirectory.createTempSync(any)).thenReturn(mockDirectory);
when(mockDirectory.path).thenReturn('example');
when(processManager.start(<String>[ when(processManager.start(<String>[
'example_chrome', 'example_chrome',
'--user-data-dir=.dart_tool/chrome_profile', '--user-data-dir=example',
'--remote-debugging-port=1234', '--remote-debugging-port=1234',
'--disable-background-timer-throttling', '--disable-background-timer-throttling',
'--disable-extensions', '--disable-extensions',
...@@ -66,3 +73,5 @@ void main() { ...@@ -66,3 +73,5 @@ void main() {
class MockProcessManager extends Mock implements ProcessManager {} class MockProcessManager extends Mock implements ProcessManager {}
class MockPlatform extends Mock implements Platform {} class MockPlatform extends Mock implements Platform {}
class MockOperatingSystemUtils extends Mock implements OperatingSystemUtils {} class MockOperatingSystemUtils extends Mock implements OperatingSystemUtils {}
class MockFileSystem extends Mock implements FileSystem {}
class MockDirectory extends Mock implements Directory {}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment