Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
0ec3ffb4
Commit
0ec3ffb4
authored
Mar 28, 2017
by
Yegor
Committed by
GitHub
Mar 28, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
increase total task timeout; decrease individual benchmark timeout (#9063)
parent
3ef99092
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
28 additions
and
20 deletions
+28
-20
framework.dart
dev/devicelab/lib/framework/framework.dart
+1
-1
runner.dart
dev/devicelab/lib/framework/runner.dart
+1
-1
microbenchmarks.dart
dev/devicelab/lib/tasks/microbenchmarks.dart
+26
-18
No files found.
dev/devicelab/lib/framework/framework.dart
View file @
0ec3ffb4
...
...
@@ -16,7 +16,7 @@ import 'utils.dart';
/// Maximum amount of time a single task is allowed to take to run.
///
/// If exceeded the task is considered to have failed.
const
Duration
taskTimeout
=
const
Duration
(
minutes:
10
);
const
Duration
taskTimeout
=
const
Duration
(
minutes:
25
);
/// Represents a unit of work performed in the CI environment that can
/// succeed, fail and be retried independently of others.
...
...
dev/devicelab/lib/framework/runner.dart
View file @
0ec3ffb4
...
...
@@ -12,7 +12,7 @@ import 'package:flutter_devicelab/framework/utils.dart';
/// Slightly longer than task timeout that gives the task runner a chance to
/// clean-up before forcefully quitting it.
const
Duration
taskTimeoutWithGracePeriod
=
const
Duration
(
minutes:
11
);
const
Duration
taskTimeoutWithGracePeriod
=
const
Duration
(
minutes:
26
);
/// Runs a task in a separate Dart VM and collects the result using the VM
/// service protocol.
...
...
dev/devicelab/lib/tasks/microbenchmarks.dart
View file @
0ec3ffb4
...
...
@@ -13,6 +13,9 @@ import 'package:flutter_devicelab/framework/framework.dart';
import
'package:flutter_devicelab/framework/ios.dart'
;
import
'package:flutter_devicelab/framework/utils.dart'
;
/// The maximum amount of time a single microbenchmarks is allowed to take.
const
Duration
_kBenchmarkTimeout
=
const
Duration
(
minutes:
6
);
/// Creates a device lab task that runs benchmarks in
/// `dev/benchmarks/microbenchmarks` reports results to the dashboard.
TaskFunction
createMicrobenchmarkTask
(
)
{
...
...
@@ -21,15 +24,18 @@ TaskFunction createMicrobenchmarkTask() {
await
device
.
unlock
();
Future
<
Map
<
String
,
double
>>
_runMicrobench
(
String
benchmarkPath
)
async
{
Future
<
Map
<
String
,
double
>>
_run
()
async
{
print
(
'Running
$benchmarkPath
'
);
final
Directory
appDir
=
dir
(
path
.
join
(
flutterDirectory
.
path
,
'dev/benchmarks/microbenchmarks'
));
final
Directory
appDir
=
dir
(
path
.
join
(
flutterDirectory
.
path
,
'dev/benchmarks/microbenchmarks'
));
final
Process
flutterProcess
=
await
inDirectory
(
appDir
,
()
async
{
if
(
deviceOperatingSystem
==
DeviceOperatingSystem
.
ios
)
{
await
prepareProvisioningCertificates
(
appDir
.
path
);
}
return
await
_startFlutter
(
options:
<
String
>[
'--profile'
,
// --release doesn't work on iOS due to code signing issues
'--profile'
,
// --release doesn't work on iOS due to code signing issues
'-d'
,
device
.
deviceId
,
benchmarkPath
,
...
...
@@ -40,6 +46,8 @@ TaskFunction createMicrobenchmarkTask() {
return
await
_readJsonResults
(
flutterProcess
);
}
return
_run
().
timeout
(
_kBenchmarkTimeout
);
}
final
Map
<
String
,
double
>
allResults
=
<
String
,
double
>{};
allResults
.
addAll
(
await
_runMicrobench
(
'lib/stocks/layout_bench.dart'
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment