Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
0d7270ba
Unverified
Commit
0d7270ba
authored
Nov 14, 2020
by
Casey Hillers
Committed by
GitHub
Nov 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "[devicelab] LUCI builder flag (#70464)" (#70496)
parent
97468963
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
15 deletions
+2
-15
run.dart
dev/devicelab/bin/run.dart
+2
-15
No files found.
dev/devicelab/bin/run.dart
View file @
0d7270ba
...
...
@@ -30,12 +30,6 @@ String localEngine;
/// The path to the engine "src/" directory.
String
localEngineSrcPath
;
/// Name of the LUCI builder this test is currently running on.
///
/// This is only passed on CI runs for Cocoon to be able to uniquely identify
/// this test run.
String
luciBuilder
;
/// Whether to exit on first test failure.
bool
exitOnFirstTestFailure
;
...
...
@@ -87,10 +81,9 @@ Future<void> main(List<String> rawArgs) async {
}
deviceId
=
args
[
'device-id'
]
as
String
;
exitOnFirstTestFailure
=
args
[
'exit'
]
as
bool
;
localEngine
=
args
[
'local-engine'
]
as
String
;
localEngineSrcPath
=
args
[
'local-engine-src-path'
]
as
String
;
luciBuilder
=
args
[
'luci-builder'
]
as
String
;
exitOnFirstTestFailure
=
args
[
'exit'
]
as
bool
;
serviceAccountTokenFile
=
args
[
'service-account-token-file'
]
as
String
;
silent
=
args
[
'silent'
]
as
bool
;
...
...
@@ -118,9 +111,7 @@ Future<void> _runTasks() async {
if
(
serviceAccountTokenFile
!=
null
)
{
final
Cocoon
cocoon
=
Cocoon
(
serviceAccountTokenPath:
serviceAccountTokenFile
);
/// Cocoon's definition of a task is more specific than [taskName], and to
/// upload we instead send the [luciBuilder] this is running on.
await
cocoon
.
sendTaskResult
(
taskName:
luciBuilder
,
result:
result
);
await
cocoon
.
sendTaskResult
(
taskName:
taskName
,
result:
result
);
}
if
(!
result
.
succeeded
)
{
...
...
@@ -347,10 +338,6 @@ final ArgParser _argParser = ArgParser()
'locally. Defaults to
\
$FLUTTER_ENGINE
if set, or tries to guess at
\n
'
'the location based on the value of the --flutter-root option.'
,
)
..
addOption
(
'luci-builder'
,
help:
'[Flutter infrastructure] Name of the LUCI builder being run on.'
)
..
addFlag
(
'match-host-platform'
,
defaultsTo:
true
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment