Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
0b6c1938
Unverified
Commit
0b6c1938
authored
Feb 22, 2018
by
Greg Spencer
Committed by
GitHub
Feb 22, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix gsutil argument order. (#14808)
parent
382ee4ba
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
5 deletions
+4
-5
prepare_package.dart
dev/bots/prepare_package.dart
+2
-3
prepare_package_test.dart
dev/bots/test/prepare_package_test.dart
+2
-2
No files found.
dev/bots/prepare_package.dart
View file @
0b6c1938
...
...
@@ -487,14 +487,13 @@ class ArchivePublisher {
if
(
dest
.
endsWith
(
'.json'
))
{
mimeType
=
'application/json'
;
}
final
List
<
String
>
args
=
<
String
>[
'cp'
];
final
List
<
String
>
args
=
<
String
>[];
// Use our preferred MIME type for the files we care about
// and let gsutil figure it out for anything else.
if
(
mimeType
!=
null
)
{
args
.
addAll
(<
String
>[
'-h'
,
'Content-Type:
$mimeType
'
]);
}
args
.
add
(
src
);
args
.
add
(
dest
);
args
.
addAll
(<
String
>[
'cp'
,
src
,
dest
]);
return
_runGsUtil
(
args
);
}
}
...
...
dev/bots/test/prepare_package_test.dart
View file @
0b6c1938
...
...
@@ -239,10 +239,10 @@ void main() {
'''
;
final
Map
<
String
,
List
<
ProcessResult
>>
calls
=
<
String
,
List
<
ProcessResult
>>{
'gsutil rm
$gsArchivePath
'
:
null
,
'gsutil
cp -h Content-Type:
$archiveMime
$archivePath
$gsArchivePath
'
:
null
,
'gsutil
-h Content-Type:
$archiveMime
cp
$archivePath
$gsArchivePath
'
:
null
,
'gsutil cat
$gsJsonPath
'
:
<
ProcessResult
>[
new
ProcessResult
(
0
,
0
,
releasesJson
,
''
)],
'gsutil rm
$gsJsonPath
'
:
null
,
'gsutil
cp -h Content-Type:application/json
$jsonPath
$gsJsonPath
'
:
null
,
'gsutil
-h Content-Type:application/json cp
$jsonPath
$gsJsonPath
'
:
null
,
};
processManager
.
fakeResults
=
calls
;
final
File
outputFile
=
new
File
(
path
.
join
(
tempDir
.
absolute
.
path
,
archiveName
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment