Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
099f1162
Unverified
Commit
099f1162
authored
May 08, 2021
by
Jia Hao
Committed by
GitHub
May 08, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[integration_test] Don't log exceptions twice (#81812)
parent
783e1dd2
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
27 additions
and
8 deletions
+27
-8
exception_handling_expectation.txt
...tests/integration_test/exception_handling_expectation.txt
+12
-8
integration_test.dart
packages/integration_test/lib/integration_test.dart
+15
-0
No files found.
dev/automated_tests/integration_test/exception_handling_expectation.txt
View file @
099f1162
...
...
@@ -8,8 +8,9 @@ When the exception was thrown, this was the stack:
<<skip until matching line>>
The test description was:
Exception handling in test harness - string
<<skip until matching line>>
Test failed\. See exception logs above\.
════════════════════════════════════════════════════════════════════════════════════════════════════
\d\d:\d\d \+0 -1: Exception handling in test harness - string \[E\]
Test failed. See exception logs above.
The test description was: Exception handling in test harness - string
<<skip until matching line>>
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
...
...
@@ -20,9 +21,10 @@ When the exception was thrown, this was the stack:
#0 main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]integration_test[/\\]exception_handling_test\.dart:13:5\)
<<skip until matching line>>
The test description was:
Exception handling in test harness - FlutterError
<<skip until matching line>>
Test failed\. See exception logs above\.
Exception handling in test harness - FlutterError
════════════════════════════════════════════════════════════════════════════════════════════════════
\d\d:\d\d \+0 -2: Exception handling in test harness - FlutterError \[E\]
Test failed. See exception logs above.
The test description was: Exception handling in test harness - FlutterError
<<skip until matching line>>
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
...
...
@@ -33,9 +35,11 @@ When the exception was thrown, this was the stack:
#2 main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]integration_test[/\\]exception_handling_test\.dart:16:5\)
<<skip until matching line>>
The test description was:
Exception handling in test harness - uncaught Future error
<<skip until matching line>>
Test failed\. See exception logs above\.
Exception handling in test harness - uncaught Future error
════════════════════════════════════════════════════════════════════════════════════════════════════
\d\d:\d\d \+0 -3: Exception handling in test harness - uncaught Future error \[E\]
Test failed. See exception logs above.
The test description was: Exception handling in test harness - uncaught Future error
.*(TODO\(jiahaog\): Remove the next line once https://github.com/flutter/flutter/issues/81521 is fixed)?
<<skip until matching line>>
.*..:.. \+0 -3: Some tests failed\. *
packages/integration_test/lib/integration_test.dart
View file @
099f1162
...
...
@@ -365,4 +365,19 @@ https://flutter.dev/docs/testing/integration-tests#testing-on-firebase-test-lab
// TODO(jiahaog): Remove when https://github.com/flutter/flutter/issues/66006 is fixed.
super
.
attachRootWidget
(
RepaintBoundary
(
child:
rootWidget
));
}
@override
void
reportExceptionNoticed
(
FlutterErrorDetails
exception
)
{
// This method is called to log errors as they happen, and they will also
// be eventually logged again at the end of the tests. The superclass
// behavior is specific to the "live" execution semantics of
// [LiveTestWidgetsFlutterBinding] so users don't have to wait until tests
// finish to see the stack traces.
//
// Disable this because Integration Tests follow the semantics of
// [AutomatedTestWidgetsFlutterBinding] that does not log the stack traces
// live, and avoids the doubly logged stack trace.
// TODO(jiahaog): Integration test binding should not inherit from
// `LiveTestWidgetsFlutterBinding` https://github.com/flutter/flutter/issues/81534
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment