Unverified Commit 07de84f0 authored by Greg Spencer's avatar Greg Spencer Committed by GitHub

Add StarBorder and StarBorder.polygon, with example. (#108489)

parent e79e6d72
...@@ -412,7 +412,7 @@ Future<void> verifyGoldenTags(String workingDirectory, { int minimumMatches = 20 ...@@ -412,7 +412,7 @@ Future<void> verifyGoldenTags(String workingDirectory, { int minimumMatches = 20
if (needsTag) { if (needsTag) {
if (!hasTagNotation) { if (!hasTagNotation) {
errors.add('${file.path}: Files containing golden tests must be tagged using ' errors.add('${file.path}: Files containing golden tests must be tagged using '
'`@Tags(...)` at the top of the file before import statements.'); "@Tags(<String>['reduced-test-set']) at the top of the file before import statements.");
} else if (!hasReducedTag) { } else if (!hasReducedTag) {
errors.add('${file.path}: Files containing golden tests must be tagged with ' errors.add('${file.path}: Files containing golden tests must be tagged with '
"'reduced-test-set'."); "'reduced-test-set'.");
......
...@@ -74,10 +74,9 @@ void main() { ...@@ -74,10 +74,9 @@ void main() {
test('analyze.dart - verifyGoldenTags', () async { test('analyze.dart - verifyGoldenTags', () async {
final String result = await capture(() => verifyGoldenTags(testRootPath, minimumMatches: 6), exitCode: 1); final String result = await capture(() => verifyGoldenTags(testRootPath, minimumMatches: 6), exitCode: 1);
const String noTag = 'Files containing golden tests must be ' const String noTag = "Files containing golden tests must be tagged using @Tags(<String>['reduced-test-set']) "
'tagged using `@Tags(...)` at the top of the file before import statements.'; 'at the top of the file before import statements.';
const String missingTag = 'Files containing golden tests must be ' const String missingTag = "Files containing golden tests must be tagged with 'reduced-test-set'.";
"tagged with 'reduced-test-set'.";
String lines = <String>[ String lines = <String>[
'test/analyze-test-input/root/packages/foo/golden_missing_tag.dart: $missingTag', 'test/analyze-test-input/root/packages/foo/golden_missing_tag.dart: $missingTag',
'test/analyze-test-input/root/packages/foo/golden_no_tag.dart: $noTag', 'test/analyze-test-input/root/packages/foo/golden_no_tag.dart: $noTag',
......
This diff is collapsed.
This diff is collapsed.
...@@ -56,6 +56,7 @@ export 'src/painting/rounded_rectangle_border.dart'; ...@@ -56,6 +56,7 @@ export 'src/painting/rounded_rectangle_border.dart';
export 'src/painting/shader_warm_up.dart'; export 'src/painting/shader_warm_up.dart';
export 'src/painting/shape_decoration.dart'; export 'src/painting/shape_decoration.dart';
export 'src/painting/stadium_border.dart'; export 'src/painting/stadium_border.dart';
export 'src/painting/star_border.dart';
export 'src/painting/strut_style.dart'; export 'src/painting/strut_style.dart';
export 'src/painting/text_painter.dart'; export 'src/painting/text_painter.dart';
export 'src/painting/text_span.dart'; export 'src/painting/text_span.dart';
......
...@@ -144,7 +144,8 @@ class Slider extends StatefulWidget { ...@@ -144,7 +144,8 @@ class Slider extends StatefulWidget {
assert(min != null), assert(min != null),
assert(max != null), assert(max != null),
assert(min <= max), assert(min <= max),
assert(value >= min && value <= max), assert(value >= min && value <= max,
'Value $value is not between minimum $min and maximum $max'),
assert(divisions == null || divisions > 0); assert(divisions == null || divisions > 0);
/// Creates an adaptive [Slider] based on the target platform, following /// Creates an adaptive [Slider] based on the target platform, following
......
This diff is collapsed.
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment