Unverified Commit 071ea492 authored by Loïc Sharma's avatar Loïc Sharma Committed by GitHub

[Windows] Address feedback for show window comment (#127998)

Address Tong's feedback here: https://github.com/flutter/flutter/issues/127695#issuecomment-1564884872

Follow-up to: https://github.com/flutter/flutter/pull/127046
parent bf17c9ea
...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() { ...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() { ...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -64,8 +64,8 @@ bool FlutterWindow::OnCreate() { ...@@ -64,8 +64,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
// Create a method channel to check the window's visibility. // Create a method channel to check the window's visibility.
......
...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() { ...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() { ...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() { ...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() { ...@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -99,8 +99,8 @@ bool FlutterWindow::OnCreate() { ...@@ -99,8 +99,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -20,8 +20,8 @@ const String _after = r''' ...@@ -20,8 +20,8 @@ const String _after = r'''
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -32,8 +32,8 @@ bool FlutterWindow::OnCreate() { ...@@ -32,8 +32,8 @@ bool FlutterWindow::OnCreate() {
}); });
// Flutter can complete the first frame before the "show window" callback is // Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown. // registered. The following call ensures a frame is pending to ensure the
// This no-ops if the first frame hasn't completed yet. // window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw(); flutter_controller_->ForceRedraw();
return true; return true;
......
...@@ -75,8 +75,8 @@ void main () { ...@@ -75,8 +75,8 @@ void main () {
' });\n' ' });\n'
'\n' '\n'
' // Flutter can complete the first frame before the "show window" callback is\n' ' // Flutter can complete the first frame before the "show window" callback is\n'
' // registered. Ensure a frame is pending to ensure the window is shown.\n' ' // registered. The following call ensures a frame is pending to ensure the\n'
" // This no-ops if the first frame hasn't completed yet.\n" " // window is shown. It is a no-op if the first frame hasn't completed yet.\n"
' flutter_controller_->ForceRedraw();\n' ' flutter_controller_->ForceRedraw();\n'
'\n' '\n'
' return true;\n'; ' return true;\n';
...@@ -103,8 +103,8 @@ void main () { ...@@ -103,8 +103,8 @@ void main () {
' });\r\n' ' });\r\n'
'\r\n' '\r\n'
' // Flutter can complete the first frame before the "show window" callback is\r\n' ' // Flutter can complete the first frame before the "show window" callback is\r\n'
' // registered. Ensure a frame is pending to ensure the window is shown.\r\n' ' // registered. The following call ensures a frame is pending to ensure the\r\n'
" // This no-ops if the first frame hasn't completed yet.\r\n" " // window is shown. It is a no-op if the first frame hasn't completed yet.\r\n"
' flutter_controller_->ForceRedraw();\r\n' ' flutter_controller_->ForceRedraw();\r\n'
'\r\n' '\r\n'
' return true;\r\n'; ' return true;\r\n';
...@@ -145,8 +145,8 @@ void main () { ...@@ -145,8 +145,8 @@ void main () {
' });\n' ' });\n'
'\n' '\n'
' // Flutter can complete the first frame before the "show window" callback is\n' ' // Flutter can complete the first frame before the "show window" callback is\n'
' // registered. Ensure a frame is pending to ensure the window is shown.\n' ' // registered. The following call ensures a frame is pending to ensure the\n'
" // This no-ops if the first frame hasn't completed yet.\n" " // window is shown. It is a no-op if the first frame hasn't completed yet.\n"
' flutter_controller_->ForceRedraw();\n' ' flutter_controller_->ForceRedraw();\n'
'\n' '\n'
' return true;\n' ' return true;\n'
...@@ -176,8 +176,8 @@ void main () { ...@@ -176,8 +176,8 @@ void main () {
' });\r\n' ' });\r\n'
'\r\n' '\r\n'
' // Flutter can complete the first frame before the "show window" callback is\r\n' ' // Flutter can complete the first frame before the "show window" callback is\r\n'
' // registered. Ensure a frame is pending to ensure the window is shown.\r\n' ' // registered. The following call ensures a frame is pending to ensure the\r\n'
" // This no-ops if the first frame hasn't completed yet.\r\n" " // window is shown. It is a no-op if the first frame hasn't completed yet.\r\n"
' flutter_controller_->ForceRedraw();\r\n' ' flutter_controller_->ForceRedraw();\r\n'
'\r\n' '\r\n'
' return true;\r\n' ' return true;\r\n'
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment