Unverified Commit 06ed8e65 authored by Michael Goderbauer's avatar Michael Goderbauer Committed by GitHub

Enable prefer_mixin (#123159)

Enable prefer_mixin
parent e15c9285
...@@ -173,7 +173,7 @@ linter: ...@@ -173,7 +173,7 @@ linter:
- prefer_is_not_empty - prefer_is_not_empty
- prefer_is_not_operator - prefer_is_not_operator
- prefer_iterable_whereType - prefer_iterable_whereType
# - prefer_mixin # has false positives, see https://github.com/dart-lang/linter/issues/3018 - prefer_mixin
# - prefer_null_aware_method_calls # "call()" is confusing to people new to the language since it's not documented anywhere # - prefer_null_aware_method_calls # "call()" is confusing to people new to the language since it's not documented anywhere
- prefer_null_aware_operators - prefer_null_aware_operators
- prefer_relative_imports - prefer_relative_imports
......
...@@ -156,7 +156,8 @@ class ErrorHandlingFileSystem extends ForwardingFileSystem { ...@@ -156,7 +156,8 @@ class ErrorHandlingFileSystem extends ForwardingFileSystem {
class ErrorHandlingFile class ErrorHandlingFile
extends ForwardingFileSystemEntity<File, io.File> extends ForwardingFileSystemEntity<File, io.File>
with ForwardingFile { // TODO(goderbauer): Fix this ignore when https://github.com/google/file.dart/issues/209 is resolved.
with ForwardingFile { // ignore: prefer_mixin
ErrorHandlingFile({ ErrorHandlingFile({
required Platform platform, required Platform platform,
required this.fileSystem, required this.fileSystem,
...@@ -368,7 +369,8 @@ class ErrorHandlingFile ...@@ -368,7 +369,8 @@ class ErrorHandlingFile
class ErrorHandlingDirectory class ErrorHandlingDirectory
extends ForwardingFileSystemEntity<Directory, io.Directory> extends ForwardingFileSystemEntity<Directory, io.Directory>
with ForwardingDirectory<Directory> { // TODO(goderbauer): Fix this ignore when https://github.com/google/file.dart/issues/209 is resolved.
with ForwardingDirectory<Directory> { // ignore: prefer_mixin
ErrorHandlingDirectory({ ErrorHandlingDirectory({
required Platform platform, required Platform platform,
required this.fileSystem, required this.fileSystem,
...@@ -504,7 +506,8 @@ class ErrorHandlingDirectory ...@@ -504,7 +506,8 @@ class ErrorHandlingDirectory
class ErrorHandlingLink class ErrorHandlingLink
extends ForwardingFileSystemEntity<Link, io.Link> extends ForwardingFileSystemEntity<Link, io.Link>
with ForwardingLink { // TODO(goderbauer): Fix this ignore when https://github.com/google/file.dart/issues/209 is resolved.
with ForwardingLink { // ignore: prefer_mixin
ErrorHandlingLink({ ErrorHandlingLink({
required Platform platform, required Platform platform,
required this.fileSystem, required this.fileSystem,
......
...@@ -209,7 +209,8 @@ abstract class MultiRootFileSystemEntity<T extends FileSystemEntity, ...@@ -209,7 +209,8 @@ abstract class MultiRootFileSystemEntity<T extends FileSystemEntity,
} }
class MultiRootFile extends MultiRootFileSystemEntity<File, io.File> class MultiRootFile extends MultiRootFileSystemEntity<File, io.File>
with ForwardingFile { // TODO(goderbauer): Fix this ignore when https://github.com/google/file.dart/issues/209 is resolved.
with ForwardingFile { // ignore: prefer_mixin
MultiRootFile({ MultiRootFile({
required super.fileSystem, required super.fileSystem,
required super.delegate, required super.delegate,
...@@ -222,7 +223,8 @@ class MultiRootFile extends MultiRootFileSystemEntity<File, io.File> ...@@ -222,7 +223,8 @@ class MultiRootFile extends MultiRootFileSystemEntity<File, io.File>
class MultiRootDirectory class MultiRootDirectory
extends MultiRootFileSystemEntity<Directory, io.Directory> extends MultiRootFileSystemEntity<Directory, io.Directory>
with ForwardingDirectory<Directory> { // TODO(goderbauer): Fix this ignore when https://github.com/google/file.dart/issues/209 is resolved.
with ForwardingDirectory<Directory> { // ignore: prefer_mixin
MultiRootDirectory({ MultiRootDirectory({
required super.fileSystem, required super.fileSystem,
required super.delegate, required super.delegate,
...@@ -249,7 +251,8 @@ class MultiRootDirectory ...@@ -249,7 +251,8 @@ class MultiRootDirectory
} }
class MultiRootLink extends MultiRootFileSystemEntity<Link, io.Link> class MultiRootLink extends MultiRootFileSystemEntity<Link, io.Link>
with ForwardingLink { // TODO(goderbauer): Fix this ignore when https://github.com/google/file.dart/issues/209 is resolved.
with ForwardingLink { // ignore: prefer_mixin
MultiRootLink({ MultiRootLink({
required super.fileSystem, required super.fileSystem,
required super.delegate, required super.delegate,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment