Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
06e1f8fc
Unverified
Commit
06e1f8fc
authored
Apr 25, 2019
by
Dan Field
Committed by
GitHub
Apr 25, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06 (#31569)
* Manual roll with updated test
parent
0ba67226
Changes
7
Show whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
13 additions
and
8 deletions
+13
-8
analysis_options.yaml
analysis_options.yaml
+2
-1
engine.version
bin/internal/engine.version
+1
-1
goldens.version
bin/internal/goldens.version
+1
-1
semantics_traversal_test.dart
packages/flutter/test/widgets/semantics_traversal_test.dart
+5
-2
widget_inspector_test.dart
packages/flutter/test/widgets/widget_inspector_test.dart
+1
-1
accessibility.dart
packages/flutter_test/lib/src/accessibility.dart
+2
-1
matchers_test.dart
packages/flutter_test/test/matchers_test.dart
+1
-1
No files found.
analysis_options.yaml
View file @
06e1f8fc
...
...
@@ -122,7 +122,8 @@ linter:
-
prefer_asserts_in_initializer_lists
-
prefer_collection_literals
-
prefer_conditional_assignment
-
prefer_const_constructors
# TODO(dnfield) - re-enable this when custom embedders catch up with the Rect/RRect constness.
# - prefer_const_constructors
-
prefer_const_constructors_in_immutables
-
prefer_const_declarations
-
prefer_const_literals_to_create_immutables
...
...
bin/internal/engine.version
View file @
06e1f8fc
c63d1cf9c9ba8c7d8546f24c1248433bdf827153
3e47b4bb39bb4993f03a278ea7b1c11ee6459b06
bin/internal/goldens.version
View file @
06e1f8fc
78dfbee0485dbe335edb37899839ac32d219edc1
09ebc5361187e9cc20ddc350dc047f95812c61a4
packages/flutter/test/widgets/semantics_traversal_test.dart
View file @
06e1f8fc
...
...
@@ -251,8 +251,11 @@ void main() {
for
(
int
i
=
0
;
i
<
8
;
i
+=
1
)
{
final
double
angle
=
start
+
i
.
toDouble
()
*
math
.
pi
/
4.0
;
final
double
dx
=
math
.
cos
(
angle
)
*
5.0
;
final
double
dy
=
math
.
sin
(
angle
)
*
5.0
;
// These values should be truncated so that double precision rounding
// issues won't impact the heights/widths and throw off the traversal
// ordering.
final
double
dx
=
(
math
.
cos
(
angle
)
*
15.0
)
/
10.0
;
final
double
dy
=
(
math
.
sin
(
angle
)
*
15.0
)
/
10.0
;
final
Map
<
String
,
Rect
>
children
=
<
String
,
Rect
>{
'A'
:
const
Offset
(
10.0
,
10.0
)
&
tenByTen
,
...
...
packages/flutter/test/widgets/widget_inspector_test.dart
View file @
06e1f8fc
...
...
@@ -2066,7 +2066,7 @@ class TestWidgetInspectorService extends Object with WidgetInspectorService {
height:
300.0
,
debugPaint:
true
,
),
matchesGoldenFile
(
'inspector.sizedBox_debugPaint.png'
),
matchesGoldenFile
(
'inspector.sizedBox_debugPaint.
1.
png'
),
skip:
!
Platform
.
isLinux
,
);
...
...
packages/flutter_test/lib/src/accessibility.dart
View file @
06e1f8fc
...
...
@@ -113,10 +113,11 @@ class MinimumTapTargetGuideline extends AccessibilityGuideline {
return
result
;
// shrink by device pixel ratio.
final
Size
candidateSize
=
paintBounds
.
size
/
tester
.
binding
.
window
.
devicePixelRatio
;
if
(
candidateSize
.
width
<
size
.
width
||
candidateSize
.
height
<
size
.
height
)
if
(
candidateSize
.
width
<
size
.
width
-
delta
||
candidateSize
.
height
<
size
.
height
-
delta
)
{
result
+=
Evaluation
.
fail
(
'
$node
: expected tap target size of at least
$size
, but found
$candidateSize
\n
'
'See also:
$link
'
);
}
return
result
;
}
return
traverse
(
root
);
...
...
packages/flutter_test/test/matchers_test.dart
View file @
06e1f8fc
...
...
@@ -188,7 +188,7 @@ void main() {
test
(
'rectMoreOrLessEquals'
,
()
{
expect
(
Rect
.
fromLTRB
(
0.0
,
0.0
,
10.0
,
10.0
),
rectMoreOrLessEquals
(
Rect
.
fromLTRB
(
1
e
-
11
,
0.0
,
10.0
,
10.
0000000001
)),
rectMoreOrLessEquals
(
Rect
.
fromLTRB
(
0.0
,
0.0
,
10.0
,
10.0
0000000001
)),
);
expect
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment