Unverified Commit 06e1f8fc authored by Dan Field's avatar Dan Field Committed by GitHub

Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06 (#31569)

* Manual roll with updated test
parent 0ba67226
...@@ -122,7 +122,8 @@ linter: ...@@ -122,7 +122,8 @@ linter:
- prefer_asserts_in_initializer_lists - prefer_asserts_in_initializer_lists
- prefer_collection_literals - prefer_collection_literals
- prefer_conditional_assignment - prefer_conditional_assignment
- prefer_const_constructors # TODO(dnfield) - re-enable this when custom embedders catch up with the Rect/RRect constness.
# - prefer_const_constructors
- prefer_const_constructors_in_immutables - prefer_const_constructors_in_immutables
- prefer_const_declarations - prefer_const_declarations
- prefer_const_literals_to_create_immutables - prefer_const_literals_to_create_immutables
......
c63d1cf9c9ba8c7d8546f24c1248433bdf827153 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06
78dfbee0485dbe335edb37899839ac32d219edc1 09ebc5361187e9cc20ddc350dc047f95812c61a4
...@@ -251,8 +251,11 @@ void main() { ...@@ -251,8 +251,11 @@ void main() {
for (int i = 0; i < 8; i += 1) { for (int i = 0; i < 8; i += 1) {
final double angle = start + i.toDouble() * math.pi / 4.0; final double angle = start + i.toDouble() * math.pi / 4.0;
final double dx = math.cos(angle) * 5.0; // These values should be truncated so that double precision rounding
final double dy = math.sin(angle) * 5.0; // issues won't impact the heights/widths and throw off the traversal
// ordering.
final double dx = (math.cos(angle) * 15.0) / 10.0;
final double dy = (math.sin(angle) * 15.0) / 10.0;
final Map<String, Rect> children = <String, Rect>{ final Map<String, Rect> children = <String, Rect>{
'A': const Offset(10.0, 10.0) & tenByTen, 'A': const Offset(10.0, 10.0) & tenByTen,
......
...@@ -2066,7 +2066,7 @@ class TestWidgetInspectorService extends Object with WidgetInspectorService { ...@@ -2066,7 +2066,7 @@ class TestWidgetInspectorService extends Object with WidgetInspectorService {
height: 300.0, height: 300.0,
debugPaint: true, debugPaint: true,
), ),
matchesGoldenFile('inspector.sizedBox_debugPaint.png'), matchesGoldenFile('inspector.sizedBox_debugPaint.1.png'),
skip: !Platform.isLinux, skip: !Platform.isLinux,
); );
......
...@@ -113,10 +113,11 @@ class MinimumTapTargetGuideline extends AccessibilityGuideline { ...@@ -113,10 +113,11 @@ class MinimumTapTargetGuideline extends AccessibilityGuideline {
return result; return result;
// shrink by device pixel ratio. // shrink by device pixel ratio.
final Size candidateSize = paintBounds.size / tester.binding.window.devicePixelRatio; final Size candidateSize = paintBounds.size / tester.binding.window.devicePixelRatio;
if (candidateSize.width < size.width || candidateSize.height < size.height) if (candidateSize.width < size.width - delta || candidateSize.height < size.height - delta) {
result += Evaluation.fail( result += Evaluation.fail(
'$node: expected tap target size of at least $size, but found $candidateSize\n' '$node: expected tap target size of at least $size, but found $candidateSize\n'
'See also: $link'); 'See also: $link');
}
return result; return result;
} }
return traverse(root); return traverse(root);
......
...@@ -188,7 +188,7 @@ void main() { ...@@ -188,7 +188,7 @@ void main() {
test('rectMoreOrLessEquals', () { test('rectMoreOrLessEquals', () {
expect( expect(
Rect.fromLTRB(0.0, 0.0, 10.0, 10.0), Rect.fromLTRB(0.0, 0.0, 10.0, 10.0),
rectMoreOrLessEquals(Rect.fromLTRB(1e-11, 0.0, 10.0, 10.0000000001)), rectMoreOrLessEquals(Rect.fromLTRB(0.0, 0.0, 10.0, 10.00000000001)),
); );
expect( expect(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment