Unverified Commit 06515fe0 authored by Konstantin Scheglov's avatar Konstantin Scheglov Committed by GitHub

Ignore in _Location (#96553)

parent e912b91c
...@@ -10,7 +10,6 @@ import '../../gallery/demo.dart'; ...@@ -10,7 +10,6 @@ import '../../gallery/demo.dart';
class _InputDropdown extends StatelessWidget { class _InputDropdown extends StatelessWidget {
const _InputDropdown({ const _InputDropdown({
Key? key, Key? key,
this.child,
this.labelText, this.labelText,
this.valueText, this.valueText,
this.valueStyle, this.valueStyle,
...@@ -21,7 +20,6 @@ class _InputDropdown extends StatelessWidget { ...@@ -21,7 +20,6 @@ class _InputDropdown extends StatelessWidget {
final String? valueText; final String? valueText;
final TextStyle? valueStyle; final TextStyle? valueStyle;
final VoidCallback? onPressed; final VoidCallback? onPressed;
final Widget? child;
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
......
...@@ -245,7 +245,6 @@ class _CupertinoDesktopTextSelectionToolbar extends StatelessWidget { ...@@ -245,7 +245,6 @@ class _CupertinoDesktopTextSelectionToolbar extends StatelessWidget {
Key? key, Key? key,
required this.anchor, required this.anchor,
required this.children, required this.children,
this.toolbarBuilder = _defaultToolbarBuilder,
}) : assert(children.length > 0), }) : assert(children.length > 0),
super(key: key); super(key: key);
...@@ -260,12 +259,6 @@ class _CupertinoDesktopTextSelectionToolbar extends StatelessWidget { ...@@ -260,12 +259,6 @@ class _CupertinoDesktopTextSelectionToolbar extends StatelessWidget {
/// Mac-style text selection toolbar text button. /// Mac-style text selection toolbar text button.
final List<Widget> children; final List<Widget> children;
/// {@macro flutter.material.TextSelectionToolbar.toolbarBuilder}
///
/// The given anchor and isAbove can be used to position an arrow, as in the
/// default Cupertino toolbar.
final ToolbarBuilder toolbarBuilder;
// Builds a toolbar just like the default Mac toolbar, with the right color // Builds a toolbar just like the default Mac toolbar, with the right color
// background, padding, and rounded corners. // background, padding, and rounded corners.
static Widget _defaultToolbarBuilder(BuildContext context, Widget child) { static Widget _defaultToolbarBuilder(BuildContext context, Widget child) {
...@@ -308,7 +301,7 @@ class _CupertinoDesktopTextSelectionToolbar extends StatelessWidget { ...@@ -308,7 +301,7 @@ class _CupertinoDesktopTextSelectionToolbar extends StatelessWidget {
delegate: DesktopTextSelectionToolbarLayoutDelegate( delegate: DesktopTextSelectionToolbarLayoutDelegate(
anchor: anchor - localAdjustment, anchor: anchor - localAdjustment,
), ),
child: toolbarBuilder(context, Column( child: _defaultToolbarBuilder(context, Column(
mainAxisSize: MainAxisSize.min, mainAxisSize: MainAxisSize.min,
children: children, children: children,
)), )),
......
...@@ -1675,11 +1675,7 @@ class _ActionButtonParentDataWidget ...@@ -1675,11 +1675,7 @@ class _ActionButtonParentDataWidget
// ParentData applied to individual action buttons that report whether or not // ParentData applied to individual action buttons that report whether or not
// that button is currently pressed by the user. // that button is currently pressed by the user.
class _ActionButtonParentData extends MultiChildLayoutParentData { class _ActionButtonParentData extends MultiChildLayoutParentData {
_ActionButtonParentData({ bool isPressed = false;
this.isPressed = false,
});
bool isPressed;
} }
/// A button typically used in a [CupertinoAlertDialog]. /// A button typically used in a [CupertinoAlertDialog].
......
...@@ -236,7 +236,6 @@ class _DesktopTextSelectionToolbar extends StatelessWidget { ...@@ -236,7 +236,6 @@ class _DesktopTextSelectionToolbar extends StatelessWidget {
Key? key, Key? key,
required this.anchor, required this.anchor,
required this.children, required this.children,
this.toolbarBuilder = _defaultToolbarBuilder,
}) : assert(children.length > 0), }) : assert(children.length > 0),
super(key: key); super(key: key);
...@@ -251,12 +250,6 @@ class _DesktopTextSelectionToolbar extends StatelessWidget { ...@@ -251,12 +250,6 @@ class _DesktopTextSelectionToolbar extends StatelessWidget {
/// Material-style desktop text selection toolbar text button. /// Material-style desktop text selection toolbar text button.
final List<Widget> children; final List<Widget> children;
/// {@macro flutter.material.TextSelectionToolbar.toolbarBuilder}
///
/// The given anchor and isAbove can be used to position an arrow, as in the
/// default toolbar.
final ToolbarBuilder toolbarBuilder;
// Builds a desktop toolbar in the Material style. // Builds a desktop toolbar in the Material style.
static Widget _defaultToolbarBuilder(BuildContext context, Widget child) { static Widget _defaultToolbarBuilder(BuildContext context, Widget child) {
return SizedBox( return SizedBox(
...@@ -290,7 +283,7 @@ class _DesktopTextSelectionToolbar extends StatelessWidget { ...@@ -290,7 +283,7 @@ class _DesktopTextSelectionToolbar extends StatelessWidget {
delegate: DesktopTextSelectionToolbarLayoutDelegate( delegate: DesktopTextSelectionToolbarLayoutDelegate(
anchor: anchor - localAdjustment, anchor: anchor - localAdjustment,
), ),
child: toolbarBuilder(context, Column( child: _defaultToolbarBuilder(context, Column(
mainAxisSize: MainAxisSize.min, mainAxisSize: MainAxisSize.min,
children: children, children: children,
)), )),
......
...@@ -145,7 +145,6 @@ class _BorderContainer extends StatefulWidget { ...@@ -145,7 +145,6 @@ class _BorderContainer extends StatefulWidget {
required this.fillColor, required this.fillColor,
required this.hoverColor, required this.hoverColor,
required this.isHovering, required this.isHovering,
this.child,
}) : assert(border != null), }) : assert(border != null),
assert(gap != null), assert(gap != null),
assert(fillColor != null), assert(fillColor != null),
...@@ -157,7 +156,6 @@ class _BorderContainer extends StatefulWidget { ...@@ -157,7 +156,6 @@ class _BorderContainer extends StatefulWidget {
final Color fillColor; final Color fillColor;
final Color hoverColor; final Color hoverColor;
final bool isHovering; final bool isHovering;
final Widget? child;
@override @override
_BorderContainerState createState() => _BorderContainerState(); _BorderContainerState createState() => _BorderContainerState();
...@@ -249,7 +247,6 @@ class _BorderContainerState extends State<_BorderContainer> with TickerProviderS ...@@ -249,7 +247,6 @@ class _BorderContainerState extends State<_BorderContainer> with TickerProviderS
hoverColorTween: _hoverColorTween, hoverColorTween: _hoverColorTween,
hoverAnimation: _hoverAnimation, hoverAnimation: _hoverAnimation,
), ),
child: widget.child,
); );
} }
} }
......
...@@ -151,14 +151,13 @@ class _AnimationTuple { ...@@ -151,14 +151,13 @@ class _AnimationTuple {
required this.startAnimation, required this.startAnimation,
required this.endAnimation, required this.endAnimation,
required this.gapAnimation, required this.gapAnimation,
this.gapStart = 0.0,
}); });
final AnimationController controller; final AnimationController controller;
final CurvedAnimation startAnimation; final CurvedAnimation startAnimation;
final CurvedAnimation endAnimation; final CurvedAnimation endAnimation;
final CurvedAnimation gapAnimation; final CurvedAnimation gapAnimation;
double gapStart; double gapStart = 0.0;
} }
class _MergeableMaterialState extends State<MergeableMaterial> with TickerProviderStateMixin { class _MergeableMaterialState extends State<MergeableMaterial> with TickerProviderStateMixin {
......
...@@ -898,18 +898,10 @@ class _ClampTextScaleFactor extends StatelessWidget { ...@@ -898,18 +898,10 @@ class _ClampTextScaleFactor extends StatelessWidget {
/// surrounding [child]. /// surrounding [child].
const _ClampTextScaleFactor({ const _ClampTextScaleFactor({
Key? key, Key? key,
this.lowerLimit = 0,
this.upperLimit = double.infinity, this.upperLimit = double.infinity,
required this.child, required this.child,
}) : super(key: key); }) : super(key: key);
/// The minimum amount that the text scale factor should be for the [child]
/// widget.
///
/// If this is `.5`, the textScaleFactor for child widgets will never be
/// smaller than `.5`.
final double lowerLimit;
/// The maximum amount that the text scale factor should be for the [child] /// The maximum amount that the text scale factor should be for the [child]
/// widget. /// widget.
/// ///
...@@ -926,7 +918,7 @@ class _ClampTextScaleFactor extends StatelessWidget { ...@@ -926,7 +918,7 @@ class _ClampTextScaleFactor extends StatelessWidget {
return MediaQuery( return MediaQuery(
data: MediaQuery.of(context).copyWith( data: MediaQuery.of(context).copyWith(
textScaleFactor: MediaQuery.of(context).textScaleFactor.clamp( textScaleFactor: MediaQuery.of(context).textScaleFactor.clamp(
lowerLimit, 0.0,
upperLimit, upperLimit,
), ),
), ),
......
...@@ -2869,6 +2869,7 @@ class _Location { ...@@ -2869,6 +2869,7 @@ class _Location {
required this.file, required this.file,
required this.line, required this.line,
required this.column, required this.column,
// ignore: unused_element
this.name, this.name,
}); });
......
...@@ -1020,14 +1020,6 @@ class _TestSearchDelegate extends SearchDelegate<String> { ...@@ -1020,14 +1020,6 @@ class _TestSearchDelegate extends SearchDelegate<String> {
} }
class _TestEmptySearchDelegate extends SearchDelegate<String> { class _TestEmptySearchDelegate extends SearchDelegate<String> {
_TestEmptySearchDelegate({
this.suggestions = 'Suggestions',
this.result = 'Result',
}) : super();
final String suggestions;
final String result;
@override @override
Widget? buildLeading(BuildContext context) => null; Widget? buildLeading(BuildContext context) => null;
...@@ -1040,7 +1032,7 @@ class _TestEmptySearchDelegate extends SearchDelegate<String> { ...@@ -1040,7 +1032,7 @@ class _TestEmptySearchDelegate extends SearchDelegate<String> {
onPressed: () { onPressed: () {
showResults(context); showResults(context);
}, },
child: Text(suggestions), child: const Text('Suggestions'),
); );
} }
...@@ -1057,7 +1049,7 @@ class _TestEmptySearchDelegate extends SearchDelegate<String> { ...@@ -1057,7 +1049,7 @@ class _TestEmptySearchDelegate extends SearchDelegate<String> {
tooltip: 'Close', tooltip: 'Close',
icon: const Icon(Icons.arrow_back), icon: const Icon(Icons.arrow_back),
onPressed: () { onPressed: () {
close(context, result); close(context, 'Result');
}, },
), ),
); );
......
...@@ -186,10 +186,9 @@ class TestRecordingPaintingContext extends ClipContext implements PaintingContex ...@@ -186,10 +186,9 @@ class TestRecordingPaintingContext extends ClipContext implements PaintingContex
} }
class _MethodCall implements Invocation { class _MethodCall implements Invocation {
_MethodCall(this._name, [ this._arguments = const <dynamic>[], this._typeArguments = const <Type> []]); _MethodCall(this._name, [ this._arguments = const <dynamic>[]]);
final Symbol _name; final Symbol _name;
final List<dynamic> _arguments; final List<dynamic> _arguments;
final List<Type> _typeArguments;
@override @override
bool get isAccessor => false; bool get isAccessor => false;
@override @override
...@@ -205,7 +204,7 @@ class _MethodCall implements Invocation { ...@@ -205,7 +204,7 @@ class _MethodCall implements Invocation {
@override @override
List<dynamic> get positionalArguments => _arguments; List<dynamic> get positionalArguments => _arguments;
@override @override
List<Type> get typeArguments => _typeArguments; List<Type> get typeArguments => const <Type> [];
} }
String _valueName(Object? value) { String _valueName(Object? value) {
......
...@@ -21,13 +21,11 @@ class _TestSliverPersistentHeaderDelegate extends SliverPersistentHeaderDelegate ...@@ -21,13 +21,11 @@ class _TestSliverPersistentHeaderDelegate extends SliverPersistentHeaderDelegate
this.key, this.key,
required this.minExtent, required this.minExtent,
required this.maxExtent, required this.maxExtent,
this.child,
this.vsync = const TestVSync(), this.vsync = const TestVSync(),
this.showOnScreenConfiguration = const PersistentHeaderShowOnScreenConfiguration(), this.showOnScreenConfiguration = const PersistentHeaderShowOnScreenConfiguration(),
}); });
final Key? key; final Key? key;
final Widget? child;
@override @override
final double maxExtent; final double maxExtent;
...@@ -42,7 +40,7 @@ class _TestSliverPersistentHeaderDelegate extends SliverPersistentHeaderDelegate ...@@ -42,7 +40,7 @@ class _TestSliverPersistentHeaderDelegate extends SliverPersistentHeaderDelegate
final PersistentHeaderShowOnScreenConfiguration showOnScreenConfiguration; final PersistentHeaderShowOnScreenConfiguration showOnScreenConfiguration;
@override @override
Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) => child ?? SizedBox.expand(key: key); Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) => SizedBox.expand(key: key);
@override @override
bool shouldRebuild(_TestSliverPersistentHeaderDelegate oldDelegate) => true; bool shouldRebuild(_TestSliverPersistentHeaderDelegate oldDelegate) => true;
......
...@@ -14,7 +14,6 @@ class _TestSliverPersistentHeaderDelegate extends SliverPersistentHeaderDelegate ...@@ -14,7 +14,6 @@ class _TestSliverPersistentHeaderDelegate extends SliverPersistentHeaderDelegate
required this.maxExtent, required this.maxExtent,
required this.child, required this.child,
this.vsync = const TestVSync(), this.vsync = const TestVSync(),
this.showOnScreenConfiguration = const PersistentHeaderShowOnScreenConfiguration(),
}); });
final Widget child; final Widget child;
...@@ -29,7 +28,7 @@ class _TestSliverPersistentHeaderDelegate extends SliverPersistentHeaderDelegate ...@@ -29,7 +28,7 @@ class _TestSliverPersistentHeaderDelegate extends SliverPersistentHeaderDelegate
final TickerProvider? vsync; final TickerProvider? vsync;
@override @override
final PersistentHeaderShowOnScreenConfiguration showOnScreenConfiguration; final PersistentHeaderShowOnScreenConfiguration showOnScreenConfiguration = const PersistentHeaderShowOnScreenConfiguration();
@override @override
Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) => child; Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) => child;
......
...@@ -72,8 +72,6 @@ Future<void> testImageQuality(WidgetTester tester, ui.FilterQuality? quality) as ...@@ -72,8 +72,6 @@ Future<void> testImageQuality(WidgetTester tester, ui.FilterQuality? quality) as
} }
class _TestImageStreamCompleter extends ImageStreamCompleter { class _TestImageStreamCompleter extends ImageStreamCompleter {
_TestImageStreamCompleter([this._currentImage]);
ImageInfo? _currentImage; ImageInfo? _currentImage;
final Set<ImageStreamListener> listeners = <ImageStreamListener>{}; final Set<ImageStreamListener> listeners = <ImageStreamListener>{};
......
...@@ -201,12 +201,10 @@ class _Diagonal extends RenderObjectWidget with SlottedMultiChildRenderObjectWid ...@@ -201,12 +201,10 @@ class _Diagonal extends RenderObjectWidget with SlottedMultiChildRenderObjectWid
Key? key, Key? key,
this.topLeft, this.topLeft,
this.bottomRight, this.bottomRight,
this.backgroundColor,
}) : super(key: key); }) : super(key: key);
final Widget? topLeft; final Widget? topLeft;
final Widget? bottomRight; final Widget? bottomRight;
final Color? backgroundColor;
@override @override
Iterable<_DiagonalSlot> get slots => _DiagonalSlot.values; Iterable<_DiagonalSlot> get slots => _DiagonalSlot.values;
......
...@@ -258,9 +258,7 @@ class _TickingWidgetState extends State<_TickingWidget> with SingleTickerProvide ...@@ -258,9 +258,7 @@ class _TickingWidgetState extends State<_TickingWidget> with SingleTickerProvide
} }
class _MultiTickingWidget extends StatefulWidget { class _MultiTickingWidget extends StatefulWidget {
const _MultiTickingWidget({Key? key, this.onTick}) : super(key: key); const _MultiTickingWidget({Key? key}) : super(key: key);
final VoidCallback? onTick;
@override @override
State<_MultiTickingWidget> createState() => _MultiTickingWidgetState(); State<_MultiTickingWidget> createState() => _MultiTickingWidgetState();
...@@ -274,7 +272,6 @@ class _MultiTickingWidgetState extends State<_MultiTickingWidget> with TickerPro ...@@ -274,7 +272,6 @@ class _MultiTickingWidgetState extends State<_MultiTickingWidget> with TickerPro
void initState() { void initState() {
super.initState(); super.initState();
ticker = createTicker((Duration _) { ticker = createTicker((Duration _) {
widget.onTick?.call();
})..start(); })..start();
} }
......
...@@ -809,11 +809,9 @@ class _SingleTickerTestState extends State<_SingleTickerTest> with SingleTickerP ...@@ -809,11 +809,9 @@ class _SingleTickerTestState extends State<_SingleTickerTest> with SingleTickerP
class _AlwaysAnimating extends StatefulWidget { class _AlwaysAnimating extends StatefulWidget {
const _AlwaysAnimating({ const _AlwaysAnimating({
this.child,
required this.onPaint, required this.onPaint,
}); });
final Widget? child;
final VoidCallback onPaint; final VoidCallback onPaint;
@override @override
...@@ -846,7 +844,6 @@ class _AlwaysAnimatingState extends State<_AlwaysAnimating> with SingleTickerPro ...@@ -846,7 +844,6 @@ class _AlwaysAnimatingState extends State<_AlwaysAnimating> with SingleTickerPro
builder: (BuildContext context, Widget? child) { builder: (BuildContext context, Widget? child) {
return CustomPaint( return CustomPaint(
painter: _AlwaysRepaint(widget.onPaint), painter: _AlwaysRepaint(widget.onPaint),
child: widget.child,
); );
}, },
); );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment