@@ -91,8 +91,8 @@ The typical cycle for editing a recipe is:
...
@@ -91,8 +91,8 @@ The typical cycle for editing a recipe is:
existing expected output to match the new output. Verify completely new test
existing expected output to match the new output. Verify completely new test
cases by altering the `GenTests` method of the recipe. The recipe is required
cases by altering the `GenTests` method of the recipe. The recipe is required
to have 100% test coverage.
to have 100% test coverage.
3. Run `led get-builder 'luci.flutter.prod:BUILDER_NAME' | led edit -p 'revision="GIT_HASH"' | led edit-recipe-bundle | led launch`, where `BUILDER_NAME` is the builder name (e.g. `Linux Engine`), and
3. Run `led get-builder 'luci.flutter.prod:BUILDER_NAME' | led edit -p 'revision="GIT_HASH"' | led edit-recipe-bundle | led launch`, where `BUILDER_NAME` is the builder name (e.g. `Linux Engine`), and
`GIT_HASH` is the hash to build (which is important for the engine but not
`GIT_HASH` is the hash to build (which is important for the engine but not
for the framework).
for the framework).
4. To submit a CL, you need a local branch first (`git checkout -b [some branch name]`).
4. To submit a CL, you need a local branch first (`git checkout -b [some branch name]`).
5. Upload the patch (`git commit`, `git cl upload`) and send it to someone in
5. Upload the patch (`git commit`, `git cl upload`) and send it to someone in
assert(matches>=minimumMatches,'Expected to find at least $minimumMatches files with extension ".$extension" in "$workingDirectory", but only found $matches.');
}
Future<String>_getCommitRange()async{
// Using --fork-point is more conservative, and will result in the correct
// fork point, but when running locally, it may return nothing. Git is
// guaranteed to return a (reasonable, but maybe not optimal) result when not
// using --fork-point, so we fall back to that if we can't get a definitive
// fork point. See "git merge-base" documentation for more info.
