Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
036cae36
Unverified
Commit
036cae36
authored
May 13, 2022
by
Jenn Magder
Committed by
GitHub
May 13, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enforce minimum plugin version iOS 11 (#103545)
parent
9f28b83c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
plugin_tests.dart
dev/devicelab/lib/tasks/plugin_tests.dart
+3
-3
podhelper.rb
packages/flutter_tools/bin/podhelper.rb
+1
-1
No files found.
dev/devicelab/lib/tasks/plugin_tests.dart
View file @
036cae36
...
...
@@ -204,7 +204,7 @@ class $dartPluginClass {
podspecContent
=
podspecContent
.
replaceFirst
(
versionString
,
target
==
'ios'
?
"s.platform = :ios, '
7
.0'"
?
"s.platform = :ios, '
10
.0'"
:
"s.platform = :osx, '10.8'"
);
podspec
.
writeAsStringSync
(
podspecContent
,
flush:
true
);
...
...
@@ -240,8 +240,8 @@ class $dartPluginClass {
if
(
target
==
'ios'
)
{
// Plugins with versions lower than the app version should not have IPHONEOS_DEPLOYMENT_TARGET set.
// The plugintest plugin target should not have IPHONEOS_DEPLOYMENT_TARGET set since it has been lowered
// in _reduceDarwinPluginMinimumVersion to
7, which is below the target version of 9
.
if
(
podsProjectContent
.
contains
(
'IPHONEOS_DEPLOYMENT_TARGET =
7
'
))
{
// in _reduceDarwinPluginMinimumVersion to
10, which is below the target version of 11
.
if
(
podsProjectContent
.
contains
(
'IPHONEOS_DEPLOYMENT_TARGET =
10
'
))
{
throw
TaskResult
.
failure
(
'Plugin build setting IPHONEOS_DEPLOYMENT_TARGET not removed'
);
}
if
(!
podsProjectContent
.
contains
(
r'"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "$(inherited) i386";'
))
{
...
...
packages/flutter_tools/bin/podhelper.rb
View file @
036cae36
...
...
@@ -34,7 +34,7 @@ def flutter_additional_ios_build_settings(target)
return
unless
target
.
platform_name
==
:ios
# [target.deployment_target] is a [String] formatted as "8.0".
inherit_deployment_target
=
target
.
deployment_target
[
/\d+/
].
to_i
<
9
inherit_deployment_target
=
target
.
deployment_target
[
/\d+/
].
to_i
<
11
# This podhelper script is at $FLUTTER_ROOT/packages/flutter_tools/bin.
# Add search paths from $FLUTTER_ROOT/bin/cache/artifacts/engine.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment