Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
02517b8b
Unverified
Commit
02517b8b
authored
Nov 29, 2017
by
Greg Spencer
Committed by
GitHub
Nov 29, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix some minor typos/grammar issues (#13230)
parent
fc2f3b4f
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
6 deletions
+7
-6
object.dart
packages/flutter/lib/src/rendering/object.dart
+6
-5
semantics.dart
packages/flutter/lib/src/semantics/semantics.dart
+1
-1
No files found.
packages/flutter/lib/src/rendering/object.dart
View file @
02517b8b
...
...
@@ -649,7 +649,7 @@ class PipelineOwner {
/// duplicate calls quickly.
final
VoidCallback
onNeedVisualUpdate
;
/// Called whenever this pipeline owner creates a
s
semantics object.
/// Called whenever this pipeline owner creates a semantics object.
///
/// Typical implementations will schedule the creation of the initial
/// semantics tree.
...
...
@@ -703,7 +703,7 @@ class PipelineOwner {
Timeline
.
startSync
(
'Layout'
,
arguments:
timelineWhitelistArguments
);
_debugDoingLayout
=
true
;
try
{
// TODO(ianh): assert that we're not allowing previously dirty nodes to redirty them
e
selves
// TODO(ianh): assert that we're not allowing previously dirty nodes to redirty themselves
while
(
_nodesNeedingLayout
.
isNotEmpty
)
{
final
List
<
RenderObject
>
dirtyNodes
=
_nodesNeedingLayout
;
_nodesNeedingLayout
=
<
RenderObject
>[];
...
...
@@ -797,8 +797,8 @@ class PipelineOwner {
/// The object that is managing semantics for this pipeline owner, if any.
///
/// An owner is created by [ensureSemantics]. The owner is valid for as long
/// there are [SemanticsHandle] returned by [ensureSemantics] that have not
/// yet be disposed. Once the last handle has been disposed, the
/// there are [SemanticsHandle]
s
returned by [ensureSemantics] that have not
/// yet be
en
disposed. Once the last handle has been disposed, the
/// [semanticsOwner] field will revert to null, and the previous owner will be
/// disposed.
///
...
...
@@ -972,7 +972,7 @@ class PipelineOwner {
///
/// ### Layout interactions between render objects
///
/// In general, the layout of a render
box
should only depend on the output of
/// In general, the layout of a render
object
should only depend on the output of
/// its child's layout, and then only if `parentUsesSize` is set to true in the
/// [layout] call. Furthermore, if it is set to true, the parent must call the
/// child's [layout] if the child is to be rendered, because otherwise the
...
...
@@ -1086,6 +1086,7 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im
///
/// Used in debug messages.
dynamic
debugCreator
;
void
_debugReportException
(
String
method
,
dynamic
exception
,
StackTrace
stack
)
{
FlutterError
.
reportError
(
new
FlutterErrorDetailsForRendering
(
exception:
exception
,
...
...
packages/flutter/lib/src/semantics/semantics.dart
View file @
02517b8b
...
...
@@ -1324,7 +1324,7 @@ class SemanticsConfiguration {
/// result in this configuration.
///
/// Only configurations that have [explicitChildNodes] set to false can
/// absorb other configurations and its recommended to only absorb compatible
/// absorb other configurations and it
i
s recommended to only absorb compatible
/// configurations as determined by [isCompatibleWith].
void
absorb
(
SemanticsConfiguration
other
)
{
assert
(!
explicitChildNodes
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment