Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
01f779e9
Unverified
Commit
01f779e9
authored
Oct 16, 2019
by
Jonah Williams
Committed by
GitHub
Oct 16, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix NPE in Chrome Device (#42813)
parent
fbbc4fa8
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
1 deletion
+2
-1
web_device.dart
packages/flutter_tools/lib/src/web/web_device.dart
+1
-1
devices_test.dart
...es/flutter_tools/test/general.shard/web/devices_test.dart
+1
-0
No files found.
packages/flutter_tools/lib/src/web/web_device.dart
View file @
01f779e9
...
...
@@ -61,7 +61,7 @@ class ChromeDevice extends Device {
@override
DeviceLogReader
getLogReader
({
ApplicationPackage
app
})
{
return
NoOpDeviceLogReader
(
app
.
name
);
return
NoOpDeviceLogReader
(
app
?
.
name
);
}
@override
...
...
packages/flutter_tools/test/general.shard/web/devices_test.dart
View file @
01f779e9
...
...
@@ -42,6 +42,7 @@ void main() {
expect
(
chromeDevice
.
supportsScreenshot
,
false
);
expect
(
await
chromeDevice
.
isLocalEmulator
,
false
);
expect
(
chromeDevice
.
getLogReader
(
app:
mockWebApplicationPackage
),
isInstanceOf
<
NoOpDeviceLogReader
>());
expect
(
chromeDevice
.
getLogReader
(),
isInstanceOf
<
NoOpDeviceLogReader
>());
expect
(
await
chromeDevice
.
portForwarder
.
forward
(
1
),
1
);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment